From: Jani Nikula <jani.nikula@linux.intel.com>
To: Manasi Navare <manasi.d.navare@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/dp: Add HBR3 rate (8.1 Gbps) to default rates array
Date: Wed, 28 Feb 2018 11:05:24 +0200 [thread overview]
Message-ID: <87muztv60b.fsf@intel.com> (raw)
In-Reply-To: <1519770261-3758-1-git-send-email-manasi.d.navare@intel.com>
On Tue, 27 Feb 2018, Manasi Navare <manasi.d.navare@intel.com> wrote:
> default_rates[] array is a superset of all the link rates supported
> by sink devices. DP 1.3 specification adds HBR3 (8.1Gbps) link rate
> to the set of link rates supported by sink. This patch adds this rate
> to default_rates[] array that gets used to populate the sink_rates[]
> array limited by max rate obtained from DP_MAX_LINK_RATE DPCD register.
>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
> ---
> drivers/gpu/drm/i915/intel_dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 2a3b3ae..f0766fb 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -103,7 +103,7 @@ static const int skl_rates[] = { 162000, 216000, 270000,
> static const int cnl_rates[] = { 162000, 216000, 270000,
> 324000, 432000, 540000,
> 648000, 810000 };
> -static const int default_rates[] = { 162000, 270000, 540000 };
> +static const int default_rates[] = { 162000, 270000, 540000, 810000 };
Now this is part of the reason I wanted to do [1], especially the part
that switches to using hsw_rates and g4x_rates, instead of doing
ARRAY_SIZE(default_rates) - 1. This innocent looking patch now "enables"
HBR2 on g4x and HBR3 on hsw and bdw.
BR,
Jani.
[1] http://patchwork.freedesktop.org/patch/msgid/20180227105911.4485-1-jani.nikula@intel.com
>
> /**
> * intel_dp_is_edp - is the given port attached to an eDP panel (either CPU or PCH)
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-02-28 9:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 22:24 [PATCH] drm/i915/dp: Add HBR3 rate (8.1 Gbps) to default rates array Manasi Navare
2018-02-27 23:11 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-02-28 0:27 ` ✓ Fi.CI.IGT: " Patchwork
2018-02-28 9:05 ` Jani Nikula [this message]
2018-02-28 17:16 ` [PATCH] " Manasi Navare
2018-02-28 18:29 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87muztv60b.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=manasi.d.navare@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).