From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: [PATCH 3/4] drm/i915/dvo: Fixup commentary
Date: Wed, 14 Feb 2018 12:25:24 +0200
Message-ID: <87mv0b6f6z.fsf@intel.com>
References: <20180214092909.27040-1-chris@chris-wilson.co.uk>
 <20180214092909.27040-3-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by gabe.freedesktop.org (Postfix) with ESMTPS id C0FD66E3CB
 for <intel-gfx@lists.freedesktop.org>; Wed, 14 Feb 2018 10:25:32 +0000 (UTC)
In-Reply-To: <20180214092909.27040-3-chris@chris-wilson.co.uk>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gV2VkLCAxNCBGZWIgMjAxOCwgQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28u
dWs+IHdyb3RlOgo+IFJlbW92ZSB0aGUga2VybmVsZG9jIG1hcmt1cCBhcHBsaWVkIHRvIG5vbi1r
ZXJuZWxkb2MgY29tbWVudHMgYW5kCj4gY29udmVydCB0aGUgbXVsdGlsaW5lIGNvbW1lbnRzIHRv
IHRoZSBjYW5vbmljYWwgc3R5bGUuCj4KPiBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kdm8u
YzozMDM6IHdhcm5pbmc6IEZ1bmN0aW9uIHBhcmFtZXRlciBvciBtZW1iZXIgJ2Nvbm5lY3Rvcicg
bm90IGRlc2NyaWJlZCBpbiAnaW50ZWxfZHZvX2RldGVjdCcKPiBkcml2ZXJzL2dwdS9kcm0vaTkx
NS9pbnRlbF9kdm8uYzozMDM6IHdhcm5pbmc6IEZ1bmN0aW9uIHBhcmFtZXRlciBvciBtZW1iZXIg
J2ZvcmNlJyBub3QgZGVzY3JpYmVkIGluICdpbnRlbF9kdm9fZGV0ZWN0Jwo+IGRyaXZlcnMvZ3B1
L2RybS9pOTE1L2ludGVsX2R2by5jOjM4Mjogd2FybmluZzogRnVuY3Rpb24gcGFyYW1ldGVyIG9y
IG1lbWJlciAnZW5jb2Rlcicgbm90IGRlc2NyaWJlZCBpbiAnaW50ZWxfZHZvX2dldF9jdXJyZW50
X21vZGUnCj4KPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNv
bi5jby51az4KClJldmlld2VkLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29t
PgoKCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2R2by5jIHwgMjggKysrKysr
KysrKysrKysrLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygr
KSwgMTMgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv
aW50ZWxfZHZvLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kdm8uYwo+IGluZGV4IDU5
YzA2NmNhMTRlNS4uZWIwYzU1OWIyNzE1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2ludGVsX2R2by5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHZvLmMK
PiBAQCAtMjQ1LDcgKzI0NSw4IEBAIHN0YXRpYyBib29sIGludGVsX2R2b19jb21wdXRlX2NvbmZp
ZyhzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPiAgCQlpbnRlbF9kdm8tPmF0dGFjaGVk
X2Nvbm5lY3Rvci0+cGFuZWwuZml4ZWRfbW9kZTsKPiAgCXN0cnVjdCBkcm1fZGlzcGxheV9tb2Rl
ICphZGp1c3RlZF9tb2RlID0gJnBpcGVfY29uZmlnLT5iYXNlLmFkanVzdGVkX21vZGU7Cj4gIAo+
IC0JLyogSWYgd2UgaGF2ZSB0aW1pbmdzIGZyb20gdGhlIEJJT1MgZm9yIHRoZSBwYW5lbCwgcHV0
IHRoZW0gaW4KPiArCS8qCj4gKwkgKiBJZiB3ZSBoYXZlIHRpbWluZ3MgZnJvbSB0aGUgQklPUyBm
b3IgdGhlIHBhbmVsLCBwdXQgdGhlbSBpbgo+ICAJICogdG8gdGhlIGFkanVzdGVkIG1vZGUuICBU
aGUgQ1JUQyB3aWxsIGJlIHNldCB1cCBmb3IgdGhpcyBtb2RlLAo+ICAJICogd2l0aCB0aGUgcGFu
ZWwgc2NhbGluZyBzZXQgdXAgdG8gc291cmNlIGZyb20gdGhlIEgvVkRpc3BsYXkKPiAgCSAqIG9m
IHRoZSBvcmlnaW5hbCBtb2RlLgo+IEBAIC0yOTMsMTEgKzI5NCw2IEBAIHN0YXRpYyB2b2lkIGlu
dGVsX2R2b19wcmVfZW5hYmxlKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ICAJSTkx
NV9XUklURShkdm9fcmVnLCBkdm9fdmFsKTsKPiAgfQo+ICAKPiAtLyoqCj4gLSAqIERldGVjdCB0
aGUgb3V0cHV0IGNvbm5lY3Rpb24gb24gb3VyIERWTyBkZXZpY2UuCj4gLSAqCj4gLSAqIFVuaW1w
bGVtZW50ZWQuCj4gLSAqLwo+ICBzdGF0aWMgZW51bSBkcm1fY29ubmVjdG9yX3N0YXR1cwo+ICBp
bnRlbF9kdm9fZGV0ZWN0KHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsIGJvb2wgZm9y
Y2UpCj4gIHsKPiBAQCAtMzEzLDcgKzMwOSw4IEBAIHN0YXRpYyBpbnQgaW50ZWxfZHZvX2dldF9t
b2RlcyhzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yKQo+ICAJY29uc3Qgc3RydWN0IGRy
bV9kaXNwbGF5X21vZGUgKmZpeGVkX21vZGUgPQo+ICAJCXRvX2ludGVsX2Nvbm5lY3Rvcihjb25u
ZWN0b3IpLT5wYW5lbC5maXhlZF9tb2RlOwo+ICAKPiAtCS8qIFdlIHNob3VsZCBwcm9iYWJseSBo
YXZlIGFuIGkyYyBkcml2ZXIgZ2V0X21vZGVzIGZ1bmN0aW9uIGZvciB0aG9zZQo+ICsJLyoKPiAr
CSAqIFdlIHNob3VsZCBwcm9iYWJseSBoYXZlIGFuIGkyYyBkcml2ZXIgZ2V0X21vZGVzIGZ1bmN0
aW9uIGZvciB0aG9zZQo+ICAJICogZGV2aWNlcyB3aGljaCB3aWxsIGhhdmUgYSBmaXhlZCBzZXQg
b2YgbW9kZXMgZGV0ZXJtaW5lZCBieSB0aGUgY2hpcAo+ICAJICogKFRWLW91dCwgZm9yIGV4YW1w
bGUpLCBidXQgZm9yIG5vdyB3aXRoIGp1c3QgVE1EUyBhbmQgTFZEUywKPiAgCSAqIHRoYXQncyBu
b3QgdGhlIGNhc2UuCj4gQEAgLTM3MSw3ICszNjgsNyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGRy
bV9lbmNvZGVyX2Z1bmNzIGludGVsX2R2b19lbmNfZnVuY3MgPSB7Cj4gIAkuZGVzdHJveSA9IGlu
dGVsX2R2b19lbmNfZGVzdHJveSwKPiAgfTsKPiAgCj4gLS8qKgo+ICsvKgo+ICAgKiBBdHRlbXB0
cyB0byBnZXQgYSBmaXhlZCBwYW5lbCB0aW1pbmcgZm9yIExWRFMgKGN1cnJlbnRseSBvbmx5IHRo
ZSBpODMwKS4KPiAgICoKPiAgICogT3RoZXIgY2hpcHMgd2l0aCBEVk8gTFZEUyB3aWxsIG5lZWQg
dG8gZXh0ZW5kIHRoaXMgdG8gZGVhbCB3aXRoIHRoZSBMVkRTCj4gQEAgLTQ0Myw3ICs0NDAsOCBA
QCB2b2lkIGludGVsX2R2b19pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikK
PiAgCQl1aW50MzJfdCBkcGxsW0k5MTVfTUFYX1BJUEVTXTsKPiAgCQllbnVtIHBvcnQgcG9ydDsK
PiAgCj4gLQkJLyogQWxsb3cgdGhlIEkyQyBkcml2ZXIgaW5mbyB0byBzcGVjaWZ5IHRoZSBHUElP
IHRvIGJlIHVzZWQgaW4KPiArCQkvKgo+ICsJCSAqIEFsbG93IHRoZSBJMkMgZHJpdmVyIGluZm8g
dG8gc3BlY2lmeSB0aGUgR1BJTyB0byBiZSB1c2VkIGluCj4gIAkJICogc3BlY2lhbCBjYXNlcywg
YnV0IG90aGVyd2lzZSBkZWZhdWx0IHRvIHdoYXQncyBkZWZpbmVkCj4gIAkJICogaW4gdGhlIHNw
ZWMuCj4gIAkJICovCj4gQEAgLTQ1NCw3ICs0NTIsOCBAQCB2b2lkIGludGVsX2R2b19pbml0KHN0
cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgCQllbHNlCj4gIAkJCWdwaW8gPSBH
TUJVU19QSU5fRFBCOwo+ICAKPiAtCQkvKiBTZXQgdXAgdGhlIEkyQyBidXMgbmVjZXNzYXJ5IGZv
ciB0aGUgY2hpcCB3ZSdyZSBwcm9iaW5nLgo+ICsJCS8qCj4gKwkJICogU2V0IHVwIHRoZSBJMkMg
YnVzIG5lY2Vzc2FyeSBmb3IgdGhlIGNoaXAgd2UncmUgcHJvYmluZy4KPiAgCQkgKiBJdCBhcHBl
YXJzIHRoYXQgZXZlcnl0aGluZyBpcyBvbiBHUElPRSBleGNlcHQgZm9yIHBhbmVscwo+ICAJCSAq
IG9uIGk4MzAgbGFwdG9wcywgd2hpY2ggYXJlIG9uIEdQSU9CIChEVk9BKS4KPiAgCQkgKi8KPiBA
QCAtNDYyLDEyICs0NjEsMTQgQEAgdm9pZCBpbnRlbF9kdm9faW5pdChzdHJ1Y3QgZHJtX2k5MTVf
cHJpdmF0ZSAqZGV2X3ByaXYpCj4gIAo+ICAJCWludGVsX2R2by0+ZGV2ID0gKmR2bzsKPiAgCj4g
LQkJLyogR01CVVMgTkFLIGhhbmRsaW5nIHNlZW1zIHRvIGJlIHVuc3RhYmxlLCBoZW5jZSBsZXQg
dGhlCj4gKwkJLyoKPiArCQkgKiBHTUJVUyBOQUsgaGFuZGxpbmcgc2VlbXMgdG8gYmUgdW5zdGFi
bGUsIGhlbmNlIGxldCB0aGUKPiAgCQkgKiB0cmFuc21pdHRlciBkZXRlY3Rpb24gcnVuIGluIGJp
dCBiYW5naW5nIG1vZGUgZm9yIG5vdy4KPiAgCQkgKi8KPiAgCQlpbnRlbF9nbWJ1c19mb3JjZV9i
aXQoaTJjLCB0cnVlKTsKPiAgCj4gLQkJLyogbnMyNTAxIHJlcXVpcmVzIHRoZSBEVk8gMnggY2xv
Y2sgYmVmb3JlIGl0IHdpbGwKPiArCQkvKgo+ICsJCSAqIG5zMjUwMSByZXF1aXJlcyB0aGUgRFZP
IDJ4IGNsb2NrIGJlZm9yZSBpdCB3aWxsCj4gIAkJICogcmVzcG9uZCB0byBpMmMgYWNjZXNzZXMs
IHNvIG1ha2Ugc3VyZSB3ZSBoYXZlCj4gIAkJICogaGF2ZSB0aGUgY2xvY2sgZW5hYmxlZCBiZWZv
cmUgd2UgYXR0ZW1wdCB0bwo+ICAJCSAqIGluaXRpYWxpemUgdGhlIGRldmljZS4KPiBAQCAtNTI1
LDcgKzUyNiw4IEBAIHZvaWQgaW50ZWxfZHZvX2luaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg
KmRldl9wcml2KQo+ICAKPiAgCQlpbnRlbF9jb25uZWN0b3JfYXR0YWNoX2VuY29kZXIoaW50ZWxf
Y29ubmVjdG9yLCBpbnRlbF9lbmNvZGVyKTsKPiAgCQlpZiAoZHZvLT50eXBlID09IElOVEVMX0RW
T19DSElQX0xWRFMpIHsKPiAtCQkJLyogRm9yIG91ciBMVkRTIGNoaXBzZXRzLCB3ZSBzaG91bGQg
aG9wZWZ1bGx5IGJlIGFibGUKPiArCQkJLyoKPiArCQkJICogRm9yIG91ciBMVkRTIGNoaXBzZXRz
LCB3ZSBzaG91bGQgaG9wZWZ1bGx5IGJlIGFibGUKPiAgCQkJICogdG8gZGlnIHRoZSBmaXhlZCBw
YW5lbCBtb2RlIG91dCBvZiB0aGUgQklPUyBkYXRhLgo+ICAJCQkgKiBIb3dldmVyLCBpdCdzIGlu
IGEgZGlmZmVyZW50IGZvcm1hdCBmcm9tIHRoZSBCSU9TCj4gIAkJCSAqIGRhdGEgb24gY2hpcHNl
dHMgd2l0aCBpbnRlZ3JhdGVkIExWRFMgKHN0b3JlZCBpbiBBSU0KCi0tIApKYW5pIE5pa3VsYSwg
SW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n
ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h
aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==