From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v2 5/8] drm/i915: Check error return when converting pipe to connector Date: Thu, 27 Apr 2017 10:09:35 +0300 Message-ID: <87mvb2s4wg.fsf@intel.com> References: <1493214013-15580-6-git-send-email-imre.deak@intel.com> <1493227086-3807-3-git-send-email-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4CAB46E66E for ; Thu, 27 Apr 2017 07:07:06 +0000 (UTC) In-Reply-To: <1493227086-3807-3-git-send-email-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAyNiBBcHIgMjAxNywgSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPiB3cm90 ZToKPiBBbiBlcnJvciBmcm9tIGludGVsX2dldF9waXBlX2Zyb21fY29ubmVjdG9yKCkgd291bGQg bWVhbiBhIGJ1ZyBzb21ld2hlcmUKPiBlbHNlLCBidXQgd2Ugc3RpbGwgc2hvdWxkIGNoZWNrIGZv ciBpdCB0byBwcmV2ZW50IHNvbWUgb3RoZXIgbW9yZQo+IG9ic2N1cmUgYnVnIGxhdGVyLgo+Cj4g djI6Cj4gLSBGYWxsIGJhY2sgdG8gYSByZWFzb25hYmxlIGRlZmF1bHQgaW5zdGVhZCBvZiBiYWls aW5nIG91dCBpbiBjYXNlIG9mCj4gICBlcnJvci4gKEphbmkpCj4KPiBDYzogSmFuaSBOaWt1bGEg PGphbmkubmlrdWxhQGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBJbXJlIERlYWsgPGltcmUu ZGVha0BpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BhbmVs LmMgfCAxNyArKysrKysrKysrKysrKy0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMTQgaW5zZXJ0aW9u cygrKSwgMyBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9wYW5lbC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcGFuZWwuYwo+IGlu ZGV4IGNiNTBjNTIuLjM1MDhmNDIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfcGFuZWwuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BhbmVsLmMK PiBAQCAtODg4LDEwICs4ODgsMTQgQEAgc3RhdGljIHZvaWQgcGNoX2VuYWJsZV9iYWNrbGlnaHQo c3RydWN0IGludGVsX2Nvbm5lY3RvciAqY29ubmVjdG9yKQo+ICAJc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShjb25uZWN0b3ItPmJhc2UuZGV2KTsKPiAgCXN0cnVj dCBpbnRlbF9wYW5lbCAqcGFuZWwgPSAmY29ubmVjdG9yLT5wYW5lbDsKPiAgCWVudW0gcGlwZSBw aXBlID0gaW50ZWxfZ2V0X3BpcGVfZnJvbV9jb25uZWN0b3IoY29ubmVjdG9yKTsKPiAtCWVudW0g dHJhbnNjb2RlciBjcHVfdHJhbnNjb2RlciA9Cj4gLQkJaW50ZWxfcGlwZV90b19jcHVfdHJhbnNj b2RlcihkZXZfcHJpdiwgcGlwZSk7Cj4gKwllbnVtIHRyYW5zY29kZXIgY3B1X3RyYW5zY29kZXI7 Cj4gIAl1MzIgY3B1X2N0bDIsIHBjaF9jdGwxLCBwY2hfY3RsMjsKPiAgCj4gKwlpZiAoIVdBUk5f T05fT05DRShwaXBlID09IElOVkFMSURfUElQRSkpCj4gKwkJY3B1X3RyYW5zY29kZXIgPSBpbnRl bF9waXBlX3RvX2NwdV90cmFuc2NvZGVyKGRldl9wcml2LCBwaXBlKTsKPiArCWVsc2UKPiArCQlj cHVfdHJhbnNjb2RlciA9IFRSQU5TQ09ERVJfRURQOwo+ICsKPiAgCWNwdV9jdGwyID0gSTkxNV9S RUFEKEJMQ19QV01fQ1BVX0NUTDIpOwo+ICAJaWYgKGNwdV9jdGwyICYgQkxNX1BXTV9FTkFCTEUp IHsKPiAgCQlEUk1fREVCVUdfS01TKCJjcHUgYmFja2xpZ2h0IGFscmVhZHkgZW5hYmxlZFxuIik7 Cj4gQEAgLTk3Myw2ICs5NzcsOSBAQCBzdGF0aWMgdm9pZCBpOTY1X2VuYWJsZV9iYWNrbGlnaHQo c3RydWN0IGludGVsX2Nvbm5lY3RvciAqY29ubmVjdG9yKQo+ICAJZW51bSBwaXBlIHBpcGUgPSBp bnRlbF9nZXRfcGlwZV9mcm9tX2Nvbm5lY3Rvcihjb25uZWN0b3IpOwo+ICAJdTMyIGN0bCwgY3Rs MiwgZnJlcTsKPiAgCj4gKwlpZiAoV0FSTl9PTl9PTkNFKHBpcGUgPT0gSU5WQUxJRF9QSVBFKSkK PiArCQlwaXBlID0gUElQRV9BOwo+ICsKPiAgCWN0bDIgPSBJOTE1X1JFQUQoQkxDX1BXTV9DVEwy KTsKPiAgCWlmIChjdGwyICYgQkxNX1BXTV9FTkFCTEUpIHsKPiAgCQlEUk1fREVCVUdfS01TKCJi YWNrbGlnaHQgYWxyZWFkeSBlbmFibGVkXG4iKTsKPiBAQCAtMTAzNyw2ICsxMDQ0LDkgQEAgc3Rh dGljIHZvaWQgYnh0X2VuYWJsZV9iYWNrbGlnaHQoc3RydWN0IGludGVsX2Nvbm5lY3RvciAqY29u bmVjdG9yKQo+ICAJZW51bSBwaXBlIHBpcGUgPSBpbnRlbF9nZXRfcGlwZV9mcm9tX2Nvbm5lY3Rv cihjb25uZWN0b3IpOwo+ICAJdTMyIHB3bV9jdGwsIHZhbDsKPiAgCj4gKwlpZiAoV0FSTl9PTl9P TkNFKHBpcGUpID09IFBJUEVfSU5WQUxJRCkKCkxlIHBpcGUgaW52YWxpZD8gSSB0aGluayB5b3Ug bWVhbiBJTlZBTElEX1BJUEUgaGVyZS4KCkJSLApKYW5pLgoKPiArCQlwaXBlID0gUElQRV9BOwo+ ICsKPiAgCS8qIENvbnRyb2xsZXIgMSB1c2VzIHRoZSB1dGlsaXR5IHBpbi4gKi8KPiAgCWlmIChw YW5lbC0+YmFja2xpZ2h0LmNvbnRyb2xsZXIgPT0gMSkgewo+ICAJCXZhbCA9IEk5MTVfUkVBRChV VElMX1BJTl9DVEwpOwo+IEBAIC0xMDkzLDcgKzExMDMsOCBAQCB2b2lkIGludGVsX3BhbmVsX2Vu YWJsZV9iYWNrbGlnaHQoc3RydWN0IGludGVsX2Nvbm5lY3RvciAqY29ubmVjdG9yKQo+ICAJaWYg KCFwYW5lbC0+YmFja2xpZ2h0LnByZXNlbnQpCj4gIAkJcmV0dXJuOwo+ICAKPiAtCURSTV9ERUJV R19LTVMoInBpcGUgJWNcbiIsIHBpcGVfbmFtZShwaXBlKSk7Cj4gKwlpZiAoIVdBUk5fT05fT05D RShwaXBlID09IElOVkFMSURfUElQRSkpCj4gKwkJRFJNX0RFQlVHX0tNUygicGlwZSAlY1xuIiwg cGlwZV9uYW1lKHBpcGUpKTsKPiAgCj4gIAltdXRleF9sb2NrKCZkZXZfcHJpdi0+YmFja2xpZ2h0 X2xvY2spOwoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENl bnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl bC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK