[PATCH] drm/i915/kbl: Limit WaDisableDynamicCreditSharing to A0

[PATCH] drm/i915/kbl: Limit WaDisableDynamicCreditSharing to A0

[Mika Kuoppala]

Bspec states that this wa is for A0/B0 revs and this is noted in
commit b90420467232 ("drm/i915/kbl: Add WaDisableDynamicCreditSharing")
But other sources state that this is for A0 only. Also evidence indicates
that with some kbl variants the bit doesn't stick. So trust the other
sources and limit the scope for A0 only.

References: https://bugs.freedesktop.org/show_bug.cgi?id=96981
Fixes: b90420467232 ("drm/i915/kbl: Add WaDisableDynamicCreditSharing")
Cc: drm-intel-fixes@lists.freedesktop.org
Cc: Matthew Auld <matthew.auld@intel.com>
Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
---
 drivers/gpu/drm/i915/intel_ringbuffer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
index 09f01c641c14..63316a6ea46c 100644
--- a/drivers/gpu/drm/i915/intel_ringbuffer.c
+++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
@@ -1176,7 +1176,7 @@ static int kbl_init_workarounds(struct intel_engine_cs *engine)
 				   GEN9_GAPS_TSV_CREDIT_DISABLE));
 
 	/* WaDisableDynamicCreditSharing:kbl */
-	if (IS_KBL_REVID(dev_priv, 0, KBL_REVID_B0))
+	if (IS_KBL_REVID(dev_priv, 0, KBL_REVID_A0))
 		WA_SET_BIT(GAMT_CHKN_BIT_REG,
 			   GAMT_CHKN_DISABLE_DYNAMIC_CREDIT_SHARING);
 
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Ro.CI.BAT: success for drm/i915/kbl: Limit WaDisableDynamicCreditSharing to A0

[Patchwork]

== Series Details ==

Series: drm/i915/kbl: Limit WaDisableDynamicCreditSharing to A0
URL   : https://patchwork.freedesktop.org/series/10945/
State : success

== Summary ==

Series 10945v1 drm/i915/kbl: Limit WaDisableDynamicCreditSharing to A0
http://patchwork.freedesktop.org/api/1.0/series/10945/revisions/1/mbox

Test drv_module_reload_basic:
                skip       -> PASS       (ro-ivb-i7-3770)
Test kms_cursor_legacy:
        Subgroup basic-flip-vs-cursor-varying-size:
                fail       -> PASS       (ro-hsw-i7-4770r)
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-c:
                incomplete -> PASS       (fi-hsw-i7-4770k)

fi-hsw-i7-4770k  total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22 
fi-kbl-qkkr      total:244  pass:187  dwarn:29  dfail:0   fail:2   skip:26 
fi-skl-i5-6260u  total:244  pass:224  dwarn:4   dfail:0   fail:2   skip:14 
fi-skl-i7-6700k  total:244  pass:208  dwarn:4   dfail:2   fail:2   skip:28 
fi-snb-i7-2600   total:244  pass:202  dwarn:0   dfail:0   fail:0   skip:42 
ro-bdw-i7-5600u  total:240  pass:207  dwarn:0   dfail:0   fail:1   skip:32 
ro-bsw-n3050     total:240  pass:195  dwarn:0   dfail:0   fail:3   skip:42 
ro-hsw-i3-4010u  total:240  pass:214  dwarn:0   dfail:0   fail:0   skip:26 
ro-hsw-i7-4770r  total:240  pass:214  dwarn:0   dfail:0   fail:0   skip:26 
ro-ilk1-i5-650   total:235  pass:173  dwarn:0   dfail:0   fail:2   skip:60 
ro-ivb-i7-3770   total:240  pass:205  dwarn:0   dfail:0   fail:0   skip:35 
ro-ivb2-i7-3770  total:240  pass:209  dwarn:0   dfail:0   fail:0   skip:31 
ro-skl3-i5-6260u total:240  pass:222  dwarn:0   dfail:0   fail:4   skip:14 
ro-bdw-i5-5250u failed to connect after reboot
ro-bdw-i7-5557U failed to connect after reboot
ro-byt-n2820 failed to connect after reboot

Results at /archive/results/CI_IGT_test/RO_Patchwork_1834/

55feda1 drm-intel-nightly: 2016y-08m-11d-08h-50m-44s UTC integration manifest
e2b755d drm/i915/kbl: Limit WaDisableDynamicCreditSharing to A0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/kbl: Limit WaDisableDynamicCreditSharing to A0

[Matthew Auld]

But in the bug report the pciid=0x5916 and rev=0x0, which makes it KBL
A0, right? So something else must be going on here. There also seems
to be a mismatch between #2226938, #2225763 and #2225601 in terms of
what the wa should be, some make reference to bit[30].
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/kbl: Limit WaDisableDynamicCreditSharing to A0

[Mika Kuoppala]

Matthew Auld <matthew.william.auld@gmail.com> writes:

> But in the bug report the pciid=0x5916 and rev=0x0, which makes it KBL
> A0, right? So something else must be going on here.

You are right. This patch can't affect the bug in question.
I haven't yet found a similar machine so it is still mystery why the
write doesn't stick.

-Mika

> to be a mismatch between #2226938, #2225763 and #2225601 in terms of
> what the wa should be, some make reference to bit[30].

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx