From: Jani Nikula <jani.nikula@linux.intel.com>
To: Lukas Wunner <lukas@wunner.de>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Clean up LVDS register handling harder
Date: Wed, 11 Nov 2015 17:54:40 +0200 [thread overview]
Message-ID: <87mvukh6pr.fsf@intel.com> (raw)
In-Reply-To: <20151107141244.AB7616E242@gabe.freedesktop.org>
On Thu, 05 Nov 2015, Lukas Wunner <lukas@wunner.de> wrote:
> Minor fixup to d0669d007542 ("drm/i915: Clean up LVDS register
> handling") which intended to read lvds_reg just once at the
> beginning of intel_lvds_init() and use that throughout the rest
> of the function but accidentally missed one register readout.
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Lukas Wunner <lukas@wunner.de>
Pushed to drm-intel-next-queued, thanks for the patch.
BR,
Jani.
> ---
> drivers/gpu/drm/i915/intel_lvds.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c
> index 7f39b8a..baf72c1 100644
> --- a/drivers/gpu/drm/i915/intel_lvds.c
> +++ b/drivers/gpu/drm/i915/intel_lvds.c
> @@ -1164,8 +1164,7 @@ out:
> DRM_DEBUG_KMS("detected %s-link lvds configuration\n",
> lvds_encoder->is_dual_link ? "dual" : "single");
>
> - lvds_encoder->a3_power = I915_READ(lvds_encoder->reg) &
> - LVDS_A3_POWER_MASK;
> + lvds_encoder->a3_power = lvds & LVDS_A3_POWER_MASK;
>
> lvds_connector->lid_notifier.notifier_call = intel_lid_notify;
> if (acpi_lid_notifier_register(&lvds_connector->lid_notifier)) {
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-11-11 15:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-05 8:30 [PATCH] drm/i915: Clean up LVDS register handling harder Lukas Wunner
2015-11-11 15:54 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mvukh6pr.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lukas@wunner.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox