[drm-intel:for-linux-next 809/813] drivers/gpu/drm/i915/intel_dsi_pll.c:387:6: sparse: symbol 'vlv_dsi_reset_clocks' was not declared. Should it be static?

[drm-intel:for-linux-next 809/813] drivers/gpu/drm/i915/intel_dsi_pll.c:387:6: sparse: symbol 'vlv_dsi_reset_clocks' was not declared. Should it be static?

[kbuild test robot]

tree:   git://anongit.freedesktop.org/drm-intel for-linux-next
head:   068127601eefa0565f4b2f4d82750cad9e37000c
commit: b389a45c6b2f9b310ddf631d23b9e3e045cf747b [809/813] drm/i915/bxt: DSI disable and post-disable
reproduce:
        # apt-get install sparse
        git checkout b389a45c6b2f9b310ddf631d23b9e3e045cf747b
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/gpu/drm/i915/intel_dsi_pll.c:387:6: sparse: symbol 'vlv_dsi_reset_clocks' was not declared. Should it be static?
>> drivers/gpu/drm/i915/intel_dsi_pll.c:545:6: sparse: symbol 'bxt_dsi_reset_clocks' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

[RFC PATCH drm-intel] drm/i915/bxt: vlv_dsi_reset_clocks() can be static

[kbuild test robot]

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 intel_dsi_pll.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_dsi_pll.c b/drivers/gpu/drm/i915/intel_dsi_pll.c
index c9a38f4..d85f1eaf 100644
--- a/drivers/gpu/drm/i915/intel_dsi_pll.c
+++ b/drivers/gpu/drm/i915/intel_dsi_pll.c
@@ -384,7 +384,7 @@ u32 vlv_get_dsi_pclk(struct intel_encoder *encoder, int pipe_bpp)
 	return pclk;
 }
 
-void vlv_dsi_reset_clocks(struct intel_encoder *encoder, enum port port)
+static void vlv_dsi_reset_clocks(struct intel_encoder *encoder, enum port port)
 {
 	u32 temp;
 	struct drm_i915_private *dev_priv = encoder->base.dev->dev_private;
@@ -542,7 +542,7 @@ void intel_disable_dsi_pll(struct intel_encoder *encoder)
 		bxt_disable_dsi_pll(encoder);
 }
 
-void bxt_dsi_reset_clocks(struct intel_encoder *encoder, enum port port)
+static void bxt_dsi_reset_clocks(struct intel_encoder *encoder, enum port port)
 {
 	u32 tmp;
 	struct drm_device *dev = encoder->base.dev;
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [RFC PATCH drm-intel] drm/i915/bxt: vlv_dsi_reset_clocks() can be static

[Jani Nikula]

On Mon, 05 Oct 2015, kbuild test robot <fengguang.wu@intel.com> wrote:
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>


> ---
>  intel_dsi_pll.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dsi_pll.c b/drivers/gpu/drm/i915/intel_dsi_pll.c
> index c9a38f4..d85f1eaf 100644
> --- a/drivers/gpu/drm/i915/intel_dsi_pll.c
> +++ b/drivers/gpu/drm/i915/intel_dsi_pll.c
> @@ -384,7 +384,7 @@ u32 vlv_get_dsi_pclk(struct intel_encoder *encoder, int pipe_bpp)
>  	return pclk;
>  }
>  
> -void vlv_dsi_reset_clocks(struct intel_encoder *encoder, enum port port)
> +static void vlv_dsi_reset_clocks(struct intel_encoder *encoder, enum port port)
>  {
>  	u32 temp;
>  	struct drm_i915_private *dev_priv = encoder->base.dev->dev_private;
> @@ -542,7 +542,7 @@ void intel_disable_dsi_pll(struct intel_encoder *encoder)
>  		bxt_disable_dsi_pll(encoder);
>  }
>  
> -void bxt_dsi_reset_clocks(struct intel_encoder *encoder, enum port port)
> +static void bxt_dsi_reset_clocks(struct intel_encoder *encoder, enum port port)
>  {
>  	u32 tmp;
>  	struct drm_device *dev = encoder->base.dev;

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [RFC PATCH drm-intel] drm/i915/bxt: vlv_dsi_reset_clocks() can be static

[Daniel Vetter]

On Mon, Oct 05, 2015 at 02:57:57PM +0300, Jani Nikula wrote:
> On Mon, 05 Oct 2015, kbuild test robot <fengguang.wu@intel.com> wrote:
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> 
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>

Queued for -next, thanks for the patch.
-Daniel

> 
> 
> > ---
> >  intel_dsi_pll.c |    4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_dsi_pll.c b/drivers/gpu/drm/i915/intel_dsi_pll.c
> > index c9a38f4..d85f1eaf 100644
> > --- a/drivers/gpu/drm/i915/intel_dsi_pll.c
> > +++ b/drivers/gpu/drm/i915/intel_dsi_pll.c
> > @@ -384,7 +384,7 @@ u32 vlv_get_dsi_pclk(struct intel_encoder *encoder, int pipe_bpp)
> >  	return pclk;
> >  }
> >  
> > -void vlv_dsi_reset_clocks(struct intel_encoder *encoder, enum port port)
> > +static void vlv_dsi_reset_clocks(struct intel_encoder *encoder, enum port port)
> >  {
> >  	u32 temp;
> >  	struct drm_i915_private *dev_priv = encoder->base.dev->dev_private;
> > @@ -542,7 +542,7 @@ void intel_disable_dsi_pll(struct intel_encoder *encoder)
> >  		bxt_disable_dsi_pll(encoder);
> >  }
> >  
> > -void bxt_dsi_reset_clocks(struct intel_encoder *encoder, enum port port)
> > +static void bxt_dsi_reset_clocks(struct intel_encoder *encoder, enum port port)
> >  {
> >  	u32 tmp;
> >  	struct drm_device *dev = encoder->base.dev;
> 
> -- 
> Jani Nikula, Intel Open Source Technology Center

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx