From: Jani Nikula <jani.nikula@linux.intel.com>
To: Arun Siluvery <arun.siluvery@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 05/10] drm/i915/bdw: Remove WaDisableThreadStallDopClockGating
Date: Mon, 28 Sep 2015 11:44:12 +0300 [thread overview]
Message-ID: <87mvw7kk6b.fsf@intel.com> (raw)
In-Reply-To: <1443199246-30893-6-git-send-email-arun.siluvery@linux.intel.com>
On Fri, 25 Sep 2015, Arun Siluvery <arun.siluvery@linux.intel.com> wrote:
> Dropping it because it is for pre-production stepping.
Hum, why have we added a pre-pro w/a without a stepping check... should
we backport this to stable kernels? What's the impact on production
hardware with vs. without the w/a?
BR,
Jani.
>
> Signed-off-by: Arun Siluvery <arun.siluvery@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_ringbuffer.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
> index d8fa9d1..0b545cf 100644
> --- a/drivers/gpu/drm/i915/intel_ringbuffer.c
> +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
> @@ -827,9 +827,6 @@ static int bdw_init_workarounds(struct intel_engine_cs *ring)
> if (ret)
> return ret;
>
> - /* WaDisableThreadStallDopClockGating:bdw (pre-production) */
> - WA_SET_BIT_MASKED(GEN8_ROW_CHICKEN, STALL_DOP_GATING_DISABLE);
> -
> /* WaDisableDopClockGating:bdw */
> WA_SET_BIT_MASKED(GEN7_ROW_CHICKEN2,
> DOP_CLOCK_GATING_DISABLE);
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-09-28 8:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-25 16:40 [PATCH v2 00/10] Gen8 WA cleanup patches Arun Siluvery
2015-09-25 16:40 ` [PATCH v2 01/10] drm/i915/gen8: Add gen8_init_workarounds for common WA Arun Siluvery
2015-09-25 16:40 ` [PATCH v2 02/10] drm/i915/gen8: Move INSTPM WA to common function Arun Siluvery
2015-09-25 16:40 ` [PATCH v2 03/10] drm/i915/gen8: Move WaDisableAsyncFlipPerfMode to common init fn Arun Siluvery
2015-09-25 16:40 ` [PATCH v2 04/10] drm/i915/gen8: Move WaDisablePartialInstShootdown " Arun Siluvery
2015-09-25 16:40 ` [PATCH v2 05/10] drm/i915/bdw: Remove WaDisableThreadStallDopClockGating Arun Siluvery
2015-09-28 8:44 ` Jani Nikula [this message]
2015-09-28 9:51 ` Arun Siluvery
2015-09-28 14:06 ` Daniel Vetter
2015-09-25 16:40 ` [PATCH v2 06/10] drm/i915/gen8: Move HiZ RAW stall optimization disable WA to common init fn Arun Siluvery
2015-09-25 16:40 ` [PATCH v2 07/10] drm/i915/gen8: Move Wa4x4STCOptimizationDisable " Arun Siluvery
2015-09-25 16:40 ` [PATCH v2 08/10] drm/i915/gen8: Move GEN7_GT_MODE WA " Arun Siluvery
2015-09-25 16:40 ` [PATCH v2 09/10] drm/i915/gen8: Move WaForceEnableNonCoherent " Arun Siluvery
2015-09-25 16:40 ` [PATCH v2 10/10] drm/i915/gen8: Move WaHdcDisableFetchWhenMasked " Arun Siluvery
2015-09-25 16:54 ` Ville Syrjälä
2015-09-28 14:07 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mvw7kk6b.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=arun.siluvery@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox