From: Jani Nikula <jani.nikula@linux.intel.com>
To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: Make sure we don't detect eDP on g4x
Date: Wed, 23 Sep 2015 17:07:31 +0300 [thread overview]
Message-ID: <87mvwdns9o.fsf@intel.com> (raw)
In-Reply-To: <1441994679-32766-1-git-send-email-ville.syrjala@linux.intel.com>
On Fri, 11 Sep 2015, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> We don't support eDP on g4x, so let's not even look at the VBT
> to determine the port type, just in case the VBT is bonkers
> on some g4x machines and indicates the precense of eDP.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/intel_dp.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 292c753..eb37335 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -5250,6 +5250,13 @@ bool intel_dp_is_edp(struct drm_device *dev, enum port port)
> [PORT_E] = DVO_PORT_DPE,
> };
>
> + /*
> + * eDP not supported on g4x. so bail out early just
> + * for a bit extra safety in case the VBT is bonkers.
> + */
> + if (INTEL_INFO(dev)->gen < 5)
> + return false;
> +
> if (port == PORT_A)
> return true;
>
> --
> 2.4.6
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-09-23 14:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 18:04 [PATCH 1/2] drm/i915: Make sure we don't detect eDP on g4x ville.syrjala
2015-09-11 18:04 ` [PATCH 2/2] drm/i915: Ignore "digital output" and "not HDMI output" bits for eDP detection ville.syrjala
2015-09-23 14:08 ` Jani Nikula
2015-09-23 15:00 ` Daniel Vetter
2015-09-23 14:07 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mvwdns9o.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox