drivers/gpu/drm/i915/i915_gem_gtt.c

drivers/gpu/drm/i915/i915_gem_gtt.c

[Andrew Morton]

I'm not sure what's happened to the drm code in linux-next - it's
exploding all over the place.  Did someone turn on -Werror without
doing anywhere near enough testing?

Anyway, I don't know how to fix this i386 build error:

drivers/gpu/drm/i915/i915_gem_gtt.c: In function 'gen8_ppgtt_init':
drivers/gpu/drm/i915/i915_gem_gtt.c:954:2: error: large integer implicitly truncated to unsigned type [-Werror=overflow]

        ppgtt->base.total = 1ULL << 32;

i915_address_space.total is a ulong: 32-bit.

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: drivers/gpu/drm/i915/i915_gem_gtt.c

[Damien Lespiau]

On Fri, May 22, 2015 at 02:17:32PM -0700, Andrew Morton wrote:
> I'm not sure what's happened to the drm code in linux-next - it's
> exploding all over the place.  Did someone turn on -Werror without
> doing anywhere near enough testing?
> 
> Anyway, I don't know how to fix this i386 build error:

Seems like you have CONFIG_DRM_I915_WERROR set?

We explicitely made sure to not enable -Werror by default, because
different versions of gcc will generate different set of warnings making
it roughly impossible to use -Werror by default (say, newer versions of
gcc with more clever warnings trying to compile old commits while
bisecting) 

-- 
Damien
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: drivers/gpu/drm/i915/i915_gem_gtt.c

[Andrew Morton]

On Sat, 23 May 2015 14:30:09 +0100 Damien Lespiau <damien.lespiau@intel.com> wrote:

> On Fri, May 22, 2015 at 02:17:32PM -0700, Andrew Morton wrote:
> > I'm not sure what's happened to the drm code in linux-next - it's
> > exploding all over the place.  Did someone turn on -Werror without
> > doing anywhere near enough testing?
> > 
> > Anyway, I don't know how to fix this i386 build error:
> 
> Seems like you have CONFIG_DRM_I915_WERROR set?

Yes.

> We explicitely made sure to not enable -Werror by default,

`make allmodconfig' enables CONFIG_DRM_I915_WERROR.

I'm not sure what is the approved way of fixing this.  Perhaps
disabling CONFIG_DRM_I915_WERROR when CONFIG_COMPILE_TEST=y.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] drivers/gpu/drm/i915/i915_gem_gtt.c

[Jani Nikula]

On Sat, 23 May 2015, Andrew Morton <akpm@linux-foundation.org> wrote:
> On Sat, 23 May 2015 14:30:09 +0100 Damien Lespiau <damien.lespiau@intel.com> wrote:
>
>> On Fri, May 22, 2015 at 02:17:32PM -0700, Andrew Morton wrote:
>> > I'm not sure what's happened to the drm code in linux-next - it's
>> > exploding all over the place.  Did someone turn on -Werror without
>> > doing anywhere near enough testing?
>> > 
>> > Anyway, I don't know how to fix this i386 build error:
>> 
>> Seems like you have CONFIG_DRM_I915_WERROR set?
>
> Yes.
>
>> We explicitely made sure to not enable -Werror by default,
>
> `make allmodconfig' enables CONFIG_DRM_I915_WERROR.

Right.

> I'm not sure what is the approved way of fixing this.  Perhaps
> disabling CONFIG_DRM_I915_WERROR when CONFIG_COMPILE_TEST=y.

Maybe the answer right now is to just drop that config. Daniel?


BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: drivers/gpu/drm/i915/i915_gem_gtt.c

[Daniel Vetter]

On Mon, May 25, 2015 at 7:32 AM, Jani Nikula
<jani.nikula@linux.intel.com> wrote:
>> I'm not sure what is the approved way of fixing this.  Perhaps
>> disabling CONFIG_DRM_I915_WERROR when CONFIG_COMPILE_TEST=y.
>
> Maybe the answer right now is to just drop that config. Daniel?

Agreed, that little experiment doesn't seem to be worth the trouble.
I've pushed/sent-out the revert.

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx