From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: [PATCH] drm/i915: Fix regression in the sprite plane update split
Date: Fri, 12 Sep 2014 10:12:37 +0300
Message-ID: <87mwa5cnx6.fsf@intel.com>
References: <871trikt11.fsf@intel.com>
 <1410468135-14639-1-git-send-email-gustavo@padovan.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
In-Reply-To: <1410468135-14639-1-git-send-email-gustavo@padovan.org>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Gustavo Padovan <gustavo@padovan.org>, intel-gfx@lists.freedesktop.org
Cc: Gustavo Padovan <gustavo.padovan@collabora.co.uk>, dri-devel@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, 11 Sep 2014, Gustavo Padovan <gustavo@padovan.org> wrote:
> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
>
> 7e4bf45dbd99a965c7b5d5944c6dc4246f171eb5 introduced the regression.
> We fix it by doing the right assignment of crtc_y
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=83747
> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

Thanks for the quick fix.

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/i915/intel_sprite.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
> index 90bb45f..78044bb 100644
> --- a/drivers/gpu/drm/i915/intel_sprite.c
> +++ b/drivers/gpu/drm/i915/intel_sprite.c
> @@ -1080,7 +1080,7 @@ intel_commit_sprite_plane(struct drm_plane *plane,
>  
>  		if (state->visible) {
>  			crtc_x = state->dst.x1;
> -			crtc_y = state->dst.x2;
> +			crtc_y = state->dst.y1;
>  			crtc_w = drm_rect_width(&state->dst);
>  			crtc_h = drm_rect_height(&state->dst);
>  			src_x = state->src.x1;
> -- 
> 1.9.3
>

-- 
Jani Nikula, Intel Open Source Technology Center