From: Jani Nikula <jani.nikula@linux.intel.com>
To: Damien Lespiau <damien.lespiau@intel.com>,
Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Show cursor size in debugfs/i915_display_info
Date: Fri, 04 Jul 2014 15:57:24 +0300 [thread overview]
Message-ID: <87mwcpcmdn.fsf@intel.com> (raw)
In-Reply-To: <20140704091117.GC7634@strange.ger.corp.intel.com>
On Fri, 04 Jul 2014, Damien Lespiau <damien.lespiau@intel.com> wrote:
> On Fri, Jul 04, 2014 at 08:20:11AM +0100, Chris Wilson wrote:
>> Inlcude the pipe-size and cursor-size in debugfs.
>>
>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
Pushed to dinq, thanks for the patch and review.
BR,
Jani.
>
> --
> Damien
>
>> ---
>> drivers/gpu/drm/i915/i915_debugfs.c | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
>> index 0869df682f63..6d3f925ae9a2 100644
>> --- a/drivers/gpu/drm/i915/i915_debugfs.c
>> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
>> @@ -2434,17 +2434,17 @@ static int i915_display_info(struct seq_file *m, void *unused)
>> bool active;
>> int x, y;
>>
>> - seq_printf(m, "CRTC %d: pipe: %c, active: %s\n",
>> + seq_printf(m, "CRTC %d: pipe: %c, active=%s (size=%dx%d)\n",
>> crtc->base.base.id, pipe_name(crtc->pipe),
>> - yesno(crtc->active));
>> + yesno(crtc->active), crtc->config.pipe_src_w, crtc->config.pipe_src_h);
>> if (crtc->active) {
>> intel_crtc_info(m, crtc);
>>
>> active = cursor_position(dev, crtc->pipe, &x, &y);
>> - seq_printf(m, "\tcursor visible? %s, position (%d, %d), addr 0x%08x, active? %s\n",
>> + seq_printf(m, "\tcursor visible? %s, position (%d, %d), size %dx%d, addr 0x%08x, active? %s\n",
>> yesno(crtc->cursor_base),
>> - x, y, crtc->cursor_addr,
>> - yesno(active));
>> + x, y, crtc->cursor_width, crtc->cursor_height,
>> + crtc->cursor_addr, yesno(active));
>> }
>>
>> seq_printf(m, "\tunderrun reporting: cpu=%s pch=%s \n",
>> --
>> 2.0.1
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
prev parent reply other threads:[~2014-07-04 12:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-04 7:20 [PATCH] drm/i915: Show cursor size in debugfs/i915_display_info Chris Wilson
2014-07-04 9:11 ` Damien Lespiau
2014-07-04 12:57 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mwcpcmdn.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox