[PATCH] drm/i915: Show cursor size in debugfs/i915_display_info

[PATCH] drm/i915: Show cursor size in debugfs/i915_display_info

[Chris Wilson]

Inlcude the pipe-size and cursor-size in debugfs.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/i915_debugfs.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index 0869df682f63..6d3f925ae9a2 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -2434,17 +2434,17 @@ static int i915_display_info(struct seq_file *m, void *unused)
 		bool active;
 		int x, y;
 
-		seq_printf(m, "CRTC %d: pipe: %c, active: %s\n",
+		seq_printf(m, "CRTC %d: pipe: %c, active=%s (size=%dx%d)\n",
 			   crtc->base.base.id, pipe_name(crtc->pipe),
-			   yesno(crtc->active));
+			   yesno(crtc->active), crtc->config.pipe_src_w, crtc->config.pipe_src_h);
 		if (crtc->active) {
 			intel_crtc_info(m, crtc);
 
 			active = cursor_position(dev, crtc->pipe, &x, &y);
-			seq_printf(m, "\tcursor visible? %s, position (%d, %d), addr 0x%08x, active? %s\n",
+			seq_printf(m, "\tcursor visible? %s, position (%d, %d), size %dx%d, addr 0x%08x, active? %s\n",
 				   yesno(crtc->cursor_base),
-				   x, y, crtc->cursor_addr,
-				   yesno(active));
+				   x, y, crtc->cursor_width, crtc->cursor_height,
+				   crtc->cursor_addr, yesno(active));
 		}
 
 		seq_printf(m, "\tunderrun reporting: cpu=%s pch=%s \n",
-- 
2.0.1

Re: [PATCH] drm/i915: Show cursor size in debugfs/i915_display_info

[Damien Lespiau]

On Fri, Jul 04, 2014 at 08:20:11AM +0100, Chris Wilson wrote:
> Inlcude the pipe-size and cursor-size in debugfs.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>

-- 
Damien

> ---
>  drivers/gpu/drm/i915/i915_debugfs.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 0869df682f63..6d3f925ae9a2 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -2434,17 +2434,17 @@ static int i915_display_info(struct seq_file *m, void *unused)
>  		bool active;
>  		int x, y;
>  
> -		seq_printf(m, "CRTC %d: pipe: %c, active: %s\n",
> +		seq_printf(m, "CRTC %d: pipe: %c, active=%s (size=%dx%d)\n",
>  			   crtc->base.base.id, pipe_name(crtc->pipe),
> -			   yesno(crtc->active));
> +			   yesno(crtc->active), crtc->config.pipe_src_w, crtc->config.pipe_src_h);
>  		if (crtc->active) {
>  			intel_crtc_info(m, crtc);
>  
>  			active = cursor_position(dev, crtc->pipe, &x, &y);
> -			seq_printf(m, "\tcursor visible? %s, position (%d, %d), addr 0x%08x, active? %s\n",
> +			seq_printf(m, "\tcursor visible? %s, position (%d, %d), size %dx%d, addr 0x%08x, active? %s\n",
>  				   yesno(crtc->cursor_base),
> -				   x, y, crtc->cursor_addr,
> -				   yesno(active));
> +				   x, y, crtc->cursor_width, crtc->cursor_height,
> +				   crtc->cursor_addr, yesno(active));
>  		}
>  
>  		seq_printf(m, "\tunderrun reporting: cpu=%s pch=%s \n",
> -- 
> 2.0.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Show cursor size in debugfs/i915_display_info

[Jani Nikula]

On Fri, 04 Jul 2014, Damien Lespiau <damien.lespiau@intel.com> wrote:
> On Fri, Jul 04, 2014 at 08:20:11AM +0100, Chris Wilson wrote:
>> Inlcude the pipe-size and cursor-size in debugfs.
>> 
>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>

Pushed to dinq, thanks for the patch and review.

BR,
Jani.

>
> -- 
> Damien
>
>> ---
>>  drivers/gpu/drm/i915/i915_debugfs.c | 10 +++++-----
>>  1 file changed, 5 insertions(+), 5 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
>> index 0869df682f63..6d3f925ae9a2 100644
>> --- a/drivers/gpu/drm/i915/i915_debugfs.c
>> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
>> @@ -2434,17 +2434,17 @@ static int i915_display_info(struct seq_file *m, void *unused)
>>  		bool active;
>>  		int x, y;
>>  
>> -		seq_printf(m, "CRTC %d: pipe: %c, active: %s\n",
>> +		seq_printf(m, "CRTC %d: pipe: %c, active=%s (size=%dx%d)\n",
>>  			   crtc->base.base.id, pipe_name(crtc->pipe),
>> -			   yesno(crtc->active));
>> +			   yesno(crtc->active), crtc->config.pipe_src_w, crtc->config.pipe_src_h);
>>  		if (crtc->active) {
>>  			intel_crtc_info(m, crtc);
>>  
>>  			active = cursor_position(dev, crtc->pipe, &x, &y);
>> -			seq_printf(m, "\tcursor visible? %s, position (%d, %d), addr 0x%08x, active? %s\n",
>> +			seq_printf(m, "\tcursor visible? %s, position (%d, %d), size %dx%d, addr 0x%08x, active? %s\n",
>>  				   yesno(crtc->cursor_base),
>> -				   x, y, crtc->cursor_addr,
>> -				   yesno(active));
>> +				   x, y, crtc->cursor_width, crtc->cursor_height,
>> +				   crtc->cursor_addr, yesno(active));
>>  		}
>>  
>>  		seq_printf(m, "\tunderrun reporting: cpu=%s pch=%s \n",
>> -- 
>> 2.0.1
>> 
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center