From: Jani Nikula <jani.nikula@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>, Ben Widawsky <ben@bwidawsk.net>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>,
Ben Widawsky <benjamin.widawsky@intel.com>
Subject: Re: [PATCH] drm/i915/bdw: Fix 4g GGTT insert entries regression
Date: Thu, 06 Mar 2014 07:31:38 +0200 [thread overview]
Message-ID: <87mwh3vqo5.fsf@intel.com> (raw)
In-Reply-To: <20140305202820.GB17001@phenom.ffwll.local>
On Wed, 05 Mar 2014, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Wed, Mar 05, 2014 at 12:19:51PM -0800, Ben Widawsky wrote:
>> On Wed, Mar 05, 2014 at 07:24:37AM -0800, Ben Widawsky wrote:
>> > On Wed, Mar 05, 2014 at 11:13:12AM +0200, Jani Nikula wrote:
>> > > On Wed, 05 Mar 2014, Ben Widawsky <benjamin.widawsky@intel.com> wrote:
>> > > > The PDE needs to wrap after writing all the PTEs. Quite a small/silly
>> > > > bug to find in the massive change. It was introduced:
>> > > > commit 307dc4f99f6d3a74a78b0e776838f35b2004f14d
>> > > > Author: Ben Widawsky <benjamin.widawsky@intel.com>
>> > > > Date: Thu Feb 20 11:51:21 2014 -0800
>> > > >
>> > > > drm/i915/bdw: Reorganize PT allocations
>> > >
>> > > As noted in the bug, the commit merged to dinq is correct, and the
>> > > commit referenced above apparently only lives in some temporary branch.
>> > >
>> > > BR,
>> > > Jani.
>> > >
>> >
>> > My eyes are playing tricks on me. Sorry for the noise.
>> >
>>
>> It's not my eyes. It's something else. WTF is going on?
>
> My apologies, I seem to have been blind. Patch merged, will squash in.
I didn't just trust Daniel, I actually looked at the code before sending
the mail. And, well, *facepalm*. Apparently I mistook the ++pte that's
there for the new one added here. Sorry Ben.
BR,
Jani.
> -Daniel
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch
--
Jani Nikula, Intel Open Source Technology Center
prev parent reply other threads:[~2014-03-06 5:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 5:23 [PATCH] drm/i915/bdw: Fix 4g GGTT insert entries regression Ben Widawsky
2014-03-05 9:13 ` Jani Nikula
2014-03-05 15:24 ` Ben Widawsky
2014-03-05 20:19 ` Ben Widawsky
2014-03-05 20:28 ` Daniel Vetter
2014-03-06 5:31 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mwh3vqo5.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=ben@bwidawsk.net \
--cc=benjamin.widawsky@intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox