From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: [PATCH] drm/i915/bdw: Fix 4g GGTT insert entries
	regression
Date: Thu, 06 Mar 2014 07:31:38 +0200
Message-ID: <87mwh3vqo5.fsf@intel.com>
References: <1393996999-1930-1-git-send-email-benjamin.widawsky@intel.com>
	<87bnxl3t5j.fsf@intel.com> <20140305152437.GA20062@bwidawsk.net>
	<20140305201951.GA2777@bwidawsk.net>
	<20140305202820.GB17001@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
	by gabe.freedesktop.org (Postfix) with ESMTP id 537AAFA844
	for <intel-gfx@lists.freedesktop.org>;
	Wed,  5 Mar 2014 21:32:53 -0800 (PST)
In-Reply-To: <20140305202820.GB17001@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Daniel Vetter <daniel@ffwll.ch>, Ben Widawsky <ben@bwidawsk.net>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>, Ben Widawsky <benjamin.widawsky@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Wed, 05 Mar 2014, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Wed, Mar 05, 2014 at 12:19:51PM -0800, Ben Widawsky wrote:
>> On Wed, Mar 05, 2014 at 07:24:37AM -0800, Ben Widawsky wrote:
>> > On Wed, Mar 05, 2014 at 11:13:12AM +0200, Jani Nikula wrote:
>> > > On Wed, 05 Mar 2014, Ben Widawsky <benjamin.widawsky@intel.com> wrote:
>> > > > The PDE needs to wrap after writing all the PTEs. Quite a small/silly
>> > > > bug to find in the massive change. It was introduced:
>> > > > commit 307dc4f99f6d3a74a78b0e776838f35b2004f14d
>> > > > Author: Ben Widawsky <benjamin.widawsky@intel.com>
>> > > > Date:   Thu Feb 20 11:51:21 2014 -0800
>> > > >
>> > > >     drm/i915/bdw: Reorganize PT allocations
>> > > 
>> > > As noted in the bug, the commit merged to dinq is correct, and the
>> > > commit referenced above apparently only lives in some temporary branch.
>> > > 
>> > > BR,
>> > > Jani.
>> > > 
>> > 
>> > My eyes are playing tricks on me. Sorry for the noise.
>> > 
>> 
>> It's not my eyes. It's something else. WTF is going on?
>
> My apologies, I seem to have been blind. Patch merged, will squash in.

I didn't just trust Daniel, I actually looked at the code before sending
the mail. And, well, *facepalm*. Apparently I mistook the ++pte that's
there for the new one added here. Sorry Ben.

BR,
Jani.


> -Daniel
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch

-- 
Jani Nikula, Intel Open Source Technology Center