From: Jani Nikula <jani.nikula@intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, luiorpe1@gmail.com
Subject: Re: [PATCH] drm/i915: use backlight legacy combination mode also for i915gm/i945gm
Date: Thu, 27 Feb 2014 10:59:12 +0200 [thread overview]
Message-ID: <87mwhd6ie7.fsf@intel.com> (raw)
In-Reply-To: <20140226132042.GE3852@intel.com>
On Wed, 26 Feb 2014, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Tue, Feb 25, 2014 at 01:11:47PM +0200, Jani Nikula wrote:
>> i915gm and i945gm also seem to use and need the legacy combination mode
>> bit in BLC_PWM_CTL.
>>
>> v2: Also do this for i915gm (Ville).
>>
>> Reported-and-tested-by: Luis Ortega <luiorpe1@gmail.com>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=75001
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Looks sane enough for me.
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Pushed to -fixes, thanks for the review.
Jani.
>
>> ---
>> drivers/gpu/drm/i915/intel_panel.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c
>> index 5bc3f6ea1014..cb058408c70e 100644
>> --- a/drivers/gpu/drm/i915/intel_panel.c
>> +++ b/drivers/gpu/drm/i915/intel_panel.c
>> @@ -689,7 +689,7 @@ static void i9xx_enable_backlight(struct intel_connector *connector)
>> freq /= 0xff;
>>
>> ctl = freq << 17;
>> - if (IS_GEN2(dev) && panel->backlight.combination_mode)
>> + if (panel->backlight.combination_mode)
>> ctl |= BLM_LEGACY_MODE;
>> if (IS_PINEVIEW(dev) && panel->backlight.active_low_pwm)
>> ctl |= BLM_POLARITY_PNV;
>> @@ -970,7 +970,7 @@ static int i9xx_setup_backlight(struct intel_connector *connector)
>>
>> ctl = I915_READ(BLC_PWM_CTL);
>>
>> - if (IS_GEN2(dev))
>> + if (IS_GEN2(dev) || IS_I915GM(dev) || IS_I945GM(dev))
>> panel->backlight.combination_mode = ctl & BLM_LEGACY_MODE;
>>
>> if (IS_PINEVIEW(dev))
>> --
>> 1.7.9.5
>
> --
> Ville Syrjälä
> Intel OTC
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2014-02-27 8:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 9:14 [PATCH] drm/i915: use backlight legacy combination mode also for i945gm Jani Nikula
2014-02-25 10:47 ` Ville Syrjälä
2014-02-25 11:11 ` [PATCH] drm/i915: use backlight legacy combination mode also for i915gm/i945gm Jani Nikula
2014-02-26 13:20 ` Ville Syrjälä
2014-02-27 8:59 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mwhd6ie7.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=luiorpe1@gmail.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox