Re: [PATCH 1/2] drm/i915/dp: increase native aux defer retry timeout

[Jani Nikula <jani.nikula@intel.com>]

On Tue, 11 Feb 2014, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Tue, Feb 11, 2014 at 11:52:04AM +0200, Jani Nikula wrote:
>> Give more slack to sink devices before retrying on native aux
>> defer. AFAICT the 100 us timeout was not based on the DP spec.
>
> If the issue is that there is an unknown amount of time that must be
> waited before the device is ready, should we not try increasing the
> sleep value on each iteration?
>
> If you were to do that, I would put patch 2 (which lgtm) first.

All of this code will change when we eventually move to the common DP
aux helpers. I'd like to get such fixes in the common code after it's
been merged. Diverging now makes the conversion harder.

I also thought this would be the better order bisect-wise. 2/2 first
might be unnecessarily strict, possibly creating a false culprit in
bisect for any other possible DP issues. Maybe that is a silly thing to
worry about.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center