From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Usyskin, Alexander" <alexander.usyskin@intel.com>
Cc: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
"Poosa, Karthik" <karthik.poosa@intel.com>,
"De Marchi, Lucas" <lucas.demarchi@intel.com>,
"Richard Weinberger" <richard@nod.at>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Tvrtko Ursulin" <tursulin@ursulin.net>,
"Weil, Oren jer" <oren.jer.weil@intel.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 06/10] mtd: intel-dg: wake card on operations
Date: Mon, 30 Dec 2024 09:39:39 +0100 [thread overview]
Message-ID: <87o70ta7jo.fsf@bootlin.com> (raw)
In-Reply-To: <CY5PR11MB63663D73FA8ED331F8229AA1ED082@CY5PR11MB6366.namprd11.prod.outlook.com> (Alexander Usyskin's message of "Sun, 29 Dec 2024 15:08:56 +0000")
On 29/12/2024 at 15:08:56 GMT, "Usyskin, Alexander" <alexander.usyskin@intel.com> wrote:
>>
>> Hello Alexander,
>>
>> >> If so, I have to add patch for mtd subsystem to always have device for
>> master
>> >> initialized regardless of kernel flag.
>> >> Only to initialize struct device, not to create full mtd node.
>> >>
>> >> Miquel - are you agree to this?
>>
>> Conceptually yes, but please mind one thing: we do not break
>> userspace. So if you want to keep the master mtd device, fine, but you
>> need to do it in a consistent way so that people not enabling the kernel
>> flag won't get a new device in their rootfs, shifting all indexes
>> upwards.
>>
>> That being said, you are probably going in the right direction by doing
>> that.
>>
>> Thanks,
>> Miquèl
>
> I've looked into this endeavour and seemed that there a need for special
> device class and careful attention in release flow to use right class.
> It will take time to do right.
> Miquel, Rodrigo, Karthik, Lucas - may the DG NVM code be merged in the current
> form and this device be added later?
In general, yes. But maybe you want to select
CONFIG_MTD_PARTITIONED_MASTER (IIUC your problem).
Thanks,
Miquèl
next prev parent reply other threads:[~2024-12-30 8:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 14:01 [PATCH v3 00/10] mtd: add driver for Intel discrete graphics Alexander Usyskin
2024-11-19 14:01 ` [PATCH v3 01/10] mtd: add driver for intel graphics non-volatile memory device Alexander Usyskin
2024-11-19 14:01 ` [PATCH v3 02/10] mtd: intel-dg: implement region enumeration Alexander Usyskin
2024-12-17 19:40 ` Rodrigo Vivi
2024-11-19 14:01 ` [PATCH v3 03/10] mtd: intel-dg: implement access functions Alexander Usyskin
2024-12-17 22:48 ` Rodrigo Vivi
2024-12-19 10:39 ` Usyskin, Alexander
2024-11-19 14:01 ` [PATCH v3 04/10] mtd: intel-dg: register with mtd Alexander Usyskin
2024-11-19 14:01 ` [PATCH v3 05/10] mtd: intel-dg: align 64bit read and write Alexander Usyskin
2024-11-19 14:01 ` [PATCH v3 06/10] mtd: intel-dg: wake card on operations Alexander Usyskin
2024-12-17 22:49 ` Rodrigo Vivi
2024-12-18 5:13 ` Poosa, Karthik
2024-12-18 7:38 ` Usyskin, Alexander
2024-12-18 15:58 ` Usyskin, Alexander
2024-12-23 19:21 ` Miquel Raynal
2024-12-29 15:08 ` Usyskin, Alexander
2024-12-30 8:39 ` Miquel Raynal [this message]
2025-01-01 15:54 ` Usyskin, Alexander
2024-11-19 14:01 ` [PATCH v3 07/10] drm/i915/nvm: add nvm device for discrete graphics Alexander Usyskin
2024-11-19 14:01 ` [PATCH v3 08/10] drm/i915/nvm: add support for access mode Alexander Usyskin
2024-11-19 14:01 ` [PATCH v3 09/10] drm/xe/nvm: add on-die non-volatile memory device Alexander Usyskin
2024-11-19 14:01 ` [PATCH v3 10/10] drm/xe/nvm: add support for access mode Alexander Usyskin
2024-11-19 14:55 ` ✗ Fi.CI.CHECKPATCH: warning for mtd: add driver for Intel discrete graphics (rev3) Patchwork
2024-11-19 14:55 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-11-19 15:09 ` ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o70ta7jo.fsf@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=airlied@gmail.com \
--cc=alexander.usyskin@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=karthik.poosa@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=lucas.demarchi@intel.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=oren.jer.weil@intel.com \
--cc=richard@nod.at \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=thomas.hellstrom@linux.intel.com \
--cc=tursulin@ursulin.net \
--cc=tzimmermann@suse.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).