From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9541C4345F for ; Mon, 22 Apr 2024 08:28:45 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4116610F4AB; Mon, 22 Apr 2024 08:28:45 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="O8S9jYA+"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5E9BE10F4AB for ; Mon, 22 Apr 2024 08:28:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713774524; x=1745310524; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=Kv4KtqWsU+pFb7swfVXNqQQCLSvnTMJZcmh9TtCROoY=; b=O8S9jYA+iVG8pd9Z83KsAuUBUzeOkt8Q2XQvokBKy/Vi4eeKGC+QXHuj TLWg63mREj/3G3C+dqhmA/FF/XCXhfvIEEge6rdxFVvzGKWvSp7AthQvh qxihUZG9T3YPGukQc4ZIN5XrK5rH06LIvYYByctxHabiXx2TkuQQJ6x9Y CqOT5/Np2PH+cMoW7+f0uE7USPU8RhIQWKHrIOw3w+/RTc3ylXzi1zXh5 VcbuJlQDJKbOy0cz682pbMeYoX3itU1XUEQ/dP5iRiig3onuJlWRTRCnk ZrTN+Js3fViR+Ih3oLvO7JhaLoF5/xfhVEaKcG9NiULcxu4Cz+nmInzzx w==; X-CSE-ConnectionGUID: xUMbADOvS1idR2L3Q4s33w== X-CSE-MsgGUID: Z1M1vPtYTWmNNkzSfIAt3A== X-IronPort-AV: E=McAfee;i="6600,9927,11051"; a="9411885" X-IronPort-AV: E=Sophos;i="6.07,220,1708416000"; d="scan'208";a="9411885" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2024 01:28:43 -0700 X-CSE-ConnectionGUID: YjDHfyEYQYyRCJcMzfN8+g== X-CSE-MsgGUID: LR/64qSYQaKLedYwKe4o3g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,220,1708416000"; d="scan'208";a="28715447" Received: from ralbanes-mobl.ger.corp.intel.com (HELO localhost) ([10.252.63.128]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2024 01:28:41 -0700 From: Jani Nikula To: Jonathan Cavitt , intel-gfx@lists.freedesktop.org Cc: saurabhg.gupta@intel.com, jonathan.cavitt@intel.com, John.C.Harrison@intel.com, chris.p.wilson@linux.intel.com, andi.shyti@linux.intel.com, nirmoy.das@intel.com Subject: Re: [PATCH] drm/i915/gem: Downgrade stolen lmem setup warning In-Reply-To: <20240419212643.3915745-1-jonathan.cavitt@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20240419212643.3915745-1-jonathan.cavitt@intel.com> Date: Mon, 22 Apr 2024 11:28:37 +0300 Message-ID: <87o7a1vm16.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, 19 Apr 2024, Jonathan Cavitt wrote: > In the case where lmem_size < dsm_base, hardware is reporting that > stolen lmem is unusable. In this case, instead of throwing a warning, > we can continue execution as normal by disabling stolen LMEM support. > For example, this change will allow the following error report from > ATS-M to no longer apply: > > <6> [144.859887] pcieport 0000:4b:00.0: bridge window [mem 0xb1000000-0xb11fffff] > <6> [144.859900] pcieport 0000:4b:00.0: bridge window [mem 0x3bbc00000000-0x3bbc17ffffff 64bit pref] > <6> [144.859917] pcieport 0000:4c:01.0: PCI bridge to [bus 4d-4e] > <6> [144.859932] pcieport 0000:4c:01.0: bridge window [mem 0xb1000000-0xb11fffff] > <6> [144.859945] pcieport 0000:4c:01.0: bridge window [mem 0x3bbc00000000-0x3bbc17ffffff 64bit pref] > <6> [144.859984] i915 0000:4d:00.0: [drm] BAR2 resized to 256M > <6> [144.860640] i915 0000:4d:00.0: [drm] Using a reduced BAR size of 256MiB. Consider enabling 'Resizable BAR' or similar, if available in the BIOS. > <4> [144.860719] -----------[ cut here ]----------- > <4> [144.860727] WARNING: CPU: 17 PID: 1815 at drivers/gpu/drm/i915/gem/i915_gem_stolen.c:939 i915_gem_stolen_lmem_setup+0x38c/0x430 [i915] > <4> [144.861430] Modules linked in: i915 snd_intel_dspcfg snd_hda_codec snd_hwdep snd_hda_core snd_pcm vgem drm_shmem_helper prime_numbers i2c_algo_bit ttm video drm_display_helper drm_buddy fuse x86_pkg_temp_thermal coretemp kvm_intel kvm ixgbe mdio irqbypass ptp crct10dif_pclmul crc32_pclmul ghash_clmulni_intel pps_core i2c_i801 mei_me i2c_smbus mei wmi acpi_power_meter [last unloaded: i915] > <4> [144.861611] CPU: 17 PID: 1815 Comm: i915_module_loa Tainted: G U 6.8.0-rc5-drmtip_1515-g78f49af27723+ #1 > <4> [144.861624] Hardware name: Intel Corporation WHITLEY/WHITLEY, BIOS SE5C6200.86B.0020.P41.2109300305 09/30/2021 > <4> [144.861632] RIP: 0010:i915_gem_stolen_lmem_setup+0x38c/0x430 [i915] > <4> [144.862287] Code: ff 41 c1 e4 05 e9 ac fe ff ff 4d 63 e4 48 89 ef 48 85 ed 74 04 48 8b 7d 08 48 c7 c6 10 a3 7b a0 e8 e9 90 43 e1 e9 ee fd ff ff <0f> 0b 49 c7 c4 ed ff ff ff e9 e0 fd ff ff 0f b7 d2 48 c7 c6 00 d9 > <4> [144.862299] RSP: 0018:ffffc90005607980 EFLAGS: 00010207 > <4> [144.862315] RAX: fffffffffff00000 RBX: 0000000000000003 RCX: 0000000000000000 > > Fixes: https://gitlab.freedesktop.org/drm/intel/-/issues/10833 > No blank lines between trailers please. BR, Jani. > Suggested-by: Chris Wilson > Signed-off-by: Jonathan Cavitt > --- > drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c > index ad6dd7f3259bc..efa632a9e61c6 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c > @@ -936,8 +936,12 @@ i915_gem_stolen_lmem_setup(struct drm_i915_private *i915, u16 type, > } else { > /* Use DSM base address instead for stolen memory */ > dsm_base = intel_uncore_read64(uncore, GEN6_DSMBASE) & GEN11_BDSM_MASK; > - if (WARN_ON(lmem_size < dsm_base)) > + if (lmem_size < dsm_base) { > + drm_dbg(&i915->drm, > + "Disabling stolen memory support due to OOB placement: lmem_size = %lli vs dsm_base = %lli\n", > + lmem_size, dsm_base); > return ERR_PTR(-ENODEV); > + } > dsm_size = ALIGN_DOWN(lmem_size - dsm_base, SZ_1M); > } -- Jani Nikula, Intel