public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>,
	Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Intel-gfx@lists.freedesktop.org, Michael Cheng <michael.cheng@intel.com>
Subject: Re: [Intel-gfx] [RFC 0/2] Compile out integrated
Date: Tue, 01 Feb 2022 19:09:14 +0200	[thread overview]
Message-ID: <87o83qtsxx.fsf@intel.com> (raw)
In-Reply-To: <20220201165515.xntdympc4n3pdhif@ldmartin-desk2>

On Tue, 01 Feb 2022, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> On Tue, Feb 01, 2022 at 11:15:31AM +0000, Tvrtko Ursulin wrote:
>>From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>>Quicky and dirty hack based on some old ideas. Thought maybe the approach might
>>interest the Arm port guys. But with IS_GEN_RANGE removed easy gains are not so
>>big so meh.. Maybe some more easy wins with IS_DISPLAY_VER but I haven't looked
>>into that side.
>>
>> 3884664  449681    6720 4341065  423d49 i915.ko.tip
>> 3599989  429034    6688 4035711  3d947f i915.ko.noigp
>
> By these numbers probably it's hard to justify. Another thing to consider
> is that it's very common to have on the same system both
> integrated and discrete - doing this would remove at compile time any
> chance of driving the integrated one.

I guess the point was, the arm systems won't have integrated, and it's
anyway going to be a separate build.

BR,
Jani.


>
> Lucas De Marchi
>
>>
>>Note debug kconfig so everything is inflated. Whether or not the relative gain
>>would change with production kconfig I am not sure.
>>
>>P.S.
>>I was a bit curious there were no build errors around functions no longer used
>>so either there were none (would mean patch is not really that effective), or
>>something changed with compiler warnings/smarts. Haven't looked into it.
>>
>>Tvrtko Ursulin (2):
>>  igp kconfig
>>  jsl/ehl
>>
>> drivers/gpu/drm/i915/Kconfig                  |   5 +
>> drivers/gpu/drm/i915/Kconfig.platforms        |   7 +
>> .../drm/i915/display/intel_ddi_buf_trans.c    |   4 +-
>> drivers/gpu/drm/i915/display/intel_dpll_mgr.c |   2 +-
>> drivers/gpu/drm/i915/i915_drv.h               | 128 +++++++++++-------
>> drivers/gpu/drm/i915/i915_pci.c               |  44 +++++-
>> 6 files changed, 134 insertions(+), 56 deletions(-)
>> create mode 100644 drivers/gpu/drm/i915/Kconfig.platforms
>>
>>-- 
>>2.32.0
>>

-- 
Jani Nikula, Intel Open Source Graphics Center

  reply	other threads:[~2022-02-01 17:10 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-01 11:15 [Intel-gfx] [RFC 0/2] Compile out integrated Tvrtko Ursulin
2022-02-01 11:15 ` [Intel-gfx] [RFC 1/2] igp kconfig Tvrtko Ursulin
2022-02-01 11:15 ` [Intel-gfx] [RFC 2/2] jsl/ehl Tvrtko Ursulin
2022-02-01 11:26   ` Jani Nikula
2022-02-01 13:17 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Compile out integrated Patchwork
2022-02-01 13:18 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-02-01 13:47 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-02-01 16:55 ` [Intel-gfx] [RFC 0/2] " Lucas De Marchi
2022-02-01 17:09   ` Jani Nikula [this message]
2022-02-01 17:28     ` Lucas De Marchi
2022-02-02 10:26       ` Tvrtko Ursulin
2022-02-02 11:20         ` Jani Nikula
2022-02-02 12:17           ` Tvrtko Ursulin
2022-02-02 12:41             ` Jani Nikula
2022-02-02 16:26         ` Lucas De Marchi
2022-02-08 10:31           ` Tvrtko Ursulin
2022-02-08 20:34             ` Lucas De Marchi
2022-02-01 17:37 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
2022-02-02 11:51 ` [Intel-gfx] [RFC 0/2] " Tvrtko Ursulin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o83qtsxx.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=Intel-gfx@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    --cc=michael.cheng@intel.com \
    --cc=tvrtko.ursulin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox