From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D71BFC64E7B for ; Tue, 1 Dec 2020 16:16:44 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7B0A422240 for ; Tue, 1 Dec 2020 16:16:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B0A422240 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8EE9E89BC0; Tue, 1 Dec 2020 16:16:43 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id B2A7989BC0; Tue, 1 Dec 2020 16:16:42 +0000 (UTC) IronPort-SDR: h/PEUK83vTSJDaxNWYtBog7D6qN/BFBiPlVNsSRE7CUYnYBvKBmo0NR7ix7yU1ZJLROmMHHJ/u RoKAtpgnUV/g== X-IronPort-AV: E=McAfee;i="6000,8403,9822"; a="169354207" X-IronPort-AV: E=Sophos;i="5.78,384,1599548400"; d="scan'208";a="169354207" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2020 08:16:41 -0800 IronPort-SDR: aX0hiIXHbE2FBl6ASmw6VCrs+wjew2zRiyABJ0Yi+VdWUW4SVQPbeTWxehmw+RMdjqb7hv32SC +eo1plELL5jA== X-IronPort-AV: E=Sophos;i="5.78,384,1599548400"; d="scan'208";a="549631630" Received: from ivgeniax-mobl.ger.corp.intel.com (HELO localhost) ([10.249.42.176]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2020 08:16:38 -0800 From: Jani Nikula To: intel-gfx@lists.freedesktop.org In-Reply-To: <20201130111601.2817-9-jani.nikula@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20201130111601.2817-1-jani.nikula@intel.com> <20201130111601.2817-9-jani.nikula@intel.com> Date: Tue, 01 Dec 2020 18:16:35 +0200 Message-ID: <87o8jdcxi4.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH v3 09/10] drm/i915/gvt: replace I915_WRITE with intel_uncore_write X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Hang Yuan , chris@chris-wilson.co.uk, intel-gvt-dev@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, 30 Nov 2020, Jani Nikula wrote: > Let's avoid adding new I915_WRITE uses while we try to get rid of them. > > Fixes: 5f60b12edcd0 ("drm/i915/gvt: Save/restore HW status to support GVT suspend/resume") > Cc: Zhenyu Wang > Cc: Hang Yuan > Cc: Colin Xu > Cc: Zhi Wang > Cc: intel-gvt-dev@lists.freedesktop.org > Signed-off-by: Jani Nikula Pushed up to, but *excluding* this patch to dinq. Thanks for the reviews. Zhenyu, Zhi, may I have your review/ack for merging this one directly via dinq to not add a dependency on the gvt tree? BR, Jani. > --- > drivers/gpu/drm/i915/gvt/handlers.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gvt/handlers.c b/drivers/gpu/drm/i915/gvt/handlers.c > index 6f0706e885cb..eba626ba640f 100644 > --- a/drivers/gpu/drm/i915/gvt/handlers.c > +++ b/drivers/gpu/drm/i915/gvt/handlers.c > @@ -3693,7 +3693,7 @@ static inline int mmio_pm_restore_handler(struct intel_gvt *gvt, > struct drm_i915_private *dev_priv = gvt->gt->i915; > > if (gvt->mmio.mmio_attribute[offset >> 2] & F_PM_SAVE) > - I915_WRITE(_MMIO(offset), vgpu_vreg(vgpu, offset)); > + intel_uncore_write(&dev_priv->uncore, _MMIO(offset), vgpu_vreg(vgpu, offset)); > > return 0; > } -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx