From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Arkadiusz Hiler <arkadiusz.hiler@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/gen9: Remove WaEnableYV12BugFixInHalfSliceChicken7
Date: Tue, 18 Oct 2016 16:15:22 +0300 [thread overview]
Message-ID: <87oa2hre6t.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <87r37drh2d.fsf@gaia.fi.intel.com>
Mika Kuoppala <mika.kuoppala@linux.intel.com> writes:
> Arkadiusz Hiler <arkadiusz.hiler@intel.com> writes:
>
>> Dropping WA because it was for early steppings.
>>
>> It is fixed in newer preproduction and all production revisions.
>>
>
> We have used References tag to point to a relevant document
> that has more information. Like for this, it should be:
>
> References: HSD#2126385
>
> From there I did figure out that this should be from skl:C0 onwards.
>
> So based on that, we need this wa still.
I fell victim of out-of-date/conflicting information.
Arkadiusz kindly pointed me to the correct sources and cleared
the confusion. I am convinced we can drop this workaround.
Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>
>
> -Mika
>
>
>> Cc: Michal Winiarski <michal.winiarski@intel.com>
>> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
>> ---
>> drivers/gpu/drm/i915/intel_ringbuffer.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
>> index e107455..32786ba 100644
>> --- a/drivers/gpu/drm/i915/intel_ringbuffer.c
>> +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
>> @@ -849,10 +849,8 @@ static int gen9_init_workarounds(struct intel_engine_cs *engine)
>> */
>> }
>>
>> - /* WaEnableYV12BugFixInHalfSliceChicken7:skl,bxt,kbl */
>> /* WaEnableSamplerGPGPUPreemptionSupport:skl,bxt,kbl */
>> WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7,
>> - GEN9_ENABLE_YV12_BUGFIX |
>> GEN9_ENABLE_GPGPU_PREEMPTION);
>>
>> /* Wa4x4STCOptimizationDisable:skl,bxt,kbl */
>> --
>> 2.7.4
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-10-18 13:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 11:31 [PATCH] drm/i915/gen9: Remove WaEnableYV12BugFixInHalfSliceChicken7 Arkadiusz Hiler
2016-10-18 12:13 ` Mika Kuoppala
2016-10-18 13:15 ` Mika Kuoppala [this message]
2016-10-18 13:25 ` Chris Wilson
2016-10-18 14:06 ` Mika Kuoppala
2016-10-18 15:09 ` [PATCH v2] " Arkadiusz Hiler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oa2hre6t.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=arkadiusz.hiler@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox