public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: intel-gfx@lists.freedesktop.org, ville.syrjala@linux.intel.com,
	daniel.vetter@intel.com, tiwai@suse.de
Cc: Libin Yang <libin.yang@linux.intel.com>
Subject: Re: [PATCH] drm/i915: set proper N/M in modeset
Date: Tue, 02 Aug 2016 13:52:43 +0300	[thread overview]
Message-ID: <87oa5bsaro.fsf@intel.com> (raw)
In-Reply-To: <1470101710-57552-1-git-send-email-libin.yang@linux.intel.com>

On Tue, 02 Aug 2016, libin.yang@linux.intel.com wrote:
> From: Libin Yang <libin.yang@linux.intel.com>
>
> When modeset occurs and the LS_CLK is set to some
> special values in DP mode, the N/M need to be set
> manually if audio is playing.
>
> The relationship of Maud and Naud is expressed in
> the following equation:
> Maud/Naud = 512 * fs / f_LS_Clk
>
> Please refer VESA DisplayPort Standard spec for details.
>
> Also, the patch applies
> commit 7e8275c2f2bb ("drm/i915: set proper N/CTS in modeset")
> to APL platform.

Whenever a commit message says "also", it makes me think the patch
should probably be split to several patches. And that is certainly true
here.


-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2016-08-02 10:52 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-02  1:35 [PATCH] drm/i915: set proper N/M in modeset libin.yang
2016-08-02  5:30 ` ✗ Ro.CI.BAT: failure for drm/i915: set proper N/M in modeset (rev2) Patchwork
2016-08-02 10:47 ` [PATCH] drm/i915: set proper N/M in modeset Ville Syrjälä
2016-08-02 13:58   ` Yang, Libin
2016-08-02 16:59     ` Ville Syrjälä
2016-08-04  5:46       ` Yang, Libin
2016-08-04  6:06         ` Ville Syrjälä
2016-08-04  6:12           ` Yang, Libin
2016-08-04  2:48     ` Yang, Libin
2016-08-04  5:39       ` Ville Syrjälä
2016-08-04  6:04         ` Yang, Libin
2016-08-04  6:23           ` Ville Syrjälä
2016-08-04  6:31             ` Yang, Libin
2016-08-04  6:36               ` Ville Syrjälä
2016-08-02 10:52 ` Jani Nikula [this message]
2016-08-02 14:00   ` Yang, Libin
2016-08-04  6:29 ` ✗ Ro.CI.BAT: failure for drm/i915: set proper N/M in modeset (rev3) Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2016-07-14  7:06 [PATCH] drm/i915: set proper N/M in modeset libin.yang
2016-07-28  6:44 ` Yang, Libin
2016-07-28  7:41 ` Ville Syrjälä
2016-07-29  5:54   ` Yang, Libin
2016-07-29  9:47     ` Ville Syrjälä
2016-08-01  1:31       ` Yang, Libin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87oa5bsaro.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=daniel.vetter@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=libin.yang@linux.intel.com \
    --cc=tiwai@suse.de \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox