From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: Fix NULL pointer deference when out of PLLs in IVB Date: Mon, 23 May 2016 11:42:53 +0300 Message-ID: <87oa7xdv1u.fsf@intel.com> References: <1463748426-5956-1-git-send-email-ander.conselvan.de.oliveira@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 3B8926E497 for ; Mon, 23 May 2016 08:42:56 +0000 (UTC) In-Reply-To: <1463748426-5956-1-git-send-email-ander.conselvan.de.oliveira@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org Cc: Ander Conselvan de Oliveira List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCAyMCBNYXkgMjAxNiwgQW5kZXIgQ29uc2VsdmFuIGRlIE9saXZlaXJhIDxhbmRlci5j b25zZWx2YW4uZGUub2xpdmVpcmFAaW50ZWwuY29tPiB3cm90ZToKPiBJbiBjb21taXQgZjk0NzZh NmM2ZDBjICgiZHJtL2k5MTU6IFJlZmFjdG9yIHBsYXRmb3JtIHNwZWNpZmljcyBvdXQgb2YKPiBp bnRlbF9nZXRfc2hhcmVkX2RwbGwoKSIpLCB0aGUgaWJ4X2dldF9kcGxsKCkgZnVuY3Rpb24gbGFj a2VkIGFuIGVycm9yCj4gY2hlY2ssIHRoYXQgY2FuIGxlYWQgdG8gYSBOVUxMIHBvaW50ZXIgZGVy ZWZlcmVuY2Ugd2hlbiB0cnlpbmcgdG8gZW5hYmxlCj4gcGlwZSBDLgo+Cj4gQlVHOiB1bmFibGUg dG8gaGFuZGxlIGtlcm5lbCBOVUxMIHBvaW50ZXIgZGVyZWZlcmVuY2UgYXQgMDAwMDAwMDAwMDAw MDA2OAo+IElQOiBbPGZmZmZmZmZmYTA0ODIyNzU+XSBpbnRlbF9yZWZlcmVuY2Vfc2hhcmVkX2Rw bGwrMHgxNS8weDEwMCBbaTkxNV0KPiBQR0QgY2VjODcwNjcgUFVEIGQzMGNlMDY3IFBNRCAwCj4g T29wczogMDAwMCBbIzFdIFBSRUVNUFQgU01QCj4gTW9kdWxlcyBsaW5rZWQgaW46IHNuZF9oZGFf aW50ZWwgaTkxNSBkcm1fa21zX2hlbHBlciBkcm0gaW50ZWxfZ3R0IHNjaF9mcV9jb2RlbCBjZmc4 MDIxMSBiaW5mbXRfbWlzYyBpMmNfYWxnb19iaXQgY2ZiZmlsbHJlY3Qgc3lzY29weWFyZWEgY2Zi aW1nYmx0IHN5c2ZpbGxyZWN0IHN5c2ltZ2JsdCBmYl9zeXNfZm9wcyBjZmJjb3B5YXJlYSBpbnRl bF9yYXBsIGlvc2ZfbWJpIHg4Nl9wa2dfdGVtcF90aGVybWFsIGNvcmV0ZW1wIGFncGdhcnQga3Zt X2ludGVsIHNuZF9oZGFfY29kZWNfaGRtaSBrdm0gaVRDT193ZHQgc25kX2hkYV9jb2RlY19yZWFs dGVrIHNuZF9oZGFfY29kZWNfZ2VuZXJpYyBpcnFieXBhc3MgYWVzbmlfaW50ZWwgYWVzX3g4Nl82 NCBnbHVlX2hlbHBlciBscncgZ2YxMjhtdWwgYWJsa19oZWxwZXIgY3J5cHRkIHBzbW91c2UgcGNz cGtyIHNuZF9oZGFfY29kZWMgaTJjX2k4MDEgc25kX2h3ZGVwIHNuZF9oZGFfY29yZSBzbmRfcGNt IHNuZF90aW1lciBscGNfaWNoIG1mZF9jb3JlIHNuZCBzb3VuZGNvcmUgd21pIGV2ZGV2IHRwbV90 aXMgdHBtIFtsYXN0IHVubG9hZGVkOiBkcm1dCj4gQ1BVOiAzIFBJRDogNTgxMCBDb21tOiBrbXNf ZmxpcCBUYWludGVkOiBHICAgICBVICBXICAgICAgIDQuNi4wLXRlc3QrICMzCj4gSGFyZHdhcmUg bmFtZTogICAgICAgICAgICAgICAgICAvRFo3N0JILTU1SywgQklPUyBCSFo3NzEwSC44NkEuMDEw MC4yMDEzLjA1MTcuMDk0MiAwNS8xNy8yMDEzCj4gdGFzazogZmZmZjg4MDBkMzkwODA0MCB0aTog ZmZmZjg4MDExNjZjODAwMCB0YXNrLnRpOiBmZmZmODgwMTE2NmM4MDAwCj4gUklQOiAwMDEwOls8 ZmZmZmZmZmZhMDQ4MjI3NT5dICBbPGZmZmZmZmZmYTA0ODIyNzU+XSBpbnRlbF9yZWZlcmVuY2Vf c2hhcmVkX2RwbGwrMHgxNS8weDEwMCBbaTkxNV0KPiBSU1A6IDAwMTg6ZmZmZjg4MDExNjZjYmE2 MCAgRUZMQUdTOiAwMDAxMDI0Ngo+IFJBWDogMDAwMDAwMDAwMDAwMDAwMCBSQlg6IDAwMDAwMDAw MDAwMDAwMDAgUkNYOiAwMDAwMDAwMDAwMDAwMDAyCj4gUkRYOiAwMDAwMDAwMDAwMDAwMDAxIFJT STogZmZmZjg4MDBkMDdmMWJmOCBSREk6IDAwMDAwMDAwMDAwMDAwMDAKPiBSQlA6IGZmZmY4ODAx MTY2Y2JhODggUjA4OiAwMDAwMDAwMDAwMDAwMDAyIFIwOTogZmZmZjg4MDBkMzJlNTY5OAo+IFIx MDogMDAwMDAwMDAwMDAwMDAwMSBSMTE6IGZmZmY4ODAwY2M4OWFjODggUjEyOiBmZmZmODgwMGQw N2YxYmY4Cj4gUjEzOiAwMDAwMDAwMDAwMDAwMDAwIFIxNDogMDAwMDAwMDAwMDAwMDAwMCBSMTU6 IDAwMDAwMDAwMDAwMDAwMDAKPiBGUzogIDAwMDA3ZjRjM2ZjOGQ4YzAoMDAwMCkgR1M6ZmZmZjg4 MDExYmNjMDAwMCgwMDAwKSBrbmxHUzowMDAwMDAwMDAwMDAwMDAwCj4gQ1M6ICAwMDEwIERTOiAw MDAwIEVTOiAwMDAwIENSMDogMDAwMDAwMDA4MDA1MDAzMwo+IENSMjogMDAwMDAwMDAwMDAwMDA2 OCBDUjM6IDAwMDAwMDAwZDNiNGMwMDAgQ1I0OiAwMDAwMDAwMDAwMTQwNmUwCj4gU3RhY2s6Cj4g IDAwMDAwMDAwMDAwMDAwMDAgZmZmZjg4MDBkMDdmMWJmOCAwMDAwMDAwMDAwMDAwMDAwIGZmZmY4 ODAwZDA0YzAwMDAKPiAgMDAwMDAwMDAwMDAwMDAwMCBmZmZmODgwMTE2NmNiYWE4IGZmZmZmZmZm YTA0ODIzYTcgZmZmZjg4MDBkMDdmMWJmOAo+ICBmZmZmODgwMGQzMmU1Njk4IGZmZmY4ODAxMTY2 Y2JhYjggZmZmZmZmZmZhMDQ4NDBjZiBmZmZmODgwMTE2NmNiYWYwCj4gQ2FsbCBUcmFjZToKPiAg WzxmZmZmZmZmZmEwNDgyM2E3Pl0gaWJ4X2dldF9kcGxsKzB4NDcvMHhhMCBbaTkxNV0KPiAgWzxm ZmZmZmZmZmEwNDg0MGNmPl0gaW50ZWxfZ2V0X3NoYXJlZF9kcGxsKzB4MWYvMHg1MCBbaTkxNV0K PiAgWzxmZmZmZmZmZmEwNDZkMDgwPl0gaXJvbmxha2VfY3J0Y19jb21wdXRlX2Nsb2NrKzB4Mjgw LzB4NDMwIFtpOTE1XQo+ICBbPGZmZmZmZmZmYTA0NzJhYzA+XSBpbnRlbF9jcnRjX2F0b21pY19j aGVjaysweDI0MC8weDMyMCBbaTkxNV0KPiAgWzxmZmZmZmZmZmEwM2RhMThlPl0gZHJtX2F0b21p Y19oZWxwZXJfY2hlY2tfcGxhbmVzKzB4MTRlLzB4MWQwIFtkcm1fa21zX2hlbHBlcl0KPiAgWzxm ZmZmZmZmZmEwNDc0YTBjPl0gaW50ZWxfYXRvbWljX2NoZWNrKzB4NWRjLzB4MTExMCBbaTkxNV0K PiAgWzxmZmZmZmZmZmEwMjlkM2FhPl0gZHJtX2F0b21pY19jaGVja19vbmx5KzB4MTRhLzB4NjYw IFtkcm1dCj4gIFs8ZmZmZmZmZmZhMDI5ZDA4Nj5dID8gZHJtX2F0b21pY19zZXRfY3J0Y19mb3Jf Y29ubmVjdG9yKzB4OTYvMHgxMDAgW2RybV0KPiAgWzxmZmZmZmZmZmEwMjlkOGQ3Pl0gZHJtX2F0 b21pY19jb21taXQrMHgxNy8weDYwIFtkcm1dCj4gIFs8ZmZmZmZmZmZhMDNkYzNiNz5dIHJlc3Rv cmVfZmJkZXZfbW9kZSsweDIzNy8weDI2MCBbZHJtX2ttc19oZWxwZXJdCj4gIFs8ZmZmZmZmZmZh MDI5YzY1YT5dID8gZHJtX21vZGVzZXRfbG9ja19hbGxfY3R4KzB4OWEvMHhiMCBbZHJtXQo+ICBb PGZmZmZmZmZmYTAzZGU5YjM+XSBkcm1fZmJfaGVscGVyX3Jlc3RvcmVfZmJkZXZfbW9kZV91bmxv Y2tlZCsweDMzLzB4ODAgW2RybV9rbXNfaGVscGVyXQo+ICBbPGZmZmZmZmZmYTAzZGVhMmQ+XSBk cm1fZmJfaGVscGVyX3NldF9wYXIrMHgyZC8weDUwIFtkcm1fa21zX2hlbHBlcl0KPiAgWzxmZmZm ZmZmZmEwM2RlOTNhPl0gZHJtX2ZiX2hlbHBlcl9ob3RwbHVnX2V2ZW50KzB4YWEvMHhmMCBbZHJt X2ttc19oZWxwZXJdCj4gIFs8ZmZmZmZmZmZhMDNkZTlkNj5dIGRybV9mYl9oZWxwZXJfcmVzdG9y ZV9mYmRldl9tb2RlX3VubG9ja2VkKzB4NTYvMHg4MCBbZHJtX2ttc19oZWxwZXJdCj4gIFs8ZmZm ZmZmZmZhMDQ5MGY3Mj5dIGludGVsX2ZiZGV2X3Jlc3RvcmVfbW9kZSsweDIyLzB4ODAgW2k5MTVd Cj4gIFs8ZmZmZmZmZmZhMDRiYTQ1ZT5dIGk5MTVfZHJpdmVyX2xhc3RjbG9zZSsweGUvMHgyMCBb aTkxNV0KPiAgWzxmZmZmZmZmZmEwMjgxMGRlPl0gZHJtX2xhc3RjbG9zZSsweDJlLzB4MTMwIFtk cm1dCj4gIFs8ZmZmZmZmZmZhMDI4MTQ4Yz5dIGRybV9yZWxlYXNlKzB4MmFjLzB4NGIwIFtkcm1d Cj4gIFs8ZmZmZmZmZmY4MTFhNmIyZD5dIF9fZnB1dCsweGVkLzB4MWYwCj4gIFs8ZmZmZmZmZmY4 MTFhNmM2ZT5dIF9fX19mcHV0KzB4ZS8weDEwCj4gIFs8ZmZmZmZmZmY4MTA3OTE1Nj5dIHRhc2tf d29ya19ydW4rMHg3Ni8weGIwCj4gIFs8ZmZmZmZmZmY4MTA1YWFhYj5dIGRvX2V4aXQrMHgzYWIv MHhjNjAKPiAgWzxmZmZmZmZmZjgxMGExNDVmPl0gPyB0cmFjZV9oYXJkaXJxc19vbl9jYWxsZXIr MHgxMmYvMHgxYzAKPiAgWzxmZmZmZmZmZjgxMDVjNjdlPl0gZG9fZ3JvdXBfZXhpdCsweDRlLzB4 YzAKPiAgWzxmZmZmZmZmZjgxMDVjNzA0Pl0gU3lTX2V4aXRfZ3JvdXArMHgxNC8weDIwCj4gIFs8 ZmZmZmZmZmY4MTU4YmIyNT5dIGVudHJ5X1NZU0NBTExfNjRfZmFzdHBhdGgrMHgxOC8weGE4Cj4g Q29kZTogMTQgODAgNDggOGQgMzQgOTAgYjggMDEgMDAgMDAgMDAgZDMgZTAgMDkgMDQgYjMgNWIg NDEgNWMgNWQgYzMgOTAgMGYgMWYgNDQgMDAgMDAgNTUgNDggODkgZTUgNDEgNTcgNDEgNTYgNDkg ODkgZmUgNDEgNTUgNDEgNTQgNTMgPDQ0PiA4YiA2NyA2OCA0OCA4OSBmMyA0OCA4YiBiZSAwOCAw MiAwMCAwMCA0YyA4YiAyZSBlOCAxNSA5ZCBmZAo+IFJJUCAgWzxmZmZmZmZmZmEwNDgyMjc1Pl0g aW50ZWxfcmVmZXJlbmNlX3NoYXJlZF9kcGxsKzB4MTUvMHgxMDAgW2k5MTVdCj4gIFJTUCA8ZmZm Zjg4MDExNjZjYmE2MD4KPiBDUjI6IDAwMDAwMDAwMDAwMDAwNjgKPgo+IENjOiBWaWxsZSBTeXJq w6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IFJlcG9ydGVkLWJ5OiBWaWxs ZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IEZpeGVzOiBmOTQ3 NmE2YzZkMGMgKCJkcm0vaTkxNTogUmVmYWN0b3IgcGxhdGZvcm0gc3BlY2lmaWNzIG91dCBvZiBp bnRlbF9nZXRfc2hhcmVkX2RwbGwoKSIpCgpUaGUgc2NyaXB0cyBhcmUgZGltLCBhbmQgZG9uJ3Qg eWV0IGhhbmRsZSBhIGxvbmUgRml4ZXM6IGxpbmUuIFBsZWFzZQphbHNvIGFkZCB0aGUgcmVsZXZh bnQgQ2MuIEluIHRoaXMgY2FzZSwKCiQgZGltIGZpeGVzIGY5NDc2YTZjNmQwYwpGaXhlczogZjk0 NzZhNmM2ZDBjICgiZHJtL2k5MTU6IFJlZmFjdG9yIHBsYXRmb3JtIHNwZWNpZmljcyBvdXQgb2Yg aW50ZWxfZ2V0X3NoYXJlZF9kcGxsKCkiKQpDYzogZHJtLWludGVsLWZpeGVzQGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwoKPiBTaWduZWQtb2ZmLWJ5OiBBbmRlciBDb25zZWx2YW4gZGUgT2xpdmVpcmEg PGFuZGVyLmNvbnNlbHZhbi5kZS5vbGl2ZWlyYUBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmMgfCAzICsrKwo+ICAxIGZpbGUgY2hhbmdlZCwg MyBpbnNlcnRpb25zKCspCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZHBsbF9tZ3IuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmMKPiBp bmRleCBmOTg4YWRiLi4xZTNkMDkxIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2RwbGxfbWdyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxs X21nci5jCj4gQEAgLTM2Niw2ICszNjYsOSBAQCBpYnhfZ2V0X2RwbGwoc3RydWN0IGludGVsX2Ny dGMgKmNydGMsIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlLAo+ICAJCQkJCSAg ICAgRFBMTF9JRF9QQ0hfUExMX0IpOwo+ICAJfQo+ICAKPiArCWlmICghcGxsKQo+ICsJCXJldHVy biBOVUxMOwo+ICsKPiAgCS8qIHJlZmVyZW5jZSB0aGUgcGxsICovCj4gIAlpbnRlbF9yZWZlcmVu Y2Vfc2hhcmVkX2RwbGwocGxsLCBjcnRjX3N0YXRlKTsKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwg T3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vaW50ZWwtZ2Z4Cg==