From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH RESEND 1/2] drm/i915: make device info bitfield flags bools Date: Mon, 16 May 2016 18:24:36 +0300 Message-ID: <87oa86do0b.fsf@intel.com> References: <1463148278-23193-1-git-send-email-jani.nikula@intel.com> <5735E3C1.9080704@linux.intel.com> <20160513143313.GP23271@nuc-i3427.alporthouse.com> <87d1oqf21a.fsf@intel.com> <5735ED4D.50505@linux.intel.com> <5739A507.5040503@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTP id 0D9BD6E27E for ; Mon, 16 May 2016 15:24:38 +0000 (UTC) In-Reply-To: <5739A507.5040503@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Gordon , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAxNiBNYXkgMjAxNiwgRGF2ZSBHb3Jkb24gPGRhdmlkLnMuZ29yZG9uQGludGVsLmNv bT4gd3JvdGU6Cj4gT24gMTMvMDUvMTYgMTY6MDUsIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+Pgo+ PiBPbiAxMy8wNS8xNiAxNTo0NywgSmFuaSBOaWt1bGEgd3JvdGU6Cj4+PiBPbiBGcmksIDEzIE1h eSAyMDE2LCBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4gd3JvdGU6Cj4+ Pj4gT24gRnJpLCBNYXkgMTMsIDIwMTYgYXQgMDM6MjU6MDVQTSArMDEwMCwgVHZydGtvIFVyc3Vs aW4gd3JvdGU6Cj4+Pj4+Cj4+Pj4+IE9uIDEzLzA1LzE2IDE1OjA0LCBKYW5pIE5pa3VsYSB3cm90 ZToKPj4+Pj4+IFRoaXMgaXMgbW9yZSByb2J1c3QgZm9yIGFzc2lnbm1lbnRzIGFuZCBjb21wYXJp c29ucy4KPj4+Pj4+Cj4+Pj4+PiBTaWduZWQtb2ZmLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1 bGFAaW50ZWwuY29tPgo+Pj4+Pj4gLS0tCj4+Pj4+PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZHJ2LmggfCAyICstCj4+Pj4+PiAgIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwg MSBkZWxldGlvbigtKQo+Pj4+Pj4KPj4+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2Rydi5oCj4+Pj4+PiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgK Pj4+Pj4+IGluZGV4IGQ5ZDA3YjcwZjA1Yy4uYmIwYjZmNjQwMDBlIDEwMDY0NAo+Pj4+Pj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+Pj4+Pj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+Pj4+Pj4gQEAgLTc1Miw3ICs3NTIsNyBAQCBzdHJ1Y3Qg aW50ZWxfY3NyIHsKPj4+Pj4+ICAgICAgIGZ1bmMoaGFzX2RkaSkgc2VwIFwKPj4+Pj4+ICAgICAg IGZ1bmMoaGFzX2ZwZ2FfZGJnKQo+Pj4+Pj4KPj4+Pj4+IC0jZGVmaW5lIERFRklORV9GTEFHKG5h bWUpIHU4IG5hbWU6MQo+Pj4+Pj4gKyNkZWZpbmUgREVGSU5FX0ZMQUcobmFtZSkgYm9vbCBuYW1l OjEKPj4+Pj4+ICAgI2RlZmluZSBTRVBfU0VNSUNPTE9OIDsKPj4+Pj4+Cj4+Pj4+PiAgIHN0cnVj dCBpbnRlbF9kZXZpY2VfaW5mbyB7Cj4+Pj4+Pgo+Pj4+Pgo+Pj4+PiBUaGUgY2h1cm4gdmlydXMg c3ByZWFkcz8gOikKPj4+Pj4KPj4+Pj4gSSB0cmllZCB0aGF0IGJ1dCBpdCB3YXMgbmVnYXRpdmVs eSBpbXBhY3RpbmcgdGhlIGNvbXBpbGVyLiBGb3Igc29tZQo+Pj4+PiByZWFzb24gaXQgaW5jcmVh c2VzIC50ZXh0IGJ5IDIuNWsgaGVyZS4gRG9uJ3Qgc2VlIGFueXRoaW5nIG9idmlvdXMsCj4+Pj4+ IHdvdWxkIGhhdmUgdG8gbG9vayBhdCB0aGUgY29kZSBtb3JlIGNsb3NlbHkgdG8gc3BvdCBleGFj dGx5IHdoeS4KPj4+Pgo+Pj4+IE9oLCB0aGF0J3Mgbm90IGZ1bi4gYm9vbDoxIGhvbGRzIHN1Y2gg cHJvbWlzZSBmb3IgYSBjbGVhciBleHBsYW5hdGlvbiBvZgo+Pj4+IHRoZSBtb3N0IGNvbW1vbiBm b3JtIG9mIGJpdGZpZWxkLgo+Pj4KPj4+IFJlYWxseSBhIGJ1bW1lciwgZXNwZWNpYWxseSBzaW5j ZSBhc3NpZ25pbmcgYW55IHBvc2l0aXZlIGV2ZW4gbnVtYmVyIHRvCj4+PiB1bnNpZ25lZCBpbnQg Zm9vOjEgd2lsbCByZXN1bHQgaW4gMC4KPj4KPj4gVGhhdCBpcyBhIHByZXR0eSBzdHJvbmcgYXJn dW1lbnQgdG8gZ28gZm9yIHRoaXMgcmF0aGVyIHRoYW4gbWFrZSBzdXJlCj4+IGFsbCBwbGFjZXMg d2hpY2ggc2V0IHRoZW0gYXJlIGNvcnJlY3QuCj4+Cj4+IFJldmlld2VkLWJ5OiBUdnJ0a28gVXJz dWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+Pgo+PiBSZWdhcmRzLAo+PiBUdnJ0a28K Pgo+IFVuZm9ydHVuYXRlbHksIHRoZSBjb21waWxlciBkb2Vzbid0IGdlbmVyYXRlIHN1Y2ggZ29v ZCBjb2RlIHdoZW4gdXNpbmcgCj4gJ2Jvb2wnIHZzLiAndTgnIGZvciB0aGVzZSBiaXRmaWVsZHMu CgoKSSd2ZSBwdXNoZWQgcGF0Y2ggMi8yIHdoaWxlIHRoZSBqdXJ5IHNlZW1zIHRvIGJlIHN0aWxs IG91dCBmb3IgMS8yLgoKR2VuZXJhbGx5IHdlIG1pZ2h0IHByZWZlciBib29scyBhbnl3YXksIGJ1 dCB0aGlzIHN0cnVjdCBpcyBjb25zdCBpbgpkZXZfcHJpdiB3aXRoIHRoZSBpZGVhIHRoYXQgdGhp cyBpcyBpbW11dGFibGUgZGF0YSwgYW5kIHdlIG92ZXJyaWRlIHRoZQpjb25zdCBicmllZmx5IG9u IGRyaXZlciBsb2FkIGluIGludGVsX2RldmljZV9pbmZvX3J1bnRpbWVfaW5pdCgpLgoKQ2hlY2tp bmcgYWxsIHVzYWdlIGlzIG5vdCBhIGh1Z2UgZWZmb3J0LCBhbHRob3VnaCB3ZSBtaWdodCBzdGls bCBzY3Jldwp0aGlzIHVwIGxhdGVyIG9uLi4uCgpCUiwKSmFuaS4KCgo+Cj4gRmlyc3RseSwgaXQg bG9va3MgbGlrZSB0aGUgY29tcGlsZXIgRE9FU04nVCBjb21iaW5lIGJvb2wtYml0ZmllbGQgdGVz dHMgCj4gc3VjaCBhcyAiaWYgKElTX0EoKSB8fCBJU19CKCkpIiwgd2hlcmVhcyBpdCBkb2VzIGlm IHRoZXkncmUgdTguIEV4YW1wbGU6Cj4KPiBXaXRoIGJpdGZpZWxkcyBhcyAndTgnCj4KPiAJaWYg KElTX0hBU1dFTEwoZGV2KSB8fCBJU19CUk9BRFdFTEwoZGV2KSkKPiA0OCA4YiA1NyAyOCAgICAg ICAgICAJbW92ICAgIDB4MjgoJXJkaSksJXJkeAkjIGRldi0+ZGV2X3ByaXYKPiAwZiBiNiA1MiAz MCAgICAgICAgICAJbW92emJsIDB4MzAoJXJkeCksJWVkeAkjIGRldl9wcml2LT5mbGFnIGJ5dGUK PiBmNiBjMiA2MCAgICAgICAgICAgICAJdGVzdCAgICQweDYwLCVkbAkjIChoYXN3ZWxsfGJyb2Fk d2VsbCkKPiAwZiA4NSBiYiAwMCAwMCAwMCAgICAJam5lICAgIDEyZTQJCSMgYnJhbmNoIHRvIGlm LXRydWUKPgo+IAllbHNlIGlmIChJU19WQUxMRVlWSUVXKGRldikgfHwgSVNfQ0hFUlJZVklFVyhk ZXYpKQo+IDgzIGUyIDE4ICAgICAgICAgICAgIAlhbmQgICAgJDB4MTgsJWVkeAkjIHRlc3QgdHdv IG1vcmUgZmxhZ3MKPiAwZiA4NCAxYyAwMSAwMCAwMCAgICAJamUgICAgIDEzNGUJCSMgc2tpcCBp ZiBuZWl0aGVyCj4gICAgICAgICAgICAgICAgICAgICAgICAgIC4uLiBjb2RlIGZvciBWTFYvQ0hW IC4uLgo+IChjb2RlIGZvciBIU1cvQkRXIGlzIG91dC1vZi1saW5lLCBhdCB0aGUgZW5kIG9mIHRo ZSBmdW5jdGlvbikKPgo+IFdpdGggYml0ZmllbGRzIGFzIGJvb2xzOgo+Cj4gNDggOGIgNTcgMjgg ICAgICAgICAgCW1vdiAgICAweDI4KCVyZGkpLCVyZHgJIyBkZXYtPmRldl9wcml2Cj4gMGYgYjYg NTIgMzAgICAgICAgICAgCW1vdnpibCAweDMwKCVyZHgpLCVlZHgJIyBkZXZfcHJpdi0+ZmxhZyBi eXRlCj4gZjYgYzIgMjAgICAgICAgICAgICAgCXRlc3QgICAkMHgyMCwlZGwJIyB0ZXN0IG9uZSBm bGFnCj4gNzUgMDkgICAgICAgICAgICAgICAgCWpuZSAgICAxMjQxCQkjIGp1bXAgaWYgdHJ1ZQo+ IGY2IGMyIDQwICAgICAgICAgICAgIAl0ZXN0ICAgJDB4NDAsJWRsCSMgdGVzdCBvdGhlciBmbGFn Cj4gMGYgODQgYjcgMDAgMDAgMDAgICAgCWplICAgICAxMmY4CQkjIHNraXAgaWYgbm90Cj4gICAg ICAgICAgICAgICAgICAgICAgICAgIC4uLiBjb2RlIGZvciBIU1cvQkRXIC4uLgo+IChjb2RlIGZv ciBWTFYvQ0hWL290aGVyIGlzIGxhdGVyKQo+Cj4gU28gdGhhdCB3b3VsZCBzdWdnZXN0IHRoYXQg dGhlIGNvbXBpbGVyIGdlbmVyYXRlcyBtb3JlIGVmZmljaWVudCBjb2RlIAo+IGZvciAndTgnIChh dCBsZWFzdCBpdCBkaWRuJ3QgcmVsb2FkIHRoZSBmbGFnIGJ5dGUgZXZlbiBpbiB0aGUgJ2Jvb2wn IAo+IGNhc2UpLiBIZXJlJ3MgYW5vdGhlciBjYXNlOgo+Cj4gV2l0aCBiaXRmaWVsZHMgYXMgYm9v bHM6Cj4KPiAJZGV2X3ByaXYtPnBzcl9tbWlvX2Jhc2UgPSBJU19IQVNXRUxMKGRldl9wcml2KSA/ Cj4gCQlIU1dfRURQX1BTUl9CQVNFIDogQkRXX0VEUF9QU1JfQkFTRTsKPiAwZiBiNiA0MyAzMCAg ICAgICAgICAJbW92emJsIDB4MzAoJXJieCksJWVheAkjIGZsYWdzIGJ5dGUKPiBjMCBlOCAwNSAg ICAgICAgICAgICAJc2hyICAgICQweDUsJWFsCQkjIGhhc3dlbGwtPmJpdCAwCj4gODMgZTAgMDEg ICAgICAgICAgICAgCWFuZCAgICAkMHgxLCVlYXgJIyBsZWF2ZXMgYml0IDAgb25seQo+IDNjIDAx ICAgICAgICAgICAgICAgIAljbXAgICAgJDB4MSwlYWwJCSMgY29tcGFyZSB0byAxdQo+IDE5IGMw ICAgICAgICAgICAgICAgIAlzYmIgICAgJWVheCwlZWF4CSMgY29udmVydCB0byAwLy0xCj4gMjUg MDAgYjAgMDAgMDAgICAgICAgCWFuZCAgICAkMHhiMDAwLCVlYXgJIyBjb252ZXJ0IHRvIDAvYjAw MAo+IDA1IDAwIDQ4IDA2IDAwICAgICAgIAlhZGQgICAgJDB4NjQ4MDAsJWVheAkjIGZpbmFsIHJl c3VsdAo+IDg5IDgzIGU4IDIwIDAwIDAwICAgIAltb3YgICAgJWVheCwweDIwZTgoJXJieCkjIHN0 b3JlIGl0Cj4KPiBUaGlzIGlzIGluZ2VuaW91cyBjb2RlLCBhdm9pZGluZyBhbnkgYnJhbmNoaW5n LiBOb3cgd2l0aCAndTgnOgo+Cj4gMGYgYjYgNDMgMzAgICAgICAgICAgCW1vdnpibCAweDMwKCVy YngpLCVlYXgKPiA4MyBlMCAyMCAgICAgICAgICAgICAJYW5kICAgICQweDIwLCVlYXgJIyBsZWF2 ZXMgYml0IDUgb25seQo+IDNjIDAxICAgICAgICAgICAgICAgIAljbXAgICAgJDB4MSwlYWwJCSMg Y29tcGFyZSB0byAxdQo+IDE5IGMwICAgICAgICAgICAgICAgIAlzYmIgICAgJWVheCwlZWF4CSMg Y29udmVydCB0byAwLy0xCj4gMjUgMDAgYjAgMDAgMDAgICAgICAgCWFuZCAgICAkMHhiMDAwLCVl YXgJIyBldGMKPiAwNSAwMCA0OCAwNiAwMCAgICAgICAJYWRkICAgICQweDY0ODAwLCVlYXgKPiA4 OSA4MyBlOCAyMCAwMCAwMCAgICAJbW92ICAgICVlYXgsMHgyMGU4KCVyYngpCj4KPiBBZ2FpbiBp dCdzIHNob3J0ZXIsIGJlY2F1c2UgdGhlIGNvbXBpbGVyIGhhcyBiZWVuIGFibGUgdG8gZXh0cmFj dCBhIAo+IHRydXRoLXZhbHVlIHdpdGhvdXQgc2hpZnRpbmcgdGhlICJoYXN3ZWxsIiBiaXQgZG93 biB0byBiaXQgMCBmaXJzdC4KPgo+IC5EYXZlLgo+IF9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNv dXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZngK