From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 1/2] drm/i915: introduce for_each_engine(), rework for_each_ring() Date: Wed, 30 Dec 2015 10:54:35 +0200 Message-ID: <87oad8e2pg.fsf@intel.com> References: <1451415598-24056-1-git-send-email-david.s.gordon@intel.com> <20151229191814.GT31221@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id D58BF89EEB for ; Wed, 30 Dec 2015 00:55:00 -0800 (PST) In-Reply-To: <20151229191814.GT31221@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Dave Gordon Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAyOSBEZWMgMjAxNSwgQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28u dWs+IHdyb3RlOgo+IE9uIFR1ZSwgRGVjIDI5LCAyMDE1IGF0IDA2OjU5OjU3UE0gKzAwMDAsIERh dmUgR29yZG9uIHdyb3RlOgo+PiBJbiB0aGUgZGlzY3Vzc2lvbnMgYXJvdW5kIGNvbW1pdCAzNzM3 MDFiMSAoSmFuaSBOaWt1bGEpCj4+ICAgICBkcm06IGZpeCBwb3RlbnRpYWwgZGFuZ2xpbmcgZWxz ZSBwcm9ibGVtcyBpbiBmb3JfZWFjaF8gbWFjcm9zCj4+IERhbmllbCBWZXR0ZXIgbW9vdGVkIHRo ZSBpZGVhIG9mIGEgZm9yX2VhY2hfZW5naW5lKHJpbmcsIGRldl9wcml2KQo+PiBtYWNybyB0aGF0 IGRpZG4ndCB1c2Ugb3IgcmVseSBvbiBoYXZpbmcgYW4gaW50ZWdlciBpbmRleCB2YXJpYWJsZS4K Pj4gCj4+IFNvIGhlcmUgaXQgaXM7IGFuZCwgZm9yIGJhY2t3YXJkcyBjb21wYXRpYmlsaXR5LCBh biB1cGRhdGVkIHZlcnNpb24KPj4gb2YgZm9yX2VhY2hfcmluZygpIGltcGxlbWVudGVkIHVzaW5n IHRoZSBzYW1lIGludGVybmFscy4gQXMgYW4gZXhhbXBsZQo+PiBvZiB0aGUgdXNlIG9mIHRoaXMg bmV3IG1hY3JvLCB0aGUgZnVuY3Rpb25zIGluIGludGVsX3VuY29yZS5jIGhhdmUKPj4gYmVlbiBj b252ZXJ0ZWQgdG8gdXNlIGl0IGluIHByZWZlcmVuY2UgdG8gZm9yX2VhY2hfcmluZygpIHdoZXJl dmVyCj4+IHBvc3NpYmxlLiBBIHN1YnNlcXVlbnQgcGF0Y2ggd2lsbCBjb252ZXJ0IG1hbnkgb2Yg dGhlIHVzZXMgaW4gb3RoZXIKPj4gc291cmNlIGZpbGVzLgo+PiAKPj4gQ2M6IERhbmllbCBWZXR0 ZXIgPGRhbmllbEBmZndsbC5jaD4KPj4gQ2M6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRl bC5jb20+Cj4+IENjOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPj4g U2lnbmVkLW9mZi1ieTogRGF2ZSBHb3Jkb24gPGRhdmlkLnMuZ29yZG9uQGludGVsLmNvbT4KPj4g LS0tCj4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oICAgICB8IDMyICsrKysrKysr KysrKysrKysrKysrKysrKysrKystLS0tCj4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91 bmNvcmUuYyB8ICA1ICsrLS0tCj4+ICAyIGZpbGVzIGNoYW5nZWQsIDMwIGluc2VydGlvbnMoKyks IDcgZGVsZXRpb25zKC0pCj4+IAo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPj4gaW5kZXggY2Y3 ZTBmYy4uYTY0NTdlZSAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9k cnYuaAo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4+IEBAIC0xOTY4 LDEwICsxOTY4LDM0IEBAIHN0YXRpYyBpbmxpbmUgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmd1 Y190b19pOTE1KHN0cnVjdCBpbnRlbF9ndWMgKmd1YykKPj4gIAlyZXR1cm4gY29udGFpbmVyX29m KGd1Yywgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUsIGd1Yyk7Cj4+ICB9Cj4+ICAKPj4gLS8qIEl0 ZXJhdGUgb3ZlciBpbml0aWFsaXNlZCByaW5ncyAqLwo+PiAtI2RlZmluZSBmb3JfZWFjaF9yaW5n KHJpbmdfXywgZGV2X3ByaXZfXywgaV9fKSBcCj4+IC0JZm9yICgoaV9fKSA9IDA7IChpX18pIDwg STkxNV9OVU1fUklOR1M7IChpX18pKyspIFwKPj4gLQkJZm9yX2VhY2hfaWYgKCgoKHJpbmdfXykg PSAmKGRldl9wcml2X18pLT5yaW5nWyhpX18pXSksIGludGVsX3JpbmdfaW5pdGlhbGl6ZWQoKHJp bmdfXykpKSkKPj4gKy8qIEhlbHBlcnMgZm9yIHRoZSBmb3JfZWFjaF8qIG1hY3JvcyBiZWxvdyAq Lwo+PiArI2RlZmluZQlfX0lOSVRfRU5HSU5FX1BUUihlbmdpbmUsIGRldl9wcml2KQkJCQlcCj4+ ICsJKHsJCQkJCQkJCVwKPj4gKwkgCXN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVwID0gKGRldl9w cml2KS0+cmluZzsJCVwKPj4gKwkJKGVuZ2luZSkgPSAtLWVwOwkJCQkJXAo+PiArCX0pCj4+ICsj ZGVmaW5lCV9fTkVYVF9BQ1RJVkVfRU5HSU5FKGVuZ2luZSwgZGV2X3ByaXYsIG5yKQkJCVwKPj4g KwkoewkJCQkJCQkJXAo+PiArCQlzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmQgPSAmKGRldl9w cml2KS0+cmluZ1tucl07CVwKPj4gKwkJc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZXAgPSAoZW5n aW5lKTsJCQlcCj4+ICsJCWJvb2wgaW5fcmFuZ2U7CQkJCQkJXAo+PiArCQlkbyB7CQkJCQkJCVwK Pj4gKwkJCWluX3JhbmdlID0gKysoZXApIDwgZW5kOwkJCVwKPj4gKwkJfSB3aGlsZSAoaW5fcmFu Z2UgJiYgIWludGVsX3JpbmdfaW5pdGlhbGl6ZWQoZXApKTsJXAo+PiArCSAJKGVuZ2luZSkgPSBl cDsJCQkJCQlcCj4+ICsJCWluX3JhbmdlOwkJCQkJCVwKPj4gKwl9KQo+PiArCj4+ICsvKiBJdGVy YXRlIG92ZXIgaW5pdGlhbGlzZWQgZW5naW5lcyAqLwo+PiArI2RlZmluZSBmb3JfZWFjaF9lbmdp bmUoZW5naW5lLCBkZXZfcHJpdikJCQkJXAo+PiArCWZvciAoX19JTklUX0VOR0lORV9QVFIoZW5n aW5lLCBkZXZfcHJpdik7CQkJXAo+PiArCSAgICAgX19ORVhUX0FDVElWRV9FTkdJTkUoZW5naW5l LCBkZXZfcHJpdiwgSTkxNV9OVU1fUklOR1MpOyApCj4+ICsKPj4gKy8qIEJhY2t3YXJkcyBjb21w YXRpYmlsaXR5OiBpdGVyYXRlIG92ZXIgaW5pdGlhbGlzZWQgInJpbmdzIiAqLwo+PiArI2RlZmlu ZSBmb3JfZWFjaF9yaW5nKGVuZ2luZSwgZGV2X3ByaXYsIHJpbmdfaWQpCQkJXAo+PiArCWZvciAo X19JTklUX0VOR0lORV9QVFIoZW5naW5lLCBkZXZfcHJpdik7CQkJXAo+PiArCSAgICAgX19ORVhU X0FDVElWRV9FTkdJTkUoZW5naW5lLCBkZXZfcHJpdiwgSTkxNV9OVU1fUklOR1MpICYmCVwKPj4g KwkgICAgICgocmluZ19pZCkgPSAoZW5naW5lKS0+aWQsIHRydWUpOyApCj4KPiBObywgdGhhdCBp cyBoYXJkIHRvIHJlYWQgYW5kIGJsb2F0cyB0aGUga2VybmVsIGZvciBubyBiZW5lZml0LiBFdmVu IG1vcmUKPiBzbyBjb21wYXJlZCBhZ2FpbnN0IGp1c3QKCkNvbnNpZGVyaW5nIHRoYXQgSSBjb3Vs ZG4ndCBjb252aW5jZSBteXNlbGYgaW4gYSBmZXcgbWludXRlcyB0aGF0IHRoZQphYm92ZSBpcyBj b3JyZWN0LCBJJ20gd2l0aCBDaHJpcyBoZXJlLiBUaGUgYmVsb3cgaXMgbXVjaCBtb3JlIHJlYWRh YmxlLgoKQlIsCkphbmkuCgoKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+IGluZGV4IDU3OGY5 NTRkYmExZC4uNzM5NTY5NDU4YmI3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZHJ2LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gQEAg LTE5NjcsOCArMTk2Nyw4IEBAIHN0YXRpYyBpbmxpbmUgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg Kmd1Y190b19pOTE1KHN0cnVjdCBpbnRlbF9ndWMgKmd1YykKPiAgCj4gIC8qIEl0ZXJhdGUgb3Zl ciBpbml0aWFsaXNlZCByaW5ncyAqLwo+ICAjZGVmaW5lIGZvcl9lYWNoX3JpbmcocmluZ19fLCBk ZXZfcHJpdl9fLCBpX18pIFwKPiAtICAgICAgIGZvciAoKGlfXykgPSAwOyAoaV9fKSA8IEk5MTVf TlVNX1JJTkdTOyAoaV9fKSsrKSBcCj4gLSAgICAgICAgICAgICAgIGZvcl9lYWNoX2lmICgoKChy aW5nX18pID0gJihkZXZfcHJpdl9fKS0+cmluZ1soaV9fKV0pLCBpbnRlbF9lbmdpbmVfaW5pdGlh bGl6ZWQoKHJpbmdfXykpKSkKPiArICAgICAgIGZvciAoKHJpbmdfXykgPSAmKGRldl9wcml2X18p LT5yaW5nWzBdOyAocmluZ19fKSA8ICYoZGV2X3ByaXZfXyktPnJpbmdbSTkxNV9OVU1fUklOR1Nd OyAocmluZ19fKSsrKSBcCj4gKyAgICAgICAgICAgICAgIGZvcl9lYWNoX2lmIChpbnRlbF9lbmdp bmVfaW5pdGlhbGl6ZWQoKHJpbmdfXykpKQo+ICAKPiAgZW51bSBoZG1pX2ZvcmNlX2F1ZGlvIHsK PiAgICAgICAgIEhETUlfQVVESU9fT0ZGX0RWSSA9IC0yLCAgICAgICAgLyogbm8gYXV4IGRhdGEg Zm9yIEhETUktRFZJIGNvbnZlcnRlciAqLwo+Cj4gKHdoaWNoIGlzIGEgbmV0IHdpbiBvdmVyIHRo ZSBjdXJyZW50IGNvZGUsIHByZXN1bWFibHkgc29sZWx5IGR1ZSB0bwo+IGVsaW1pbmF0aW5nIGRl YWQgbG9jYWxzKQo+IC1DaHJpcwoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBU ZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeAo=