Re: [RFC PATCH 00/12] drm/i915: port dsi over to drm panel/dsi frameworks

[Jani Nikula <jani.nikula@intel.com>]

On Thu, 22 Jan 2015, Shobhit Kumar <shobhit.kumar@linux.intel.com> wrote:
> On 01/16/2015 05:57 PM, Jani Nikula wrote:
>> This series ports our DSI code over to the drm_panel and
>> mipi_dsi_host/mipi_dsi_device. There are some rough edges towards the
>> end of the series, see commit message for patch 8 for details.
>>
>> Patches 1-6 are prep work, fairly independent
>
> While I continue to review, quick test of patches show that till here it 
> is fine(with minor fix for Patch 2), but from Patch 7 on wards things 
> really don't work.

Okay, thanks for the review so far and trying it out.

What breaks down with patch 7? Which device are you trying this on?

BR,
Jani.


>
>>
>> Patch 7 ports the driver over to drm_panel
>>
>> Patches 8-10 port the driver over to mipi_dsi_host/device
>>
>> Patches 11-12 do some additional cleanup
>>
>> BR,
>> Jani.
>>
>>
>> Jani Nikula (12):
>>    drm/i915/dsi: call dpi_send_cmd() for each dsi port at a higher level
>>    drm/i915/dsi: set max return packet size for each dsi port
>>    drm/i915/dsi: move wait_for_dsi_fifo_empty to intel_dsi.c
>>    drm/i915/dsi: call wait_for_dsi_fifo_empty() for each dsi port
>>    drm/i915/dsi: remove unnecessary dsi device callbacks
>>    drm/i915/dsi: add some constness to vbt panel driver
>>    drm/i915/dsi: switch to drm_panel interface
>>    drm/i915/dsi: add drm mipi dsi host support
>>    drm/i915/dsi: make the vbt panel driver use mipi_dsi_device for
>>      transfers
>>    drm/i915/dsi: remove old read/write functions in favor of new stuff
>>    drm/i915/dsi: move dpi_send_cmd() to intel_dsi.c and make it static
>>    drm/i915/dsi: remove intel_dsi_cmd.c and the unused functions therein
>>
>>   drivers/gpu/drm/i915/Kconfig               |   2 +
>>   drivers/gpu/drm/i915/Makefile              |   1 -
>>   drivers/gpu/drm/i915/intel_dsi.c           | 336 +++++++++++++++++-----
>>   drivers/gpu/drm/i915/intel_dsi.h           |  69 ++---
>>   drivers/gpu/drm/i915/intel_dsi_cmd.c       | 432 -----------------------------
>>   drivers/gpu/drm/i915/intel_dsi_cmd.h       |  78 ------
>>   drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 289 ++++++++++---------
>>   7 files changed, 441 insertions(+), 766 deletions(-)
>>   delete mode 100644 drivers/gpu/drm/i915/intel_dsi_cmd.c
>>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx