From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH v4] drm/i915: Initialize workarounds in logical ring mode too Date: Tue, 11 Nov 2014 18:59:52 +0200 Message-ID: <87oasdhdvb.fsf@gaia.fi.intel.com> References: <1414516762-27254-1-git-send-email-arun.siluvery@linux.intel.com> <1415724453-21648-1-git-send-email-michel.thierry@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 021726E598 for ; Tue, 11 Nov 2014 09:00:01 -0800 (PST) In-Reply-To: <1415724453-21648-1-git-send-email-michel.thierry@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Michel Thierry , intel-gfx@lists.freedesktop.org Cc: Deepak S List-Id: intel-gfx@lists.freedesktop.org TWljaGVsIFRoaWVycnkgPG1pY2hlbC50aGllcnJ5QGludGVsLmNvbT4gd3JpdGVzOgoKPiBGb2xs b3dpbmcgdGhlIGxlZ2FjeSByaW5nIHN1Ym1pc3Npb24gZXhhbXBsZSwgdXBkYXRlIHRoZQo+IHJp bmctPmluaXRfY29udGV4dCgpIGhvb2sgdG8gc3VwcG9ydCB0aGUgZXhlY2xpc3Qgc3VibWlzc2lv biBtb2RlLgo+Cj4gdjI6IHVwZGF0ZSB0byB1c2UgdGhlIG5ldyB3b3JrYXJvdW5kIG1hY3JvcyBh bmQgY2xlYW51cCB1bnVzZWQgY29kZS4KPiBUaGlzIHRha2VzIGNhcmUgb2YgYm90aCBiZHcgYW5k IGNodiB3b3JrYXJvdW5kcy4KPgo+IHYyLjE6IEFkZCBtaXNzaW5nIGNhbGwgdG8gaW5pdF9jb250 ZXh0KCkgZHVyaW5nIGRlZmVycmVkIGNvbnRleHQgY3JlYXRpb24uCj4KPiB2MzogU3BsaXQgaW5p dF9jb250ZXh0IChlbWl0KSBpbiBsZWdhY3kvbHJjIG1vZGVzLiBGb3IgbHJjLCBnZXQgdGhlIHJp bmdidWYKPiBmcm9tIHRoZSBjb250ZXh0IChNaWthL0RhbmllbCkuCj4KPiB2NDogTWVyZ2UgaW5p dF9jb250ZXh0IGludGVyZmFjZXMgYmFjaywgdGhlIGxlZ2FjeSBtb2RlIG9ubHkgbmVlZHMgdGhl IHJpbmcsCj4gYnV0IHRoZSBscmMgbW9kZSBuZWVkcyB0aGUgcmluZyBhbmQgY29udGV4dCAoTWlr YSkuCj4KPiBJc3N1ZTogVklaLTQwOTIKPiBJc3N1ZTogR01JTi0zNDc1Cj4gQ2hhbmdlLUlkOiBJ ZTNkMDkzYjI1NDJhYjBlMmE0NGI5MDQ2MDUzM2UyZjk3OTc4OGQ2Ywo+IENjOiBEZWVwYWsgUyA8 ZGVlcGFrLnNAaW50ZWwuY29tPgo+IENjOiBNaWthIEt1b3BwYWxhIDxtaWthLmt1b3BwYWxhQGxp bnV4LmludGVsLmNvbT4KPiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPgo+IFNp Z25lZC1vZmYtYnk6IE1pY2hlbCBUaGllcnJ5IDxtaWNoZWwudGhpZXJyeUBpbnRlbC5jb20+Cj4g U2lnbmVkLW9mZi1ieTogQXJ1biBTaWx1dmVyeSA8YXJ1bi5zaWx1dmVyeUBsaW51eC5pbnRlbC5j b20+CgpSZXZpZXdlZC1ieTogTWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFsYUBpbnRlbC5jb20+ Cgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9jb250ZXh0LmMgfCAgMiAr LQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYyAgICAgICAgfCA0NyArKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKy0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf cmluZ2J1ZmZlci5jIHwgIDUgKystLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5n YnVmZmVyLmggfCAgNSArKystCj4gIDQgZmlsZXMgY2hhbmdlZCwgNTQgaW5zZXJ0aW9ucygrKSwg NSBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2dlbV9jb250ZXh0LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9jb250ZXh0LmMK PiBpbmRleCBjNGRhYzE5Li5kN2U3MjQ3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZ2VtX2NvbnRleHQuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf Z2VtX2NvbnRleHQuYwo+IEBAIC02NjMsNyArNjYzLDcgQEAgZG9uZToKPiAgCj4gIAlpZiAodW5p bml0aWFsaXplZCkgewo+ICAJCWlmIChyaW5nLT5pbml0X2NvbnRleHQpIHsKPiAtCQkJcmV0ID0g cmluZy0+aW5pdF9jb250ZXh0KHJpbmcpOwo+ICsJCQlyZXQgPSByaW5nLT5pbml0X2NvbnRleHQo cmluZywgdG8pOwo+ICAJCQlpZiAocmV0KQo+ICAJCQkJRFJNX0VSUk9SKCJyaW5nIGluaXQgY29u dGV4dDogJWRcbiIsIHJldCk7Cj4gIAkJfQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9scmMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gaW5k ZXggNzhjM2RmYy4uY2IzYmMxMSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9scmMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gQEAg LTEwNzIsNiArMTA3Miw0NCBAQCBpbnQgaW50ZWxfbG9naWNhbF9yaW5nX2JlZ2luKHN0cnVjdCBp bnRlbF9yaW5nYnVmZmVyICpyaW5nYnVmLCBpbnQgbnVtX2R3b3JkcykKPiAgCXJldHVybiAwOwo+ ICB9Cj4gIAo+ICtzdGF0aWMgaW50IGludGVsX2xvZ2ljYWxfcmluZ193b3JrYXJvdW5kc19lbWl0 KHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKnJpbmcsCj4gKwkgICAgICAgc3RydWN0IGludGVsX2Nv bnRleHQgKmN0eCkKPiArewo+ICsJaW50IHJldCwgaTsKPiArCXN0cnVjdCBpbnRlbF9yaW5nYnVm ZmVyICpyaW5nYnVmID0gY3R4LT5lbmdpbmVbcmluZy0+aWRdLnJpbmdidWY7Cj4gKwlzdHJ1Y3Qg ZHJtX2RldmljZSAqZGV2ID0gcmluZy0+ZGV2Owo+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiArCXN0cnVjdCBpOTE1X3dvcmthcm91bmRz ICp3ID0gJmRldl9wcml2LT53b3JrYXJvdW5kczsKPiArCj4gKwlpZiAoV0FSTl9PTih3LT5jb3Vu dCA9PSAwKSkKPiArCQlyZXR1cm4gMDsKPiArCj4gKwlyaW5nLT5ncHVfY2FjaGVzX2RpcnR5ID0g dHJ1ZTsKPiArCXJldCA9IGxvZ2ljYWxfcmluZ19mbHVzaF9hbGxfY2FjaGVzKHJpbmdidWYpOwo+ ICsJaWYgKHJldCkKPiArCQlyZXR1cm4gcmV0Owo+ICsKPiArCXJldCA9IGludGVsX2xvZ2ljYWxf cmluZ19iZWdpbihyaW5nYnVmLCB3LT5jb3VudCAqIDIgKyAyKTsKPiArCWlmIChyZXQpCj4gKwkJ cmV0dXJuIHJldDsKPiArCj4gKwlpbnRlbF9sb2dpY2FsX3JpbmdfZW1pdChyaW5nYnVmLCBNSV9M T0FEX1JFR0lTVEVSX0lNTSh3LT5jb3VudCkpOwo+ICsJZm9yIChpID0gMDsgaSA8IHctPmNvdW50 OyBpKyspIHsKPiArCQlpbnRlbF9sb2dpY2FsX3JpbmdfZW1pdChyaW5nYnVmLCB3LT5yZWdbaV0u YWRkcik7Cj4gKwkJaW50ZWxfbG9naWNhbF9yaW5nX2VtaXQocmluZ2J1Ziwgdy0+cmVnW2ldLnZh bHVlKTsKPiArCX0KPiArCWludGVsX2xvZ2ljYWxfcmluZ19lbWl0KHJpbmdidWYsIE1JX05PT1Ap Owo+ICsKPiArCWludGVsX2xvZ2ljYWxfcmluZ19hZHZhbmNlKHJpbmdidWYpOwo+ICsKPiArCXJp bmctPmdwdV9jYWNoZXNfZGlydHkgPSB0cnVlOwo+ICsJcmV0ID0gbG9naWNhbF9yaW5nX2ZsdXNo X2FsbF9jYWNoZXMocmluZ2J1Zik7Cj4gKwlpZiAocmV0KQo+ICsJCXJldHVybiByZXQ7Cj4gKwo+ ICsJcmV0dXJuIDA7Cj4gK30KPiArCj4gIHN0YXRpYyBpbnQgZ2VuOF9pbml0X2NvbW1vbl9yaW5n KHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKnJpbmcpCj4gIHsKPiAgCXN0cnVjdCBkcm1fZGV2aWNl ICpkZXYgPSByaW5nLT5kZXY7Cj4gQEAgLTExMTUsNyArMTE1Myw3IEBAIHN0YXRpYyBpbnQgZ2Vu OF9pbml0X3JlbmRlcl9yaW5nKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKnJpbmcpCj4gIAo+ICAJ STkxNV9XUklURShJTlNUUE0sIF9NQVNLRURfQklUX0VOQUJMRShJTlNUUE1fRk9SQ0VfT1JERVJJ TkcpKTsKPiAgCj4gLQlyZXR1cm4gcmV0Owo+ICsJcmV0dXJuIGluaXRfd29ya2Fyb3VuZHNfcmlu ZyhyaW5nKTsKPiAgfQo+ICAKPiAgc3RhdGljIGludCBnZW44X2VtaXRfYmJfc3RhcnQoc3RydWN0 IGludGVsX3JpbmdidWZmZXIgKnJpbmdidWYsCj4gQEAgLTEzNjYsNiArMTQwNCw3IEBAIHN0YXRp YyBpbnQgbG9naWNhbF9yZW5kZXJfcmluZ19pbml0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4g IAkJcmluZy0+aXJxX2tlZXBfbWFzayB8PSBHVF9SRU5ERVJfTDNfUEFSSVRZX0VSUk9SX0lOVEVS UlVQVDsKPiAgCj4gIAlyaW5nLT5pbml0ID0gZ2VuOF9pbml0X3JlbmRlcl9yaW5nOwo+ICsJcmlu Zy0+aW5pdF9jb250ZXh0ID0gaW50ZWxfbG9naWNhbF9yaW5nX3dvcmthcm91bmRzX2VtaXQ7Cj4g IAlyaW5nLT5jbGVhbnVwID0gaW50ZWxfZmluaV9waXBlX2NvbnRyb2w7Cj4gIAlyaW5nLT5nZXRf c2Vxbm8gPSBnZW44X2dldF9zZXFubzsKPiAgCXJpbmctPnNldF9zZXFubyA9IGdlbjhfc2V0X3Nl cW5vOwo+IEBAIC0xODcwLDYgKzE5MDksMTIgQEAgaW50IGludGVsX2xyX2NvbnRleHRfZGVmZXJy ZWRfY3JlYXRlKHN0cnVjdCBpbnRlbF9jb250ZXh0ICpjdHgsCj4gIAl9Cj4gIAo+ICAJaWYgKHJp bmctPmlkID09IFJDUyAmJiAhY3R4LT5yY3NfaW5pdGlhbGl6ZWQpIHsKPiArCQlpZiAocmluZy0+ aW5pdF9jb250ZXh0KSB7Cj4gKwkJCXJldCA9IHJpbmctPmluaXRfY29udGV4dChyaW5nLCBjdHgp Owo+ICsJCQlpZiAocmV0KQo+ICsJCQkJRFJNX0VSUk9SKCJyaW5nIGluaXQgY29udGV4dDogJWRc biIsIHJldCk7Cj4gKwkJfQo+ICsKPiAgCQlyZXQgPSBpbnRlbF9scl9jb250ZXh0X3JlbmRlcl9z dGF0ZV9pbml0KHJpbmcsIGN0eCk7Cj4gIAkJaWYgKHJldCkgewo+ICAJCQlEUk1fRVJST1IoIklu aXQgcmVuZGVyIHN0YXRlIGZhaWxlZDogJWRcbiIsIHJldCk7Cj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX3JpbmdidWZmZXIuYwo+IGluZGV4IDk4ZjI3ODcuLjllMTc0MzIgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jCj4gQEAgLTY3Nyw3ICs2NzcsOCBAQCBl cnI6Cj4gIAlyZXR1cm4gcmV0Owo+ICB9Cj4gIAo+IC1zdGF0aWMgaW50IGludGVsX3Jpbmdfd29y a2Fyb3VuZHNfZW1pdChzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpyaW5nKQo+ICtzdGF0aWMgaW50 IGludGVsX3Jpbmdfd29ya2Fyb3VuZHNfZW1pdChzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpyaW5n LAo+ICsJCXN0cnVjdCBpbnRlbF9jb250ZXh0ICpjdHgpCj4gIHsKPiAgCWludCByZXQsIGk7Cj4g IAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gcmluZy0+ZGV2Owo+IEBAIC04MTgsNyArODE5LDcg QEAgc3RhdGljIGludCBjaHZfaW5pdF93b3JrYXJvdW5kcyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2Nz ICpyaW5nKQo+ICAJcmV0dXJuIDA7Cj4gIH0KPiAgCj4gLXN0YXRpYyBpbnQgaW5pdF93b3JrYXJv dW5kc19yaW5nKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKnJpbmcpCj4gK2ludCBpbml0X3dvcmth cm91bmRzX3Jpbmcoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqcmluZykKPiAgewo+ICAJc3RydWN0 IGRybV9kZXZpY2UgKmRldiA9IHJpbmctPmRldjsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X3JpbmdidWZmZXIuaAo+IGluZGV4IGYwZTc3NjEuLjg2YzQ0NDcgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oCj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oCj4gQEAgLTE0OCw3ICsxNDgsOCBAQCBzdHJ1Y3Qg IGludGVsX2VuZ2luZV9jcyB7Cj4gIAo+ICAJaW50CQkoKmluaXQpKHN0cnVjdCBpbnRlbF9lbmdp bmVfY3MgKnJpbmcpOwo+ICAKPiAtCWludAkJKCppbml0X2NvbnRleHQpKHN0cnVjdCBpbnRlbF9l bmdpbmVfY3MgKnJpbmcpOwo+ICsJaW50CQkoKmluaXRfY29udGV4dCkoc3RydWN0IGludGVsX2Vu Z2luZV9jcyAqcmluZywKPiArCQkJCSAgICAgIHN0cnVjdCBpbnRlbF9jb250ZXh0ICpjdHgpOwo+ ICAKPiAgCXZvaWQJCSgqd3JpdGVfdGFpbCkoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqcmluZywK PiAgCQkJCSAgICAgIHUzMiB2YWx1ZSk7Cj4gQEAgLTQyOSw2ICs0MzAsOCBAQCBpbnQgaW50ZWxf aW5pdF92ZWJveF9yaW5nX2J1ZmZlcihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KTsKPiAgdTY0IGlu dGVsX3JpbmdfZ2V0X2FjdGl2ZV9oZWFkKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKnJpbmcpOwo+ ICB2b2lkIGludGVsX3Jpbmdfc2V0dXBfc3RhdHVzX3BhZ2Uoc3RydWN0IGludGVsX2VuZ2luZV9j cyAqcmluZyk7Cj4gIAo+ICtpbnQgaW5pdF93b3JrYXJvdW5kc19yaW5nKHN0cnVjdCBpbnRlbF9l bmdpbmVfY3MgKnJpbmcpOwo+ICsKPiAgc3RhdGljIGlubGluZSB1MzIgaW50ZWxfcmluZ19nZXRf dGFpbChzdHJ1Y3QgaW50ZWxfcmluZ2J1ZmZlciAqcmluZ2J1ZikKPiAgewo+ICAJcmV0dXJuIHJp bmdidWYtPnRhaWw7Cj4gLS0gCj4gMi4xLjEKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC1nZngK