Re: [PATCH 12/17] drm/i915: Don't kick the power seqeuncer just to check if we have vdd/panel power

Daniel Vetter
2014-10-28T08:07:15Z

On Tue, Oct 28, 2014 at 10:03:10AM +0200, Ville Syrjälä wrote:
> Oh that makes me think of another issue. What if someone has set
> disable_power_wells=0 and then suspends the machine? I think currently
> we'd end up leaving the power wells enabled which doesn't sound very
> nice, and also it would interfere with the pps_pipe reset handling.
> Should we have some kind of "force power wells off" step during suspend?

I don't think so. If at all we should probably taint the kernel if anyone
touches that option. dinq hasn't yet rolled forward to -rc1 yet so we
can't apply that patch yet.
-Daniel
>
> >
> > > return I915_READ(_pp_ctrl_reg(intel_dp)) & EDP_FORCE_VDD;
> > > }
> > >
>
> --
> Ville Syrjälä
> Intel OTC
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch