* [PATCH] drm/i915: BDW: Adding Reserved PCI IDs. @ 2014-06-10 17:09 Rodrigo Vivi 2014-06-11 0:17 ` Ben Widawsky 0 siblings, 1 reply; 7+ messages in thread From: Rodrigo Vivi @ 2014-06-10 17:09 UTC (permalink / raw) To: intel-gfx; +Cc: Rodrigo Vivi These PCI IDs are reserved on BSpec and can be used at any time in the future. So let's add this now in order to avoid issues that we already faced on previous platforms, like finding out about new ids when user reported accelaration weren't enabled. Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> --- include/drm/i915_pciids.h | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h index 0572035..a70d456 100644 --- a/include/drm/i915_pciids.h +++ b/include/drm/i915_pciids.h @@ -237,13 +237,21 @@ #define INTEL_BDW_GT3D_IDS(info) \ _INTEL_BDW_D_IDS(3, info) +#define INTEL_BDW_RSVDM_IDS(info) \ + _INTEL_BDW_M_IDS(4, info) + +#define INTEL_BDW_RSVDD_IDS(info) \ + _INTEL_BDW_D_IDS(4, info) + #define INTEL_BDW_M_IDS(info) \ INTEL_BDW_GT12M_IDS(info), \ - INTEL_BDW_GT3M_IDS(info) + INTEL_BDW_GT3M_IDS(info), \ + INTEL_BDW_RSVDM_IDS(info) #define INTEL_BDW_D_IDS(info) \ INTEL_BDW_GT12D_IDS(info), \ - INTEL_BDW_GT3D_IDS(info) + INTEL_BDW_GT3D_IDS(info), \ + INTEL_BDW_RSVDD_IDS(info) #define INTEL_CHV_IDS(info) \ INTEL_VGA_DEVICE(0x22b0, info), \ -- 1.9.3 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/i915: BDW: Adding Reserved PCI IDs. 2014-06-10 17:09 [PATCH] drm/i915: BDW: Adding Reserved PCI IDs Rodrigo Vivi @ 2014-06-11 0:17 ` Ben Widawsky 2014-06-10 17:41 ` Rodrigo Vivi 0 siblings, 1 reply; 7+ messages in thread From: Ben Widawsky @ 2014-06-11 0:17 UTC (permalink / raw) To: Rodrigo Vivi; +Cc: intel-gfx On Tue, Jun 10, 2014 at 10:09:52AM -0700, Rodrigo Vivi wrote: > These PCI IDs are reserved on BSpec and can be used at any time in the future. > So let's add this now in order to avoid issues that we already faced on previous > platforms, like finding out about new ids when user reported accelaration weren't > enabled. > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > --- > include/drm/i915_pciids.h | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h > index 0572035..a70d456 100644 > --- a/include/drm/i915_pciids.h > +++ b/include/drm/i915_pciids.h > @@ -237,13 +237,21 @@ > #define INTEL_BDW_GT3D_IDS(info) \ > _INTEL_BDW_D_IDS(3, info) > > +#define INTEL_BDW_RSVDM_IDS(info) \ > + _INTEL_BDW_M_IDS(4, info) > + > +#define INTEL_BDW_RSVDD_IDS(info) \ > + _INTEL_BDW_D_IDS(4, info) > + Assuming the IDs are ever used, the gt count should be right. 4 is invalid. Can you please use the correct GT value for the reserved IDs? I wouldn't bother creating a separate reserved structure since we already have the list. > #define INTEL_BDW_M_IDS(info) \ > INTEL_BDW_GT12M_IDS(info), \ > - INTEL_BDW_GT3M_IDS(info) > + INTEL_BDW_GT3M_IDS(info), \ > + INTEL_BDW_RSVDM_IDS(info) > > #define INTEL_BDW_D_IDS(info) \ > INTEL_BDW_GT12D_IDS(info), \ > - INTEL_BDW_GT3D_IDS(info) > + INTEL_BDW_GT3D_IDS(info), \ > + INTEL_BDW_RSVDD_IDS(info) > > #define INTEL_CHV_IDS(info) \ > INTEL_VGA_DEVICE(0x22b0, info), \ > -- > 1.9.3 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ben Widawsky, Intel Open Source Technology Center ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] drm/i915: BDW: Adding Reserved PCI IDs. 2014-06-11 0:17 ` Ben Widawsky @ 2014-06-10 17:41 ` Rodrigo Vivi 2014-06-11 17:47 ` Ben Widawsky 0 siblings, 1 reply; 7+ messages in thread From: Rodrigo Vivi @ 2014-06-10 17:41 UTC (permalink / raw) To: intel-gfx; +Cc: Ben Widawsky, Rodrigo Vivi These PCI IDs are reserved on BSpec and can be used at any time in the future. So let's add this now in order to avoid issues that we already faced on previous platforms, like finding out about new ids when user reported accelaration weren't enabled. v2: Reserved IDs doesn't have GT defined. So, creating a separated list. (Ben) Cc: Ben Widawsky <ben@bwidawsk.net> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> --- include/drm/i915_pciids.h | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h index 0572035..0968478 100644 --- a/include/drm/i915_pciids.h +++ b/include/drm/i915_pciids.h @@ -237,13 +237,25 @@ #define INTEL_BDW_GT3D_IDS(info) \ _INTEL_BDW_D_IDS(3, info) +#define INTEL_BDW_RSVDM_IDS(info) \ + INTEL_VGA_DEVICE(0x1632, info), \ + INTEL_VGA_DEVICE(0x1636, info), \ + INTEL_VGA_DEVICE(0x163B, info), \ + INTEL_VGA_DEVICE(0x163A, info) + +#define INTEL_BDW_RSVDD_IDS(info) \ + INTEL_VGA_DEVICE(0x163D, info), \ + INTEL_VGA_DEVICE(0x163E, info) + #define INTEL_BDW_M_IDS(info) \ INTEL_BDW_GT12M_IDS(info), \ - INTEL_BDW_GT3M_IDS(info) + INTEL_BDW_GT3M_IDS(info), \ + INTEL_BDW_RSVDM_IDS(info) #define INTEL_BDW_D_IDS(info) \ INTEL_BDW_GT12D_IDS(info), \ - INTEL_BDW_GT3D_IDS(info) + INTEL_BDW_GT3D_IDS(info), \ + INTEL_BDW_RSVDD_IDS(info) #define INTEL_CHV_IDS(info) \ INTEL_VGA_DEVICE(0x22b0, info), \ -- 1.9.3 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/i915: BDW: Adding Reserved PCI IDs. 2014-06-10 17:41 ` Rodrigo Vivi @ 2014-06-11 17:47 ` Ben Widawsky 2014-06-13 0:39 ` Rodrigo Vivi 0 siblings, 1 reply; 7+ messages in thread From: Ben Widawsky @ 2014-06-11 17:47 UTC (permalink / raw) To: Rodrigo Vivi; +Cc: intel-gfx On Tue, Jun 10, 2014 at 10:41:07AM -0700, Rodrigo Vivi wrote: > These PCI IDs are reserved on BSpec and can be used at any time in the future. > So let's add this now in order to avoid issues that we already faced on previous > platforms, like finding out about new ids when user reported accelaration weren't > enabled. > > v2: Reserved IDs doesn't have GT defined. So, creating a separated list. (Ben) > > Cc: Ben Widawsky <ben@bwidawsk.net> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > --- > include/drm/i915_pciids.h | 16 ++++++++++++++-- > 1 file changed, 14 insertions(+), 2 deletions(-) > > diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h > index 0572035..0968478 100644 > --- a/include/drm/i915_pciids.h > +++ b/include/drm/i915_pciids.h > @@ -237,13 +237,25 @@ > #define INTEL_BDW_GT3D_IDS(info) \ > _INTEL_BDW_D_IDS(3, info) > > +#define INTEL_BDW_RSVDM_IDS(info) \ > + INTEL_VGA_DEVICE(0x1632, info), \ > + INTEL_VGA_DEVICE(0x1636, info), \ > + INTEL_VGA_DEVICE(0x163B, info), \ > + INTEL_VGA_DEVICE(0x163A, info) > + > +#define INTEL_BDW_RSVDD_IDS(info) \ > + INTEL_VGA_DEVICE(0x163D, info), \ > + INTEL_VGA_DEVICE(0x163E, info) > + > #define INTEL_BDW_M_IDS(info) \ > INTEL_BDW_GT12M_IDS(info), \ > - INTEL_BDW_GT3M_IDS(info) > + INTEL_BDW_GT3M_IDS(info), \ > + INTEL_BDW_RSVDM_IDS(info) > > #define INTEL_BDW_D_IDS(info) \ > INTEL_BDW_GT12D_IDS(info), \ > - INTEL_BDW_GT3D_IDS(info) > + INTEL_BDW_GT3D_IDS(info), \ > + INTEL_BDW_RSVDD_IDS(info) > > #define INTEL_CHV_IDS(info) \ > INTEL_VGA_DEVICE(0x22b0, info), \ I thought we saved off the GT info, but now that I actually look at the code, we do not. Therefore, I actually think v1 is a better patch. In either case, both v1 and v2 are: Reviewed-by: Ben Widawsky <ben@bwidawsk.net> I apologize for the extra work. -- Ben Widawsky, Intel Open Source Technology Center ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/i915: BDW: Adding Reserved PCI IDs. 2014-06-11 17:47 ` Ben Widawsky @ 2014-06-13 0:39 ` Rodrigo Vivi 2014-06-24 13:19 ` Jani Nikula 0 siblings, 1 reply; 7+ messages in thread From: Rodrigo Vivi @ 2014-06-13 0:39 UTC (permalink / raw) To: Ben Widawsky; +Cc: intel-gfx, Rodrigo Vivi [-- Attachment #1.1: Type: text/plain, Size: 2505 bytes --] Hi Daniel, please consider to merge the first version. So we can move fwd with ddx patche followed by proper marketing names. Thanks, Rodrigo. On Wed, Jun 11, 2014 at 10:47 AM, Ben Widawsky <ben@bwidawsk.net> wrote: > On Tue, Jun 10, 2014 at 10:41:07AM -0700, Rodrigo Vivi wrote: > > These PCI IDs are reserved on BSpec and can be used at any time in the > future. > > So let's add this now in order to avoid issues that we already faced on > previous > > platforms, like finding out about new ids when user reported > accelaration weren't > > enabled. > > > > v2: Reserved IDs doesn't have GT defined. So, creating a separated list. > (Ben) > > > > Cc: Ben Widawsky <ben@bwidawsk.net> > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > > --- > > include/drm/i915_pciids.h | 16 ++++++++++++++-- > > 1 file changed, 14 insertions(+), 2 deletions(-) > > > > diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h > > index 0572035..0968478 100644 > > --- a/include/drm/i915_pciids.h > > +++ b/include/drm/i915_pciids.h > > @@ -237,13 +237,25 @@ > > #define INTEL_BDW_GT3D_IDS(info) \ > > _INTEL_BDW_D_IDS(3, info) > > > > +#define INTEL_BDW_RSVDM_IDS(info) \ > > + INTEL_VGA_DEVICE(0x1632, info), \ > > + INTEL_VGA_DEVICE(0x1636, info), \ > > + INTEL_VGA_DEVICE(0x163B, info), \ > > + INTEL_VGA_DEVICE(0x163A, info) > > + > > +#define INTEL_BDW_RSVDD_IDS(info) \ > > + INTEL_VGA_DEVICE(0x163D, info), \ > > + INTEL_VGA_DEVICE(0x163E, info) > > + > > #define INTEL_BDW_M_IDS(info) \ > > INTEL_BDW_GT12M_IDS(info), \ > > - INTEL_BDW_GT3M_IDS(info) > > + INTEL_BDW_GT3M_IDS(info), \ > > + INTEL_BDW_RSVDM_IDS(info) > > > > #define INTEL_BDW_D_IDS(info) \ > > INTEL_BDW_GT12D_IDS(info), \ > > - INTEL_BDW_GT3D_IDS(info) > > + INTEL_BDW_GT3D_IDS(info), \ > > + INTEL_BDW_RSVDD_IDS(info) > > > > #define INTEL_CHV_IDS(info) \ > > INTEL_VGA_DEVICE(0x22b0, info), \ > > I thought we saved off the GT info, but now that I actually look at the > code, we do not. Therefore, I actually think v1 is a better patch. > > In either case, both v1 and v2 are: > Reviewed-by: Ben Widawsky <ben@bwidawsk.net> > > I apologize for the extra work. > > -- > Ben Widawsky, Intel Open Source Technology Center > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx > -- Rodrigo Vivi Blog: http://blog.vivi.eng.br [-- Attachment #1.2: Type: text/html, Size: 3749 bytes --] [-- Attachment #2: Type: text/plain, Size: 159 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/i915: BDW: Adding Reserved PCI IDs. 2014-06-13 0:39 ` Rodrigo Vivi @ 2014-06-24 13:19 ` Jani Nikula 2014-06-24 15:32 ` Chris Wilson 0 siblings, 1 reply; 7+ messages in thread From: Jani Nikula @ 2014-06-24 13:19 UTC (permalink / raw) To: Rodrigo Vivi, Ben Widawsky; +Cc: intel-gfx, Rodrigo Vivi On Fri, 13 Jun 2014, Rodrigo Vivi <rodrigo.vivi@gmail.com> wrote: > Hi Daniel, > > please consider to merge the first version. So we can move fwd with ddx > patche followed by proper marketing names. Pushed v1 to -fixes, thanks for the patch and review. BR, Jani. > > Thanks, > Rodrigo. > > > On Wed, Jun 11, 2014 at 10:47 AM, Ben Widawsky <ben@bwidawsk.net> wrote: > >> On Tue, Jun 10, 2014 at 10:41:07AM -0700, Rodrigo Vivi wrote: >> > These PCI IDs are reserved on BSpec and can be used at any time in the >> future. >> > So let's add this now in order to avoid issues that we already faced on >> previous >> > platforms, like finding out about new ids when user reported >> accelaration weren't >> > enabled. >> > >> > v2: Reserved IDs doesn't have GT defined. So, creating a separated list. >> (Ben) >> > >> > Cc: Ben Widawsky <ben@bwidawsk.net> >> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> >> > --- >> > include/drm/i915_pciids.h | 16 ++++++++++++++-- >> > 1 file changed, 14 insertions(+), 2 deletions(-) >> > >> > diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h >> > index 0572035..0968478 100644 >> > --- a/include/drm/i915_pciids.h >> > +++ b/include/drm/i915_pciids.h >> > @@ -237,13 +237,25 @@ >> > #define INTEL_BDW_GT3D_IDS(info) \ >> > _INTEL_BDW_D_IDS(3, info) >> > >> > +#define INTEL_BDW_RSVDM_IDS(info) \ >> > + INTEL_VGA_DEVICE(0x1632, info), \ >> > + INTEL_VGA_DEVICE(0x1636, info), \ >> > + INTEL_VGA_DEVICE(0x163B, info), \ >> > + INTEL_VGA_DEVICE(0x163A, info) >> > + >> > +#define INTEL_BDW_RSVDD_IDS(info) \ >> > + INTEL_VGA_DEVICE(0x163D, info), \ >> > + INTEL_VGA_DEVICE(0x163E, info) >> > + >> > #define INTEL_BDW_M_IDS(info) \ >> > INTEL_BDW_GT12M_IDS(info), \ >> > - INTEL_BDW_GT3M_IDS(info) >> > + INTEL_BDW_GT3M_IDS(info), \ >> > + INTEL_BDW_RSVDM_IDS(info) >> > >> > #define INTEL_BDW_D_IDS(info) \ >> > INTEL_BDW_GT12D_IDS(info), \ >> > - INTEL_BDW_GT3D_IDS(info) >> > + INTEL_BDW_GT3D_IDS(info), \ >> > + INTEL_BDW_RSVDD_IDS(info) >> > >> > #define INTEL_CHV_IDS(info) \ >> > INTEL_VGA_DEVICE(0x22b0, info), \ >> >> I thought we saved off the GT info, but now that I actually look at the >> code, we do not. Therefore, I actually think v1 is a better patch. >> >> In either case, both v1 and v2 are: >> Reviewed-by: Ben Widawsky <ben@bwidawsk.net> >> >> I apologize for the extra work. >> >> -- >> Ben Widawsky, Intel Open Source Technology Center >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/intel-gfx >> > > > > -- > Rodrigo Vivi > Blog: http://blog.vivi.eng.br > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/i915: BDW: Adding Reserved PCI IDs. 2014-06-24 13:19 ` Jani Nikula @ 2014-06-24 15:32 ` Chris Wilson 0 siblings, 0 replies; 7+ messages in thread From: Chris Wilson @ 2014-06-24 15:32 UTC (permalink / raw) To: Jani Nikula; +Cc: Ben Widawsky, intel-gfx, Rodrigo Vivi On Tue, Jun 24, 2014 at 04:19:38PM +0300, Jani Nikula wrote: > On Fri, 13 Jun 2014, Rodrigo Vivi <rodrigo.vivi@gmail.com> wrote: > > Hi Daniel, > > > > please consider to merge the first version. So we can move fwd with ddx > > patche followed by proper marketing names. > > Pushed v1 to -fixes, thanks for the patch and review. Hey Rodrigo, I spotted another place we have identifier strings... In xf86-video-intel/README. :| -Chris -- Chris Wilson, Intel Open Source Technology Centre ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-06-24 15:32 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-06-10 17:09 [PATCH] drm/i915: BDW: Adding Reserved PCI IDs Rodrigo Vivi 2014-06-11 0:17 ` Ben Widawsky 2014-06-10 17:41 ` Rodrigo Vivi 2014-06-11 17:47 ` Ben Widawsky 2014-06-13 0:39 ` Rodrigo Vivi 2014-06-24 13:19 ` Jani Nikula 2014-06-24 15:32 ` Chris Wilson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox