From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 576DAC77B60 for ; Fri, 28 Apr 2023 22:05:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5475D10E0F5; Fri, 28 Apr 2023 22:05:33 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id BB36E10E0F5 for ; Fri, 28 Apr 2023 22:05:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682719531; x=1714255531; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=t/XwSz2zjbIPSI5iJgO+1Li4EjVwF9ZWu+uLZDuLEPE=; b=kyC+iacNQtvnmQwdyClvUwTyaOjgHMw1lUVcVp3H4p5NIfFSTumTwMhw L8VZv3TuAP80mejUr9k3fCkWETqfPmNJpLCGBIIlzUw0mNCo6O3zC6djV dDMXy9e/wyF3u9qUQJLO/i6KiUfPzBycGig0jxeb56AH4pWP1z5AOwgbv C0GM7RCH5lRniaB/VNDdrzmLJFUKGwl7TgP13KoFBq5BFpZXlBYE+sacj h0MW+tJFIeW9THoFBS/VccScaZjyQPIzDvnp8EY60YtRttXQF1pTJRc9e xzUvRUXH5rQG8rpIzmTrAE0jFcl+FFEYMs6hatersSQF/5m0+NX4xqeaY w==; X-IronPort-AV: E=McAfee;i="6600,9927,10694"; a="350787044" X-IronPort-AV: E=Sophos;i="5.99,235,1677571200"; d="scan'208";a="350787044" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2023 15:05:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10694"; a="819157767" X-IronPort-AV: E=Sophos;i="5.99,235,1677571200"; d="scan'208";a="819157767" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.28.106]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2023 15:05:30 -0700 Date: Fri, 28 Apr 2023 15:05:29 -0700 Message-ID: <87pm7n8xxy.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa In-Reply-To: <20230427224705.2785566-3-umesh.nerlige.ramappa@intel.com> References: <20230427224705.2785566-1-umesh.nerlige.ramappa@intel.com> <20230427224705.2785566-3-umesh.nerlige.ramappa@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/fdinfo: Enable fdinfo for GuC backends X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 27 Apr 2023 15:47:05 -0700, Umesh Nerlige Ramappa wrote: > > Enable fdinfo for GuC based platforms with the exception that long > running contexts will not provide reliable busyness data unless they > switch out at some reasonable point in time. > > Link: https://gitlab.freedesktop.org/drm/intel/issues/8303 > Signed-off-by: Umesh Nerlige Ramappa > --- > drivers/gpu/drm/i915/i915_drm_client.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_drm_client.c b/drivers/gpu/drm/i915/i915_drm_client.c > index e8fa172ebe5e..d18d0a3ed905 100644 > --- a/drivers/gpu/drm/i915/i915_drm_client.c > +++ b/drivers/gpu/drm/i915/i915_drm_client.c > @@ -147,11 +147,7 @@ void i915_drm_client_fdinfo(struct seq_file *m, struct file *f) > PCI_SLOT(pdev->devfn), PCI_FUNC(pdev->devfn)); > seq_printf(m, "drm-client-id:\t%u\n", client->id); > > - /* > - * Temporarily skip showing client engine information with GuC submission till > - * fetching engine busyness is implemented in the GuC submission backend > - */ > - if (GRAPHICS_VER(i915) < 8 || intel_uc_uses_guc_submission(&i915->gt0.uc)) > + if (GRAPHICS_VER(i915) < 8) > return; > > for (i = 0; i < ARRAY_SIZE(uabi_class_names); i++) Reviewed-by: Ashutosh Dixit