From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC49AC38142 for ; Tue, 24 Jan 2023 13:41:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 21D1F10E675; Tue, 24 Jan 2023 13:41:58 +0000 (UTC) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 18C5310E0D0; Tue, 24 Jan 2023 13:41:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674567715; x=1706103715; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=id9BiI2WE7yN2TbgreHQ7n9PbufSJ8AzzKrzesL8QYs=; b=LWkYT/k4bvhK9ga+FWIpmsaffFgb+3X1vqIXi3471jE3V6/aFwjjFBfv s7+Ks46f/btzKJONOJcFxkKvjXedUL4ZkaFdS92UHZ2I3WyLl0d8G8sjX T8s2DRM1OmjfOgLLXWFLsHwazWdnn7OKfq1zHHexvq0+w+yDSUTjJPyrJ f3HxFWasRvsg4xlxojlj3PPG/ndc0K2BT8PTO2zgURafqrCqm9hrtZVwi otc1CG/TzBHQCQFWlCAVv1VzQCy4DQ0+bH4AeKvlgMVp8aV/N2E8epVoa +cEh3QndBRd9WUKrt5TPhmkhKQTVod2QwuyJpZaUHgL+d2lUFwZRHD1Fh w==; X-IronPort-AV: E=McAfee;i="6500,9779,10599"; a="388640002" X-IronPort-AV: E=Sophos;i="5.97,242,1669104000"; d="scan'208";a="388640002" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2023 05:41:53 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10599"; a="612049061" X-IronPort-AV: E=Sophos;i="5.97,242,1669104000"; d="scan'208";a="612049061" Received: from pesir-mobl.ger.corp.intel.com (HELO localhost) ([10.252.57.197]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2023 05:41:49 -0800 From: Jani Nikula To: Dmitry Baryshkov , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter In-Reply-To: <20230124104548.3234554-1-dmitry.baryshkov@linaro.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20230124104548.3234554-1-dmitry.baryshkov@linaro.org> Date: Tue, 24 Jan 2023 15:41:46 +0200 Message-ID: <87pmb46odh.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Intel-gfx] [PATCH v3 1/2] drm/probe_helper: extract two helper functions X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , intel-gfx@lists.freedesktop.org, Chen-Yu Tsai , dri-devel@lists.freedesktop.org, Laurentiu Palcu , freedreno@lists.freedesktop.org, Marek Szyprowski Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 24 Jan 2023, Dmitry Baryshkov wrote: > Extract drm_kms_helper_enable_hpd() and drm_kms_helper_disable_hpd(), > two helpers that enable and disable HPD handling on all device's > connectors. Thanks for separating this, it makes the other patch easier to read. Reviewed-by: Jani Nikula > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/drm_probe_helper.c | 68 ++++++++++++++++++------------ > 1 file changed, 41 insertions(+), 27 deletions(-) > > diff --git a/drivers/gpu/drm/drm_probe_helper.c b/drivers/gpu/drm/drm_probe_helper.c > index 95aeeed33cf5..ab787d71fa66 100644 > --- a/drivers/gpu/drm/drm_probe_helper.c > +++ b/drivers/gpu/drm/drm_probe_helper.c > @@ -222,6 +222,45 @@ drm_connector_mode_valid(struct drm_connector *connector, > return ret; > } > > +static void drm_kms_helper_disable_hpd(struct drm_device *dev) > +{ > + struct drm_connector *connector; > + struct drm_connector_list_iter conn_iter; > + > + drm_connector_list_iter_begin(dev, &conn_iter); > + drm_for_each_connector_iter(connector, &conn_iter) { > + const struct drm_connector_helper_funcs *funcs = > + connector->helper_private; > + > + if (funcs && funcs->disable_hpd) > + funcs->disable_hpd(connector); > + } > + drm_connector_list_iter_end(&conn_iter); > +} > + > +static bool drm_kms_helper_enable_hpd(struct drm_device *dev) > +{ > + bool poll = false; > + struct drm_connector *connector; > + struct drm_connector_list_iter conn_iter; > + > + drm_connector_list_iter_begin(dev, &conn_iter); > + drm_for_each_connector_iter(connector, &conn_iter) { > + const struct drm_connector_helper_funcs *funcs = > + connector->helper_private; > + > + if (funcs && funcs->enable_hpd) > + funcs->enable_hpd(connector); > + > + if (connector->polled & (DRM_CONNECTOR_POLL_CONNECT | > + DRM_CONNECTOR_POLL_DISCONNECT)) > + poll = true; > + } > + drm_connector_list_iter_end(&conn_iter); > + > + return poll; > +} > + > #define DRM_OUTPUT_POLL_PERIOD (10*HZ) > /** > * drm_kms_helper_poll_enable - re-enable output polling. > @@ -241,26 +280,12 @@ drm_connector_mode_valid(struct drm_connector *connector, > void drm_kms_helper_poll_enable(struct drm_device *dev) > { > bool poll = false; > - struct drm_connector *connector; > - struct drm_connector_list_iter conn_iter; > unsigned long delay = DRM_OUTPUT_POLL_PERIOD; > > if (!dev->mode_config.poll_enabled || !drm_kms_helper_poll) > return; > > - drm_connector_list_iter_begin(dev, &conn_iter); > - drm_for_each_connector_iter(connector, &conn_iter) { > - const struct drm_connector_helper_funcs *funcs = > - connector->helper_private; > - > - if (funcs && funcs->enable_hpd) > - funcs->enable_hpd(connector); > - > - if (connector->polled & (DRM_CONNECTOR_POLL_CONNECT | > - DRM_CONNECTOR_POLL_DISCONNECT)) > - poll = true; > - } > - drm_connector_list_iter_end(&conn_iter); > + poll = drm_kms_helper_enable_hpd(dev); > > if (dev->mode_config.delayed_event) { > /* > @@ -810,24 +835,13 @@ EXPORT_SYMBOL(drm_kms_helper_is_poll_worker); > > static void drm_kms_helper_poll_disable_fini(struct drm_device *dev, bool fini) > { > - struct drm_connector *connector; > - struct drm_connector_list_iter conn_iter; > - > if (!dev->mode_config.poll_enabled) > return; > > if (fini) > dev->mode_config.poll_enabled = false; > > - drm_connector_list_iter_begin(dev, &conn_iter); > - drm_for_each_connector_iter(connector, &conn_iter) { > - const struct drm_connector_helper_funcs *funcs = > - connector->helper_private; > - > - if (funcs && funcs->disable_hpd) > - funcs->disable_hpd(connector); > - } > - drm_connector_list_iter_end(&conn_iter); > + drm_kms_helper_disable_hpd(dev); > > cancel_delayed_work_sync(&dev->mode_config.output_poll_work); > } -- Jani Nikula, Intel Open Source Graphics Center