From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13F11C4332F for ; Wed, 23 Nov 2022 09:18:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5443410E52C; Wed, 23 Nov 2022 09:18:11 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6085E10E52C for ; Wed, 23 Nov 2022 09:18:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669195088; x=1700731088; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=PoxnIa69ijQ4HTiCnANTpZhaMod2xL/9CeAOMVqLOgY=; b=YnvUHOFJsTe12/X31E+ptMGmtEAyxRPltH+++mXNYbaXOmlNicAsZTkM p7AHC725Gd+fVoKh1W3TYOpfRtNBCN3RNGFLLGYBpoFRXRp3xyuFIUeer Ottn5e/YROkgrN0GKrd4VZH1vMIgXYwporophuCW4mdSqB/Zu2URxVSo5 QCyMcnR8BmEslPya878OvBcp1BOUkSTwbwEMPSlm+YXkOo2+WY9eDyuyf 4L7SybrfIuBqYPFnd0qIPA2aRkGsj0epG3oryXobFfNiCKFX/wvevYFAP Adj0p5kKPxgKVl8SjNSbVUvnSYqI7T9ZNLVwyjXrJlXUzBcTt7U1RpOly A==; X-IronPort-AV: E=McAfee;i="6500,9779,10539"; a="311651837" X-IronPort-AV: E=Sophos;i="5.96,187,1665471600"; d="scan'208";a="311651837" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2022 01:18:07 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10539"; a="619544922" X-IronPort-AV: E=Sophos;i="5.96,187,1665471600"; d="scan'208";a="619544922" Received: from jgronski-mobl.ger.corp.intel.com (HELO localhost) ([10.252.16.163]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2022 01:18:04 -0800 From: Jani Nikula To: Kees Cook In-Reply-To: <202211222116.5B28E9B8B@keescook> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20221122120948.3436180-1-jani.nikula@intel.com> <202211222116.5B28E9B8B@keescook> Date: Wed, 23 Nov 2022 11:18:02 +0200 Message-ID: <87pmdevxkl.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Intel-gfx] [PATCH] drm/i915/hti: avoid theoretically possible negative shift X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 22 Nov 2022, Kees Cook wrote: > On Tue, Nov 22, 2022 at 02:09:48PM +0200, Jani Nikula wrote: >> If phy is PHY_NONE, the shift to register bits becomes negative. Check >> and warn about this. >> >> Reported-by: coverity-bot >> References: https://lore.kernel.org/r/202211180848.D39006C@keescook >> Signed-off-by: Jani Nikula > > Reviewed-by: Kees Cook Thanks for the review, pushed to drm-intel-next. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center