From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4B3CC4332F for ; Wed, 12 Oct 2022 15:22:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8416A10E569; Wed, 12 Oct 2022 15:22:15 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id C5C3310E54E for ; Wed, 12 Oct 2022 15:22:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665588130; x=1697124130; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=eMiYLKC86agXu2SjqWb/sPgQSIOXIQorhLWj6/U3Lds=; b=Bxutry4TmypQubfydotUbwko6l5zoCfuXf7IHG7/Q7cLD5vj1ajrY2GM 1kfaHVQ2T72GSvkRF6AzDcYqfy2PGGdb4zJehXEsJbIcTAhdZOEYkr9mK Aa9JYovrJM4daUn+NRldrLQYAPf3ygEpTG6SxHGdO0TUxTj9On9AgHCWI 33IioymGr7p8pltC6TMZzpejYDSmj9MM2JtbSczGnOySqDhci7TrCRhqr 0Mqs2mBBMWRMcRwcHGn6cJjh0B4Mr4HJ7M8Bvk0qo3MkVLSZ6YB+Vwy89 uWFgxY7t6kSpUtZJ5nNyRqaMVKFuA3W0SHTMod3ly0EGpZY4e1z5smm79 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10498"; a="303559770" X-IronPort-AV: E=Sophos;i="5.95,179,1661842800"; d="scan'208";a="303559770" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2022 08:22:10 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10498"; a="629145842" X-IronPort-AV: E=Sophos;i="5.95,179,1661842800"; d="scan'208";a="629145842" Received: from jhpuonti-mobl.ger.corp.intel.com (HELO localhost) ([10.252.40.226]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2022 08:22:08 -0700 From: Jani Nikula To: Ville Syrjala , intel-gfx@lists.freedesktop.org In-Reply-To: <20221011170011.17198-20-ville.syrjala@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20221011170011.17198-1-ville.syrjala@linux.intel.com> <20221011170011.17198-20-ville.syrjala@linux.intel.com> Date: Wed, 12 Oct 2022 18:22:11 +0300 Message-ID: <87pmext6cc.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Intel-gfx] [PATCH 19/22] drm/i915/sdvo: Do ELD hardware readout X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Takashi Iwai Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 11 Oct 2022, Ville Syrjala wrote: > From: Ville Syrj=C3=A4l=C3=A4 > > Read out the ELD from the hw so the state checker can verify it. > > Cc: Chaitanya Kumar Borah > Cc: Kai Vehmanen > Cc: Takashi Iwai > Signed-off-by: Ville Syrj=C3=A4l=C3=A4 Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_sdvo.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/= i915/display/intel_sdvo.c > index d9a54ed4623a..b2884fdc2b1c 100644 > --- a/drivers/gpu/drm/i915/display/intel_sdvo.c > +++ b/drivers/gpu/drm/i915/display/intel_sdvo.c > @@ -1185,6 +1185,21 @@ static void intel_sdvo_get_avi_infoframe(struct in= tel_sdvo *intel_sdvo, > frame->any.type, HDMI_INFOFRAME_TYPE_AVI); > } >=20=20 > +static void intel_sdvo_get_eld(struct intel_sdvo *intel_sdvo, > + struct intel_crtc_state *crtc_state) > +{ > + struct drm_i915_private *i915 =3D to_i915(intel_sdvo->base.base.dev); > + ssize_t len; > + > + if (!crtc_state->has_audio) > + return; > + > + len =3D intel_sdvo_read_infoframe(intel_sdvo, SDVO_HBUF_INDEX_ELD, > + crtc_state->eld, sizeof(crtc_state->eld)); > + if (len < 0) > + drm_dbg_kms(&i915->drm, "failed to read ELD\n"); > +} > + > static bool intel_sdvo_set_tv_format(struct intel_sdvo *intel_sdvo, > const struct drm_connector_state *conn_state) > { > @@ -1744,6 +1759,8 @@ static void intel_sdvo_get_config(struct intel_enco= der *encoder, > } >=20=20 > intel_sdvo_get_avi_infoframe(intel_sdvo, pipe_config); > + > + intel_sdvo_get_eld(intel_sdvo, pipe_config); > } >=20=20 > static void intel_sdvo_disable_audio(struct intel_sdvo *intel_sdvo) --=20 Jani Nikula, Intel Open Source Graphics Center