From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 0/3] drm/i915 / LPSS / mfd: Select correct PWM controller to use based on VBT Date: Tue, 19 Nov 2019 17:43:07 +0200 Message-ID: <87pnhnyir8.fsf@intel.com> References: <20191119151818.67531-1-hdegoede@redhat.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20191119151818.67531-1-hdegoede@redhat.com> Sender: linux-kernel-owner@vger.kernel.org To: Maarten Lankhorst , Joonas Lahtinen , Rodrigo Vivi , Ville =?utf-8?B?U3lyasOkbMOk?= , "Rafael J . Wysocki" , Len Brown , Lee Jones Cc: Hans de Goede , Andy Shevchenko , linux-acpi@vger.kernel.org, intel-gfx , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 19 Nov 2019, Hans de Goede wrote: > Hi All, > > This series needs to be merged through a single tree, to keep things > bisectable. I have even considered just squashing all 3 patches into 1, > but having separate commits seems better, but that does lead to an > intermediate state where the backlight sysfs interface will be broken > (and fixed 2 commits later). See below for some background info. > > The changes to drivers/acpi/acpi_lpss.c and drivers/mfd/intel_soc_pmic_core.c > are quite small and should not lead to any conflicts, so I believe that > it would be best to merge this entire series through the drm-intel tree. > > Lee, may I have your Acked-by for merging the mfd change through the > drm-intel tree? > > Rafael, may I have your Acked-by for merging the acpi_lpss change through the > drm-intel tree? > > Regards, > > Hans > > p.s. > > The promised background info: > > We have this long standing issue where instead of looking in the i915 > VBT (Video BIOS Table) to see if we should use the PWM block of the SoC > or of the PMIC to control the backlight of a DSI panel, we rely on > drivers/acpi/acpi_lpss.c and/or drivers/mfd/intel_soc_pmic_core.c > registering a pwm with the generic name of "pwm_backlight" and then the > i915 panel code does a pwm_get(dev, "pwm_backlight"). > > We have some heuristics in drivers/acpi/acpi_lpss.c to not register the > lookup if a Crystal Cove PMIC is presend and the mfd/intel_soc_pmic_core.c > code simply assumes that since there is a PMIC the PMIC PWM block will > be used. Basically we are winging it. > > Recently I've learned about 2 different BYT devices: > Point of View MOBII TAB-P800W > Acer Switch 10 SW5-012 > > Which use a Crystal Cove PMIC, yet the LCD is connected to the SoC/LPSS > PWM controller (and the VBT correctly indicates this), so here our old > heuristics fail. > > This series renams the PWM lookups registered by the LPSS / > intel_soc_pmic_core.c code from "pwm_backlight" to "pwm_soc_backlight" resp. > "pwm_pmic_backlight" and in the LPSS case also dropping the heuristics when > to register the lookup. This combined with teaching the i915 panel to call > pwm_get for the right lookup-name depending on the VBT bits resolves this. Hans, thanks for your continued efforts in digging into the bottom of this! I'm sure there are a number of related bugs still open at fdo bugzilla. It all makes sense, Acked-by: Jani Nikula for merging through whichever tree. Thanks, Jani. -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 633A4C432C3 for ; Tue, 19 Nov 2019 15:43:17 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4197322362 for ; Tue, 19 Nov 2019 15:43:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4197322362 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AE3FB6E4D4; Tue, 19 Nov 2019 15:43:16 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 83EED6E4D4; Tue, 19 Nov 2019 15:43:15 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Nov 2019 07:43:15 -0800 X-IronPort-AV: E=Sophos;i="5.68,324,1569308400"; d="scan'208";a="200388766" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Nov 2019 07:43:09 -0800 From: Jani Nikula To: Hans de Goede , Maarten Lankhorst , Joonas Lahtinen , Rodrigo Vivi , Ville =?utf-8?B?U3lyasOkbMOk?= , "Rafael J . Wysocki" , Len Brown , Lee Jones In-Reply-To: <20191119151818.67531-1-hdegoede@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20191119151818.67531-1-hdegoede@redhat.com> Date: Tue, 19 Nov 2019 17:43:07 +0200 Message-ID: <87pnhnyir8.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 0/3] drm/i915 / LPSS / mfd: Select correct PWM controller to use based on VBT X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-acpi@vger.kernel.org, intel-gfx , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Andy Shevchenko Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Message-ID: <20191119154307.4841YiW_ICkb-bVF91FSDVor9f-YtaNjfF0DTALGC1A@z> T24gVHVlLCAxOSBOb3YgMjAxOSwgSGFucyBkZSBHb2VkZSA8aGRlZ29lZGVAcmVkaGF0LmNvbT4g d3JvdGU6Cj4gSGkgQWxsLAo+Cj4gVGhpcyBzZXJpZXMgbmVlZHMgdG8gYmUgbWVyZ2VkIHRocm91 Z2ggYSBzaW5nbGUgdHJlZSwgdG8ga2VlcCB0aGluZ3MKPiBiaXNlY3RhYmxlLiBJIGhhdmUgZXZl biBjb25zaWRlcmVkIGp1c3Qgc3F1YXNoaW5nIGFsbCAzIHBhdGNoZXMgaW50byAxLAo+IGJ1dCBo YXZpbmcgc2VwYXJhdGUgY29tbWl0cyBzZWVtcyBiZXR0ZXIsIGJ1dCB0aGF0IGRvZXMgbGVhZCB0 byBhbgo+IGludGVybWVkaWF0ZSBzdGF0ZSB3aGVyZSB0aGUgYmFja2xpZ2h0IHN5c2ZzIGludGVy ZmFjZSB3aWxsIGJlIGJyb2tlbgo+IChhbmQgZml4ZWQgMiBjb21taXRzIGxhdGVyKS4gU2VlIGJl bG93IGZvciBzb21lIGJhY2tncm91bmQgaW5mby4KPgo+IFRoZSBjaGFuZ2VzIHRvIGRyaXZlcnMv YWNwaS9hY3BpX2xwc3MuYyBhbmQgZHJpdmVycy9tZmQvaW50ZWxfc29jX3BtaWNfY29yZS5jCj4g YXJlIHF1aXRlIHNtYWxsIGFuZCBzaG91bGQgbm90IGxlYWQgdG8gYW55IGNvbmZsaWN0cywgc28g SSBiZWxpZXZlIHRoYXQKPiBpdCB3b3VsZCBiZSBiZXN0IHRvIG1lcmdlIHRoaXMgZW50aXJlIHNl cmllcyB0aHJvdWdoIHRoZSBkcm0taW50ZWwgdHJlZS4KPgo+IExlZSwgbWF5IEkgaGF2ZSB5b3Vy IEFja2VkLWJ5IGZvciBtZXJnaW5nIHRoZSBtZmQgY2hhbmdlIHRocm91Z2ggdGhlCj4gZHJtLWlu dGVsIHRyZWU/Cj4KPiBSYWZhZWwsIG1heSBJIGhhdmUgeW91ciBBY2tlZC1ieSBmb3IgbWVyZ2lu ZyB0aGUgYWNwaV9scHNzIGNoYW5nZSB0aHJvdWdoIHRoZQo+IGRybS1pbnRlbCB0cmVlPwo+Cj4g UmVnYXJkcywKPgo+IEhhbnMKPgo+IHAucy4KPgo+IFRoZSBwcm9taXNlZCBiYWNrZ3JvdW5kIGlu Zm86Cj4KPiBXZSBoYXZlIHRoaXMgbG9uZyBzdGFuZGluZyBpc3N1ZSB3aGVyZSBpbnN0ZWFkIG9m IGxvb2tpbmcgaW4gdGhlIGk5MTUKPiBWQlQgKFZpZGVvIEJJT1MgVGFibGUpIHRvIHNlZSBpZiB3 ZSBzaG91bGQgdXNlIHRoZSBQV00gYmxvY2sgb2YgdGhlIFNvQwo+IG9yIG9mIHRoZSBQTUlDIHRv IGNvbnRyb2wgdGhlIGJhY2tsaWdodCBvZiBhIERTSSBwYW5lbCwgd2UgcmVseSBvbgo+IGRyaXZl cnMvYWNwaS9hY3BpX2xwc3MuYyBhbmQvb3IgZHJpdmVycy9tZmQvaW50ZWxfc29jX3BtaWNfY29y ZS5jCj4gcmVnaXN0ZXJpbmcgYSBwd20gd2l0aCB0aGUgZ2VuZXJpYyBuYW1lIG9mICJwd21fYmFj a2xpZ2h0IiBhbmQgdGhlbiB0aGUKPiBpOTE1IHBhbmVsIGNvZGUgZG9lcyBhIHB3bV9nZXQoZGV2 LCAicHdtX2JhY2tsaWdodCIpLgo+Cj4gV2UgaGF2ZSBzb21lIGhldXJpc3RpY3MgaW4gZHJpdmVy cy9hY3BpL2FjcGlfbHBzcy5jIHRvIG5vdCByZWdpc3RlciB0aGUKPiBsb29rdXAgaWYgYSBDcnlz dGFsIENvdmUgUE1JQyBpcyBwcmVzZW5kIGFuZCB0aGUgbWZkL2ludGVsX3NvY19wbWljX2NvcmUu Ywo+IGNvZGUgc2ltcGx5IGFzc3VtZXMgdGhhdCBzaW5jZSB0aGVyZSBpcyBhIFBNSUMgdGhlIFBN SUMgUFdNIGJsb2NrIHdpbGwKPiBiZSB1c2VkLiBCYXNpY2FsbHkgd2UgYXJlIHdpbmdpbmcgaXQu Cj4KPiBSZWNlbnRseSBJJ3ZlIGxlYXJuZWQgYWJvdXQgMiBkaWZmZXJlbnQgQllUIGRldmljZXM6 Cj4gUG9pbnQgb2YgVmlldyBNT0JJSSBUQUItUDgwMFcKPiBBY2VyIFN3aXRjaCAxMCBTVzUtMDEy Cj4KPiBXaGljaCB1c2UgYSBDcnlzdGFsIENvdmUgUE1JQywgeWV0IHRoZSBMQ0QgaXMgY29ubmVj dGVkIHRvIHRoZSBTb0MvTFBTUwo+IFBXTSBjb250cm9sbGVyIChhbmQgdGhlIFZCVCBjb3JyZWN0 bHkgaW5kaWNhdGVzIHRoaXMpLCBzbyBoZXJlIG91ciBvbGQKPiBoZXVyaXN0aWNzIGZhaWwuCj4K PiBUaGlzIHNlcmllcyByZW5hbXMgdGhlIFBXTSBsb29rdXBzIHJlZ2lzdGVyZWQgYnkgdGhlIExQ U1MgLwo+IGludGVsX3NvY19wbWljX2NvcmUuYyBjb2RlIGZyb20gInB3bV9iYWNrbGlnaHQiIHRv ICJwd21fc29jX2JhY2tsaWdodCIgcmVzcC4KPiAicHdtX3BtaWNfYmFja2xpZ2h0IiBhbmQgaW4g dGhlIExQU1MgY2FzZSBhbHNvIGRyb3BwaW5nIHRoZSBoZXVyaXN0aWNzIHdoZW4KPiB0byByZWdp c3RlciB0aGUgbG9va3VwLiBUaGlzIGNvbWJpbmVkIHdpdGggdGVhY2hpbmcgdGhlIGk5MTUgcGFu ZWwgdG8gY2FsbAo+IHB3bV9nZXQgZm9yIHRoZSByaWdodCBsb29rdXAtbmFtZSBkZXBlbmRpbmcg b24gdGhlIFZCVCBiaXRzIHJlc29sdmVzIHRoaXMuCgpIYW5zLCB0aGFua3MgZm9yIHlvdXIgY29u dGludWVkIGVmZm9ydHMgaW4gZGlnZ2luZyBpbnRvIHRoZSBib3R0b20gb2YKdGhpcyEKCkknbSBz dXJlIHRoZXJlIGFyZSBhIG51bWJlciBvZiByZWxhdGVkIGJ1Z3Mgc3RpbGwgb3BlbiBhdCBmZG8g YnVnemlsbGEuCgpJdCBhbGwgbWFrZXMgc2Vuc2UsCgpBY2tlZC1ieTogSmFuaSBOaWt1bGEgPGph bmkubmlrdWxhQGludGVsLmNvbT4KCmZvciBtZXJnaW5nIHRocm91Z2ggd2hpY2hldmVyIHRyZWUu CgoKVGhhbmtzLApKYW5pLgoKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgR3Jh cGhpY3MgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eA==