From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Mustaffa, Mustamin B" <mustamin.b.mustaffa@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915/bxt: Enable VBT based BL control for DP (v2)
Date: Tue, 13 Feb 2018 17:53:27 +0200 [thread overview]
Message-ID: <87po58lwco.fsf@intel.com> (raw)
In-Reply-To: <605678218D4AE343AA40E888647A6D691AEAD0B3@PGSMSX111.gar.corp.intel.com>
On Fri, 09 Feb 2018, "Mustaffa, Mustamin B" <mustamin.b.mustaffa@intel.com> wrote:
> May I know why the need to use connector as connector wasn't
> initialized in parent function ' intel_pps_get_registers'?
Oh, right, I overlooked that.
> While ' dev_priv' already initialized which also already initialized
> to the VBT value. So it make sense to me to use 'dev_priv' structure
> to read the VBT value instead of connector.
Okay, I think the right thing to do in the long run is to refactor the
code to initialize the value in the connector earlier. We'll want to use
the VBT only for initialization once. But for now, I think this is
fine. Please rebase the patch against current upstream so we get fresh
CI results, and resend.
Thanks,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-02-13 15:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 2:25 [PATCH] drm/i915/bxt: Enable VBT based BL control for DP (v2) Mustamin B Mustaffa
2018-01-10 2:26 ` ✗ Fi.CI.BAT: failure for drm/i915/bxt: Enable VBT based BL control for DP (rev4) Patchwork
2018-01-16 10:02 ` [PATCH] drm/i915/bxt: Enable VBT based BL control for DP (v2) Jani Nikula
2018-02-09 10:45 ` Mustaffa, Mustamin B
2018-02-13 15:53 ` Jani Nikula [this message]
2018-02-14 2:58 ` Mustaffa, Mustamin B
2018-02-15 14:13 ` Jani Nikula
-- strict thread matches above, loose matches on Subject: below --
2017-06-07 9:12 Mustamin B Mustaffa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87po58lwco.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mustamin.b.mustaffa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).