From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH] drm/i915: Fallback to reserve forcewake if primary ack missing Date: Thu, 02 Nov 2017 13:27:53 +0200 Message-ID: <87po90ex8m.fsf@gaia.fi.intel.com> References: <20171026140144.12267-1-mika.kuoppala@linux.intel.com> <20171030122707.10816-1-mika.kuoppala@linux.intel.com> <150936889791.4195.3473571417961107425@mail.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id CAB6F6E0B3 for ; Thu, 2 Nov 2017 11:28:18 +0000 (UTC) In-Reply-To: <150936889791.4195.3473571417961107425@mail.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gUXVvdGlu ZyBNaWthIEt1b3BwYWxhICgyMDE3LTEwLTMwIDEyOjI3OjA3KQo+PiBUaGVyZSBpcyBhIHBvc3Np YmlsaXR5IG9uIGdlbjkgaGFyZHdhcmUgdG8gbWlzcyB0aGUgZm9yY2V3YWtlIGFjawo+PiBtZXNz YWdlLiBUaGUgcmVjb21tZW5kZWQgd29ya2Fyb3VuZCBpcyB0byB1c2UgYW5vdGhlciBmcmVlCj4+ IGJpdCBhbmQgdG9nZ2xlIGl0IHVudGlsIG9yaWdpbmFsIGJpdCBpcyBzdWNjZXNzZnVsbHkgYWNr bm93bGVkZ2VkLgo+PiAKPj4gU29tZSBmdXR1cmUgZ2VuOSByZXZzIG1pZ2h0IG9yIG1pZ2h0IG5v dCBmaXggdGhlIHVuZGVybHlpbmcgaXNzdWUgYnV0Cj4+IHRoZSBmYWxsYmFjayB0byByZXNlcnZl IGJpdCBkYW5jZSBjYW4gYmUgY29uc2lkZXJlZCBhcyBoYXJtbGVzczoKPj4gd2l0aG91dCB0aGUg YWNrIHRpbWVvdXQgd2UgbmV2ZXIgcmVhY2ggdGhlIHJlc2VydmUgYml0IGZvcmNld2FrZS4KPj4g VGh1cyBhcyBvZiBub3cgd2UgYWRvcHQgYSBibGFua2V0IGFwcHJvYWNoIGZvciBhbGwgZ2VuOSBh bmQgbGVhdmUKPj4gdGhlIGJ5cGFzc2luZyB0aGUgcmVzZXJ2ZSBiaXQgYXBwcm9hY2ggZm9yIGZ1 dHVyZSBwYXRjaGVzIGlmCj4+IGNvcnJlc3BvbmRpbmcgaHcgcmV2aXNpb25zIGRvIGFwcGVhci4K Pj4gCj4+IENvbW1pdCA4M2UzMzM3MjA0YjIgKCJkcm0vaTkxNTogSW5jcmVhc2UgbWF4aW11bSBw b2xsaW5nIHRpbWUgdG8gNTBtcwo+PiBmb3IgZm9yY2V3YWtlIHJlcXVlc3QvY2xlYXIgYWNrIikg ZGlkIGluY3JlYXNlIHRoZSBmb3JjZXdha2UgdGltZW91dC4KPj4gSWYgdGhlIGlzc3VlIHdhcyBh IGRlbGF5ZWQgYWNrLCBmdXR1cmUgd29yayBjb3VsZCBpbmNsdWRlIGZpbmRpbmcKPj4gYSBzdWl0 YWJsZSB0aW1lb3V0IHZhbHVlIGJvdGggZm9yIHByaW1hcnkgYWNrIGFuZCByZXNlcnZlIHRvZ2ds ZQo+PiB0byByZWR1Y2UgdGhlIHdvcnN0IGNhc2UgbGF0ZW5jeS4KPj4gCj4+IHYyOiB1c2UgYml0 IDE1LCBuYW1pbmcsIGNvbW1lbnQgKENocmlzKSwgb25seSB3YWl0IGZhbGxiYWNrIGFjawo+PiB2 MzogZml4IHJldHVybiBvbiBmYWxsYmFjaywgYmFja29mZiBhZnRlciBmYWxsYmFjayB3cml0ZSAo Q2hyaXMpCj4+IAo+PiBSZWZlcmVuY2VzOiBIU0RFUyAjMTYwNDI1NDUyNAo+PiBSZWZlcmVuY2Vz OiBodHRwczovL2J1Z3MuZnJlZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDIwNTEKPj4g Q2M6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+PiBDYzogUm9kcmln byBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgo+PiBDYzogVHZydGtvIFVyc3VsaW4gPHR2 cnRrby51cnN1bGluQGludGVsLmNvbT4KPj4gQ2M6IEpvb25hcyBMYWh0aW5lbiA8am9vbmFzLmxh aHRpbmVuQGxpbnV4LmludGVsLmNvbT4KPj4gQ2M6IFNhZ2FyIEFydW4gS2FtYmxlIDxzYWdhci5h LmthbWJsZUBpbnRlbC5jb20+Cj4+IFNpZ25lZC1vZmYtYnk6IE1pa2EgS3VvcHBhbGEgPG1pa2Eu a3VvcHBhbGFAbGludXguaW50ZWwuY29tPgo+PiAtLS0KPj4gK3N0YXRpYyBpbnQKPj4gK2Z3X2Rv bWFpbl93YWl0X2Fja193aXRoX2ZhbGxiYWNrKGNvbnN0IHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICppOTE1LAo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3Qg aW50ZWxfdW5jb3JlX2ZvcmNld2FrZV9kb21haW4gKmQsCj4+ICsgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGNvbnN0IGVudW0gYWNrX3R5cGUgdHlwZSkKPj4gK3sKPj4gKyAgICAgICBj b25zdCB1MzIgYWNrX2JpdCA9IEZPUkNFV0FLRV9LRVJORUw7Cj4+ICsgICAgICAgY29uc3QgdTMy IHZhbHVlID0gdHlwZSA9PSBBQ0tfU0VUID8gYWNrX2JpdCA6IDA7Cj4+ICsgICAgICAgdW5zaWdu ZWQgaW50IHBhc3MgPSAwOwo+PiArICAgICAgIGJvb2wgYWNrX2RldGVjdGVkOwo+PiArCj4+ICsg ICAgICAgLyoKPj4gKyAgICAgICAgKiBUaGVyZSBpcyBhIHBvc3NpYmlsaXR5IG9mIGRyaXZlcidz IHdha2UgcmVxdWVzdCBjb2xsaWRpbmcKPj4gKyAgICAgICAgKiB3aXRoIGhhcmR3YXJlJ3Mgb3du IHdha2UgcmVxdWVzdHMgYW5kIHRoYXQgY2FuIGNhdXNlCj4+ICsgICAgICAgICogaGFyZHdhcmUg dG8gbm90IGRlbGl2ZXIgdGhlIGRyaXZlcidzIGFjayBtZXNzYWdlLgo+PiArICAgICAgICAqCj4+ ICsgICAgICAgICogVXNlIGEgZmFsbGJhY2sgYml0IHRvZ2dsZSB0byBraWNrIHRoZSBncHUgc3Rh dGUgbWFjaGluZQo+PiArICAgICAgICAqIGluIGhvcGVzIHRoYXQgdGhlIG9yaWdpbmFsIGFjayB3 aWxsIGJlIGRlbGl2ZXJlZCBhbG9uZyB3aXRoCj4+ICsgICAgICAgICogdGhlIGZhbGxiYWNrIGFj ay4KPgo+IHMvaW4gaG9wZXMvaW4gdGhlIGhvcGUvCj4KPj4gKyAgICAgICAgKgo+PiArICAgICAg ICAqIFRoaXMgd29ya2Fyb3VuZCBpcyBkZXNjcmliZWQgaW4gSFNERVMgIzE2MDQyNTQ1MjQKPj4g KyAgICAgICAgKi8KPj4gKwo+PiArICAgICAgIGRvIHsKPj4gKyAgICAgICAgICAgICAgIHdhaXRf YWNrX2NsZWFyKGk5MTUsIGQsIEZPUkNFV0FLRV9LRVJORUxfRkFMTEJBQ0spOwo+PiArCj4+ICsg ICAgICAgICAgICAgICBfX3Jhd19pOTE1X3dyaXRlMzIoaTkxNSwgZC0+cmVnX3NldCwKPj4gKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBfTUFTS0VEX0JJVF9FTkFCTEUoRk9SQ0VX QUtFX0tFUk5FTF9GQUxMQkFDSykpOwo+PiArICAgICAgICAgICAgICAgLyogR2l2ZSBndCBzb21l IHRpbWUgdG8gcmVsYXggYmVmb3JlIHRoZSBwb2xsaW5nIGZyZW56eSAqLwo+PiArICAgICAgICAg ICAgICAgdWRlbGF5KDEwICogcGFzcyk7Cj4+ICsgICAgICAgICAgICAgICB3YWl0X2Fja19zZXQo aTkxNSwgZCwgRk9SQ0VXQUtFX0tFUk5FTF9GQUxMQkFDSyk7Cj4KPiBJIHdvdWxkIGhhdmUgc3Rh cnRlZCBmcm9tIHBhc3M9MSAoaS5lLiB1ZGVsYXkoMTApKSBhcyB3ZSBhbHJlYWR5IGhhdmUgYQo+ IDAtZGVsYXkgZm9yIHRoZSBwcmltYXJ5IHdhaXRfYWNrIGJlZm9yZSB3ZSBoaXQgdGhlIGZhbGxi YWNrLgo+Cj4+ICsKPj4gKyAgICAgICAgICAgICAgIGFja19kZXRlY3RlZCA9IChfX3Jhd19pOTE1 X3JlYWQzMihpOTE1LCBkLT5yZWdfYWNrKSAmIGFja19iaXQpID09IHZhbHVlOwo+PiArCj4+ICsg ICAgICAgICAgICAgICBfX3Jhd19pOTE1X3dyaXRlMzIoaTkxNSwgZC0+cmVnX3NldCwKPj4gKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBfTUFTS0VEX0JJVF9ESVNBQkxFKEZPUkNF V0FLRV9LRVJORUxfRkFMTEJBQ0spKTsKPj4gKyAgICAgICAgICAgICAgIHBhc3MrKzsKPj4gKyAg ICAgICB9IHdoaWxlICghYWNrX2RldGVjdGVkICYmIHBhc3MgPCAxMCk7Cj4KPiAJdW5zaWduZWQg aW50IHBhc3MgPSAxOwo+IAlkbyB7Cj4gCQkuLi4KPiAJfSB3aGlsZSAoIWFja19kZXRlY3RlZCAm JiBwYXNzKysgPCAxMCk7Cj4KPj4gKwo+PiArICAgICAgIERSTV9ERUJVR19EUklWRVIoIiVzIGhh ZCB0byB1c2UgZmFsbGJhY2sgdG8gJXMgYWNrLCAweCV4IChwYXNzZXMgJXUpXG4iLAo+PiArICAg ICAgICAgICAgICAgICAgICAgICAgaW50ZWxfdW5jb3JlX2ZvcmNld2FrZV9kb21haW5fdG9fc3Ry KGQtPmlkKSwKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgIHR5cGUgPT0gQUNLX1NFVCA/ICJz ZXQiIDogImNsZWFyIiwKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgIF9fcmF3X2k5MTVfcmVh ZDMyKGk5MTUsIGQtPnJlZ19hY2spLAo+PiArICAgICAgICAgICAgICAgICAgICAgICAgcGFzcyk7 Cj4+ICsKPj4gKyAgICAgICByZXR1cm4gYWNrX2RldGVjdGVkID8gMCA6IC1FVElNRURPVVQ7Cj4+ ICt9Cj4KPiBJIHdhcyBnb2luZyB0byBzYXkgYS1iLCBidXQgZ2l2ZW4gdGhlIHN0YXRlIG1hY2hp bmUgd2UndmUgZGVkdWNlZCB0aGF0Cj4gZXhwbGFpbnMgd2h5IHRoaXMgdy9hIGhhcyBhbnkgY2hh bmNlIG9mIHN1Y2NlZWRpbmcsIEkgZmVlbCBhCj4KCkFuZCBpdCBzaG91bGQgYmUgcmF0aGVyIGFj Y3VyYXRlbHkgbWFjaGluZyB0aGUgcmVjb21tZW5kYXRpb24Kb2YgdGhlIGh3IGVuZ2luZWVycyBo b3cgdG8gaGFuZGxlIHRoZSBpc3N1ZS4KClRoZXJlIGlzIGEgbWVudGlvbiB0aGF0IHRoaXMgc2hv dWxkIGJlIG9uIHRvcCBvZiBkZWxheWVkCmFjayByZWFkaW5nIG9mIHRoZSBwcmltYXJ5IGZ3IHJl cXVlc3QsIHdoaWNoIHdlIGRvbid0IGhhdmUuCgpIb3cgSSB1bmRlcnN0YW5kIHRoZSBpc3N1ZSBp cyB0aGF0IHdpdGhvdXQgZGVsYXlpbmcgdGhlCnByaW1hcnkgYWNrIHdlIGFyZSBtb3JlIGxpa2Vs eSB0byBoaXQgdGhlIGZhbGxiYWNrCmFzIHRoZSBwb2xsIGlzIGludGVyd2luZWQgd2l0aCB0aGUg cHJpbWFyeSBhY2sgbWVzc2FnZQpnZXR0aW5nIGxvc3QuCgpCdXQgYXMgd2Ugbm93IGhhdmUgdGhl IGJpZyBoYW1tZXIgaW4gcGxhY2UsIHdlCmNhbiBzZWUgaG93IGl0IGdvZXMgYW5kIHRoZW4gdHdl YWsgdGhlIGRlbGF5cyBhbmQKdGltZW91dHMgaWYgbmVlZCBhcmlzZXMuCgpPdXIgdGltZW91dHMg YXJlIHF1aXRlIGxvbmcgYW5kIEkgaGF2ZSBhIHN1c3BpY2lvbgp0aGF0IHRoZSBjb21taXQgSSBh bSByZWZlcnJpbmcgdG8gaW4gYnh0IGNhc2Ugd2FzCnBhcGVyaW5nIG92ZXIgb2YgdGhpcyBpc3N1 ZS4KCj4gUmV2aWV3ZWQtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVr PgoKVGhhbmtzLiBQdXNoZWQuCgo+IGlzIGp1c3RpZmllZC4gKElmIGl0J3Mgd3JvbmcsIEknbSBl cXVhbGx5IGN1bHBhYmxlIDspCgpXb3VsZG4ndCBpdCBiZSBuaWNlIGlmIHdlIGhhZCBoYXJkd2Fy ZSBlbmdpbmVlcnMgdG8Kc3RhbXAgdGhlc2Uga2luZCBvZiBwYXRjaGVzLgoKLU1pa2EKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxp bmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==