From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 2/3] drm/i915/execlists: Move request unwinding to a separate function Date: Mon, 25 Sep 2017 17:54:40 +0300 Message-ID: <87poaezv4f.fsf@gaia.fi.intel.com> References: <20170925124929.16974-1-chris@chris-wilson.co.uk> <20170925124929.16974-2-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id CA1116E1CF for ; Mon, 25 Sep 2017 14:57:08 +0000 (UTC) In-Reply-To: <20170925124929.16974-2-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gSW4gdGhl IGZ1dHVyZSwgd2Ugd2lsbCB3YW50IHRvIHVud2luZCByZXF1ZXN0cyBmb2xsb3dpbmcgYSBwcmVl bXB0aW9uCj4gcG9pbnQuIFRoaXMgcmVxdWlyZXMgdGhlIHNhbWUgc3RlcHMgYXMgZm9yIHVud2lu ZGluZyB1cG9uIGEgcmVzZXQsIHNvCj4gZXh0cmFjdCB0aGUgZXhpc3RpbmcgY29kZSB0byBhIHNl cGFyYXRlIGZ1bmN0aW9uIGZvciBsYXRlciB1c2UuCj4KPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBX aWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KClJldmlld2VkLWJ5OiBNaWthIEt1b3Bw YWxhIDxtaWthLmt1b3BwYWxhQGxpbnV4LmludGVsLmNvbT4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2xyYy5jIHwgNTMgKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0t LS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMzMgaW5zZXJ0aW9ucygrKSwgMjAgZGVsZXRp b25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+IGluZGV4IDJjMDdmM2MwOGJkMy4u Yzg0ODMxYzdlYTRhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xy Yy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPiBAQCAtMzQ4LDYg KzM0OCwzNyBAQCBsb29rdXBfcHJpb2xpc3Qoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5l LAo+ICAJcmV0dXJuIHB0cl9wYWNrX2JpdHMocCwgZmlyc3QsIDEpOwo+ICB9Cj4gIAo+ICtzdGF0 aWMgdm9pZCB1bndpbmRfd2FfdGFpbChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJxKQo+ ICt7Cj4gKwlycS0+dGFpbCA9IGludGVsX3Jpbmdfd3JhcChycS0+cmluZywKPiArCQkJCSAgIHJx LT53YV90YWlsIC0gV0FfVEFJTF9EV09SRFMqc2l6ZW9mKHUzMikpOwo+ICsJYXNzZXJ0X3Jpbmdf dGFpbF92YWxpZChycS0+cmluZywgcnEtPnRhaWwpOwo+ICt9Cj4gKwo+ICtzdGF0aWMgdm9pZCB1 bndpbmRfaW5jb21wbGV0ZV9yZXF1ZXN0cyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUp Cj4gK3sKPiArCXN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcnEsICpybjsKPiArCj4gKwls b2NrZGVwX2Fzc2VydF9oZWxkKCZlbmdpbmUtPnRpbWVsaW5lLT5sb2NrKTsKPiArCWxpc3RfZm9y X2VhY2hfZW50cnlfc2FmZV9yZXZlcnNlKHJxLCBybiwKPiArCQkJCQkgJmVuZ2luZS0+dGltZWxp bmUtPnJlcXVlc3RzLAo+ICsJCQkJCSBsaW5rKSB7Cj4gKwkJc3RydWN0IGk5MTVfcHJpb2xpc3Qg KnA7Cj4gKwo+ICsJCWlmIChpOTE1X2dlbV9yZXF1ZXN0X2NvbXBsZXRlZChycSkpCj4gKwkJCXJl dHVybjsKPiArCj4gKwkJX19pOTE1X2dlbV9yZXF1ZXN0X3Vuc3VibWl0KHJxKTsKPiArCQl1bndp bmRfd2FfdGFpbChycSk7Cj4gKwo+ICsJCXAgPSBsb29rdXBfcHJpb2xpc3QoZW5naW5lLAo+ICsJ CQkJICAgICZycS0+cHJpb3RyZWUsCj4gKwkJCQkgICAgcnEtPnByaW90cmVlLnByaW9yaXR5KTsK PiArCQlsaXN0X2FkZCgmcnEtPnByaW90cmVlLmxpbmssCj4gKwkJCSAmcHRyX21hc2tfYml0cyhw LCAxKS0+cmVxdWVzdHMpOwo+ICsJfQo+ICt9Cj4gKwo+ICBzdGF0aWMgaW5saW5lIHZvaWQKPiAg ZXhlY2xpc3RzX2NvbnRleHRfc3RhdHVzX2NoYW5nZShzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVl c3QgKnJxLAo+ICAJCQkJdW5zaWduZWQgbG9uZyBzdGF0dXMpCj4gQEAgLTEzNzgsNyArMTQwOSw2 IEBAIHN0YXRpYyB2b2lkIHJlc2V0X2NvbW1vbl9yaW5nKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3Mg KmVuZ2luZSwKPiAgCQkJICAgICAgc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXF1ZXN0 KQo+ICB7Cj4gIAlzdHJ1Y3QgaW50ZWxfZW5naW5lX2V4ZWNsaXN0cyAqIGNvbnN0IGV4ZWNsaXN0 cyA9ICZlbmdpbmUtPmV4ZWNsaXN0czsKPiAtCXN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAq cnEsICpybjsKPiAgCXN0cnVjdCBpbnRlbF9jb250ZXh0ICpjZTsKPiAgCXVuc2lnbmVkIGxvbmcg ZmxhZ3M7Cj4gIAo+IEBAIC0xMzk2LDIxICsxNDI2LDcgQEAgc3RhdGljIHZvaWQgcmVzZXRfY29t bW9uX3Jpbmcoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lLAo+ICAJZXhlY2xpc3RfY2Fu Y2VsX3BvcnRfcmVxdWVzdHMoZXhlY2xpc3RzKTsKPiAgCj4gIAkvKiBQdXNoIGJhY2sgYW55IGlu Y29tcGxldGUgcmVxdWVzdHMgZm9yIHJlcGxheSBhZnRlciB0aGUgcmVzZXQuICovCj4gLQlsaXN0 X2Zvcl9lYWNoX2VudHJ5X3NhZmVfcmV2ZXJzZShycSwgcm4sCj4gLQkJCQkJICZlbmdpbmUtPnRp bWVsaW5lLT5yZXF1ZXN0cywgbGluaykgewo+IC0JCXN0cnVjdCBpOTE1X3ByaW9saXN0ICpwOwo+ IC0KPiAtCQlpZiAoaTkxNV9nZW1fcmVxdWVzdF9jb21wbGV0ZWQocnEpKQo+IC0JCQlicmVhazsK PiAtCj4gLQkJX19pOTE1X2dlbV9yZXF1ZXN0X3Vuc3VibWl0KHJxKTsKPiAtCj4gLQkJcCA9IGxv b2t1cF9wcmlvbGlzdChlbmdpbmUsCj4gLQkJCQkgICAgJnJxLT5wcmlvdHJlZSwKPiAtCQkJCSAg ICBycS0+cHJpb3RyZWUucHJpb3JpdHkpOwo+IC0JCWxpc3RfYWRkKCZycS0+cHJpb3RyZWUubGlu aywKPiAtCQkJICZwdHJfbWFza19iaXRzKHAsIDEpLT5yZXF1ZXN0cyk7Cj4gLQl9Cj4gKwl1bndp bmRfaW5jb21wbGV0ZV9yZXF1ZXN0cyhlbmdpbmUpOwo+ICAKPiAgCXNwaW5fdW5sb2NrX2lycXJl c3RvcmUoJmVuZ2luZS0+dGltZWxpbmUtPmxvY2ssIGZsYWdzKTsKPiAgCj4gQEAgLTE0NDcsMTAg KzE0NjMsNyBAQCBzdGF0aWMgdm9pZCByZXNldF9jb21tb25fcmluZyhzdHJ1Y3QgaW50ZWxfZW5n aW5lX2NzICplbmdpbmUsCj4gIAlpbnRlbF9yaW5nX3VwZGF0ZV9zcGFjZShyZXF1ZXN0LT5yaW5n KTsKPiAgCj4gIAkvKiBSZXNldCBXYUlkbGVMaXRlUmVzdG9yZTpiZHcsc2tsIGFzIHdlbGwgKi8K PiAtCXJlcXVlc3QtPnRhaWwgPQo+IC0JCWludGVsX3Jpbmdfd3JhcChyZXF1ZXN0LT5yaW5nLAo+ IC0JCQkJcmVxdWVzdC0+d2FfdGFpbCAtIFdBX1RBSUxfRFdPUkRTKnNpemVvZih1MzIpKTsKPiAt CWFzc2VydF9yaW5nX3RhaWxfdmFsaWQocmVxdWVzdC0+cmluZywgcmVxdWVzdC0+dGFpbCk7Cj4g Kwl1bndpbmRfd2FfdGFpbChyZXF1ZXN0KTsKPiAgfQo+ICAKPiAgc3RhdGljIGludCBpbnRlbF9s b2dpY2FsX3JpbmdfZW1pdF9wZHBzKHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxKQo+ IC0tIAo+IDIuMTQuMQo+Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eAo=