From: Jani Nikula <jani.nikula@linux.intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t] scripts/run-tests.sh: Look for test-lists.txt in 'build' as well
Date: Thu, 21 Sep 2017 16:05:07 +0300 [thread overview]
Message-ID: <87poak5hj0.fsf@nikula.org> (raw)
In-Reply-To: <20170920163519.6099-1-ville.syrjala@linux.intel.com>
On Wed, 20 Sep 2017, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Meson always uses a separate build directotry. Adjust the assumptions
> in run-tests.sh to work in that environment. For now I'll just hardcode
> it to look for a directly called 'build'. I suppose we might want to
> let the user pass that in, but for now I can't be bothered to do that.
As I suggested to Daniel in the mesonification patches, we could produce
an sh.config with all the relevant paths and more, and have the scripts
include that. Of course, you'll need to either pass in the information
about the location of sh.config, or expect run-tests.sh to be run with
the build directory as the CWD. Or support both.
BR,
Jani.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> scripts/run-tests.sh | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/scripts/run-tests.sh b/scripts/run-tests.sh
> index a28dd8760a63..11e65d492fa1 100755
> --- a/scripts/run-tests.sh
> +++ b/scripts/run-tests.sh
> @@ -34,6 +34,8 @@ if [ ! -d "$IGT_TEST_ROOT" ]; then
> exit 1
> fi
>
> +[ -f "$IGT_TEST_ROOT/test-list.txt" ] || IGT_TEST_ROOT="$ROOT/build/tests"
> +
> if [ ! -f "$IGT_TEST_ROOT/test-list.txt" ]; then
> echo "Error: test list not found."
> echo "Please run make in the tests directory to generate the test list."
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2017-09-21 13:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 16:35 [PATCH i-g-t] scripts/run-tests.sh: Look for test-lists.txt in 'build' as well Ville Syrjala
2017-09-20 20:13 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-09-20 23:44 ` ✓ Fi.CI.IGT: " Patchwork
2017-09-21 13:05 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87poak5hj0.fsf@nikula.org \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox