public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 27/27] drm/i915/gen9: Add WaFbcHighMemBwCorruptionAvoidance
Date: Wed, 08 Jun 2016 17:29:27 +0300	[thread overview]
Message-ID: <87porrhhyw.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20160607160432.GJ4329@intel.com>

Ville Syrjälä <ville.syrjala@linux.intel.com> writes:

> [ text/plain ]
> On Tue, Jun 07, 2016 at 05:19:19PM +0300, Mika Kuoppala wrote:
>> Add this fbc related workaround for all gen9
>> 
>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>

All patches pushed to dinq. Ty all for review.

-Mika


>> ---
>>  drivers/gpu/drm/i915/i915_reg.h | 1 +
>>  drivers/gpu/drm/i915/intel_pm.c | 4 ++++
>>  2 files changed, 5 insertions(+)
>> 
>> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
>> index f6a140b2c77c..81d1896f158c 100644
>> --- a/drivers/gpu/drm/i915/i915_reg.h
>> +++ b/drivers/gpu/drm/i915/i915_reg.h
>> @@ -2209,6 +2209,7 @@ enum skl_disp_power_wells {
>>  #define ILK_DPFC_STATUS		_MMIO(0x43210)
>>  #define ILK_DPFC_FENCE_YOFF	_MMIO(0x43218)
>>  #define ILK_DPFC_CHICKEN	_MMIO(0x43224)
>> +#define   ILK_DPFC_DISABLE_DUMMY0 (1<<8)
>>  #define   ILK_DPFC_NUKE_ON_ANY_MODIFICATION	(1<<23)
>>  #define ILK_FBC_RT_BASE		_MMIO(0x2128)
>>  #define   ILK_FBC_RT_VALID	(1<<0)
>> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
>> index 1464d7ba69d4..658a75659657 100644
>> --- a/drivers/gpu/drm/i915/intel_pm.c
>> +++ b/drivers/gpu/drm/i915/intel_pm.c
>> @@ -75,6 +75,10 @@ static void gen9_init_clock_gating(struct drm_device *dev)
>>  	I915_WRITE(DISP_ARB_CTL, I915_READ(DISP_ARB_CTL) |
>>  		   DISP_FBC_WM_DIS |
>>  		   DISP_FBC_MEMORY_WAKE);
>> +
>> +	/* WaFbcHighMemBwCorruptionAvoidance:skl,bxt,kbl */
>> +	I915_WRITE(ILK_DPFC_CHICKEN, I915_READ(ILK_DPFC_CHICKEN) |
>> +		   ILK_DPFC_DISABLE_DUMMY0);
>>  }
>>  
>>  static void bxt_init_clock_gating(struct drm_device *dev)
>> -- 
>> 2.7.4
>
> -- 
> Ville Syrjälä
> Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-06-08 14:32 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-07 14:18 [PATCH 00/27] gen9 workarounds v3 Mika Kuoppala
2016-06-07 14:18 ` [PATCH 01/27] drm/i915/skl: Add WaDisableGafsUnitClkGating Mika Kuoppala
2016-06-07 14:18 ` [PATCH 02/27] drm/i915/kbl: Init gen9 workarounds Mika Kuoppala
2016-06-07 14:18 ` [PATCH 03/27] drm/i915/kbl: Add REVID macro Mika Kuoppala
2016-06-07 14:18 ` [PATCH 04/27] drm/i915/kbl: Add WaSkipStolenMemoryFirstPage for A0 Mika Kuoppala
2016-06-07 14:18 ` [PATCH 05/27] drm/i915/gen9: Always apply WaForceContextSaveRestoreNonCoherent Mika Kuoppala
2016-06-07 14:18 ` [PATCH 06/27] drm/i915: Mimic skl with WaForceEnableNonCoherent Mika Kuoppala
2016-06-07 14:18 ` [PATCH 07/27] drm/i915/kbl: Add WaEnableGapsTsvCreditFix Mika Kuoppala
2016-06-07 14:19 ` [PATCH 08/27] drm/i915/kbl: Add WaDisableFenceDestinationToSLM for A0 Mika Kuoppala
2016-06-07 14:19 ` [PATCH 09/27] drm/i915/kbl: Add WaDisableSDEUnitClockGating Mika Kuoppala
2016-06-07 14:19 ` [PATCH 10/27] drm/i915/edp: Add WaKVMNotificationOnConfigChange:bdw Mika Kuoppala
2016-06-07 14:19 ` [PATCH 11/27] drm/i915/kbl: Add WaDisableLSQCROPERFforOCL Mika Kuoppala
2016-06-07 14:19 ` [PATCH 12/27] drm/i915/gen9: Enable must set chicken bits in config0 reg Mika Kuoppala
2016-06-07 14:19 ` [PATCH 13/27] drm/i915/kbl: Add WaDisableGamClockGating Mika Kuoppala
2016-06-07 14:19 ` [PATCH 14/27] drm/i915/kbl: Add WaDisableDynamicCreditSharing Mika Kuoppala
2016-06-07 14:19 ` [PATCH 15/27] drm/i915: Add WaInsertDummyPushConstP for bxt and kbl Mika Kuoppala
2016-06-07 14:19 ` [PATCH 16/27] drm/i915/gen9: Add WaDisableSkipCaching Mika Kuoppala
2016-06-07 14:19 ` [PATCH 17/27] drm/i915/skl: Add WAC6entrylatency Mika Kuoppala
2016-06-07 14:19 ` [PATCH 18/27] drm/i915/kbl: Add WaForGAMHang Mika Kuoppala
2016-06-07 14:19 ` [PATCH 19/27] drm/i915/kbl: Add WaDisableGafsUnitClkGating Mika Kuoppala
2016-06-07 14:19 ` [PATCH 20/27] drm/i915/kbl: Add WaDisableSbeCacheDispatchPortSharing Mika Kuoppala
2016-06-07 14:19 ` [PATCH 21/27] drm/i915/gen9: Add WaEnableChickenDCPR Mika Kuoppala
2016-06-07 14:19 ` [PATCH 22/27] drm/i915/skl: Extend WaDisableChickenBitTSGBarrierAckForFFSliceCS Mika Kuoppala
2016-06-07 14:19 ` [PATCH 23/27] drm/i915/kbl: Add WaClearSlmSpaceAtContextSwitch Mika Kuoppala
2016-06-07 14:19 ` [PATCH 24/27] drm/i915/gen9: Add WaFbcTurnOffFbcWatermark Mika Kuoppala
2016-06-07 14:19 ` [PATCH 25/27] drm/i915/gen9: Add WaFbcWakeMemOn Mika Kuoppala
2016-06-07 14:19 ` [PATCH 26/27] drm/i195/fbc: Add WaFbcNukeOnHostModify Mika Kuoppala
2016-06-07 14:19 ` [PATCH 27/27] drm/i915/gen9: Add WaFbcHighMemBwCorruptionAvoidance Mika Kuoppala
2016-06-07 16:04   ` Ville Syrjälä
2016-06-08 14:29     ` Mika Kuoppala [this message]
2016-06-07 14:52 ` ✓ Ro.CI.BAT: success for gen9 workarounds v3 Patchwork
2016-06-08  0:06   ` Chris Wilson
2016-06-08 14:28     ` Mika Kuoppala
2016-06-08 14:56       ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87porrhhyw.fsf@gaia.fi.intel.com \
    --to=mika.kuoppala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox