From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 08/15] drm/i915/dsi: be defensive about out of bounds operation byte Date: Tue, 05 Jan 2016 16:44:34 +0200 Message-ID: <87poxg13xp.fsf@intel.com> References: <01c71ac89a9db8bc7b8ae0fb05c50a5fae362dc4.1450702954.git.jani.nikula@intel.com> <20160105141522.GG8076@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 2A0D66E1BB for ; Tue, 5 Jan 2016 06:44:37 -0800 (PST) In-Reply-To: <20160105141522.GG8076@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: Deepak M , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAwNSBKYW4gMjAxNiwgRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPiB3cm90 ZToKPiBPbiBNb24sIERlYyAyMSwgMjAxNSBhdCAwMzoxMDo1OVBNICswMjAwLCBKYW5pIE5pa3Vs YSB3cm90ZToKPj4gVW50aWUgdGhlIFZCVCBiYXNlZCBnZW5lcmljIHBhbmVsIGRyaXZlciBmcm9t IHRoZSBWQlQgcGFyc2luZywgc28gdGhhdAo+PiB0aGUgdHdvIGRvbid0IGhhdmUgdG8gYmUgdXBk YXRlZCBpbiBsb2Nrc3RlcC4KPj4gCj4+IFNpZ25lZC1vZmYtYnk6IEphbmkgTmlrdWxhIDxqYW5p Lm5pa3VsYUBpbnRlbC5jb20+Cj4+IC0tLQo+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZHNpX3BhbmVsX3ZidC5jIHwgMjIgKysrKysrKysrLS0tLS0tLS0tLS0tLQo+PiAgMSBmaWxlIGNo YW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgMTMgZGVsZXRpb25zKC0pCj4+IAo+PiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHNpX3BhbmVsX3ZidC5jIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZHNpX3BhbmVsX3ZidC5jCj4+IGluZGV4IDQ1NTEyZTBkZjU3YS4u YmE1MzU1NTA2NTkwIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k c2lfcGFuZWxfdmJ0LmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHNpX3Bh bmVsX3ZidC5jCj4+IEBAIC0yMzIsMTEgKzIzMiw5IEBAIHN0YXRpYyBjb25zdCB1OCAqbWlwaV9l eGVjX2dwaW8oc3RydWN0IGludGVsX2RzaSAqaW50ZWxfZHNpLCBjb25zdCB1OCAqZGF0YSkKPj4g IHR5cGVkZWYgY29uc3QgdTggKiAoKmZuX21pcGlfZWxlbV9leGVjKShzdHJ1Y3QgaW50ZWxfZHNp ICppbnRlbF9kc2ksCj4+ICAJCQkJCWNvbnN0IHU4ICpkYXRhKTsKPj4gIHN0YXRpYyBjb25zdCBm bl9taXBpX2VsZW1fZXhlYyBleGVjX2VsZW1bXSA9IHsKPj4gLQlOVUxMLCAvKiByZXNlcnZlZCAq Lwo+PiAtCW1pcGlfZXhlY19zZW5kX3BhY2tldCwKPj4gLQltaXBpX2V4ZWNfZGVsYXksCj4+IC0J bWlwaV9leGVjX2dwaW8sCj4+IC0JTlVMTCwgLyogc3RhdHVzIHJlYWQ7IGxhdGVyICovCj4+ICsJ W01JUElfU0VRX0VMRU1fU0VORF9QS1RdID0gbWlwaV9leGVjX3NlbmRfcGFja2V0LAo+PiArCVtN SVBJX1NFUV9FTEVNX0RFTEFZXSA9IG1pcGlfZXhlY19kZWxheSwKPj4gKwlbTUlQSV9TRVFfRUxF TV9HUElPXSA9IG1pcGlfZXhlY19ncGlvLAo+PiAgfTsKPj4gIAo+PiAgLyoKPj4gQEAgLTI2NCw3 ICsyNjIsNiBAQCBzdGF0aWMgY29uc3QgY2hhciAqc2VxdWVuY2VfbmFtZShlbnVtIG1pcGlfc2Vx IHNlcV9pZCkKPj4gIHN0YXRpYyB2b2lkIGdlbmVyaWNfZXhlY19zZXF1ZW5jZShzdHJ1Y3QgaW50 ZWxfZHNpICppbnRlbF9kc2ksIGNvbnN0IHU4ICpkYXRhKQo+PiAgewo+PiAgCWZuX21pcGlfZWxl bV9leGVjIG1pcGlfZWxlbV9leGVjOwo+PiAtCWludCBpbmRleDsKPj4gIAo+PiAgCWlmICghZGF0 YSkKPj4gIAkJcmV0dXJuOwo+PiBAQCAtMjc3LDE1ICsyNzQsMTQgQEAgc3RhdGljIHZvaWQgZ2Vu ZXJpY19leGVjX3NlcXVlbmNlKHN0cnVjdCBpbnRlbF9kc2kgKmludGVsX2RzaSwgY29uc3QgdTgg KmRhdGEpCj4+ICAKPj4gIAkvKiBwYXJzZSBlYWNoIGJ5dGUgdGlsbCB3ZSByZWFjaCBlbmQgb2Yg c2VxdWVuY2UgYnl0ZSAtIDB4MDAgKi8KPj4gIAl3aGlsZSAoMSkgewo+PiAtCQlpbmRleCA9ICpk YXRhOwo+PiAtCQltaXBpX2VsZW1fZXhlYyA9IGV4ZWNfZWxlbVtpbmRleF07Cj4+IC0JCWlmICgh bWlwaV9lbGVtX2V4ZWMpIHsKPj4gLQkJCURSTV9FUlJPUigiVW5zdXBwb3J0ZWQgTUlQSSBlbGVt ZW50LCBza2lwcGluZyBzZXF1ZW5jZSBleGVjdXRpb25cbiIpOwo+PiArCQl1OCBvcGVyYXRpb25f Ynl0ZSA9ICpkYXRhKys7Cj4+ICsJCWlmIChvcGVyYXRpb25fYnl0ZSA+PSBBUlJBWV9TSVpFKGV4 ZWNfZWxlbSkgfHwKPj4gKwkJICAgICFleGVjX2VsZW1bb3BlcmF0aW9uX2J5dGVdKSB7Cj4+ICsJ CQlEUk1fRVJST1IoIlVuc3VwcG9ydGVkIE1JUEkgb3BlcmF0aW9uIGJ5dGUgJXVcbiIsCj4KPiBN YXliZSBEUk1fRVJST1IgaW4gdGhlIHByZXZpb3VzIHBhdGNoIHRvbz8gSnVzdCBmb3Igb2NkIGNv bnNpc3RlbmN5Lgo+Cj4gUmV2aWV3ZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJA ZmZ3bGwuY2g+CgpQdXNoZWQgdXAgdG8gYW5kIGluY2x1ZGluZyB0aGlzIHBhdGNoLiBJIHRvb2sg dGhlIGxpYmVydHkgb2YgcHVzaGluZwphcy1pcywgbGVhdmluZyB0aGUgbml0cGlja3MgZm9yIGZv bGxvdy11cC4gVGhhbmtzIGZvciB0aGUgcmV2aWV3LgoKQlIsCkphbmkuCgoKPgo+PiArCQkJCSAg b3BlcmF0aW9uX2J5dGUpOwo+PiAgCQkJcmV0dXJuOwo+PiAgCQl9Cj4+IC0KPj4gLQkJLyogZ290 byBlbGVtZW50IHBheWxvYWQgKi8KPj4gLQkJZGF0YSsrOwo+PiArCQltaXBpX2VsZW1fZXhlYyA9 IGV4ZWNfZWxlbVtvcGVyYXRpb25fYnl0ZV07Cj4+ICAKPj4gIAkJLyogZXhlY3V0ZSB0aGUgZWxl bWVudCBzcGVjaWZpYyByb3RpbmVzICovCj4+ICAJCWRhdGEgPSBtaXBpX2VsZW1fZXhlYyhpbnRl bF9kc2ksIGRhdGEpOwo+PiAtLSAKPj4gMi4xLjQKPj4gCj4+IF9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCj4+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPj4g SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+PiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKSmFuaSBOaWt1bGEsIEludGVs IE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vaW50ZWwtZ2Z4Cg==