Re: [PATCH 05/43] drm/i915: Parametrize FBC_TAG registers

Jani Nikula
2015-09-21T07:46:19Z

On Fri, 18 Sep 2015, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
> drivers/gpu/drm/i915/i915_reg.h | 2 +-
> drivers/gpu/drm/i915/intel_fbc.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index b1cf17a..fcd1e81 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -2013,7 +2013,7 @@ enum skl_disp_power_wells {
> #define FBC_CTL_CPU_FENCE (1<<1)
> #define FBC_CTL_PLANE(plane) ((plane)<<0)
> #define FBC_FENCE_OFF 0x03218 /* BSpec typo has 321Bh */
> -#define FBC_TAG 0x03300
> +#define FBC_TAG(i) (0x03300 + (i) * 4)
>
> #define FBC_STATUS2 0x43214
> #define FBC_COMPRESSION_MASK 0x7ff
> diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c
> index 1f97fb5..f8c527f 100644
> --- a/drivers/gpu/drm/i915/intel_fbc.c
> +++ b/drivers/gpu/drm/i915/intel_fbc.c
> @@ -88,7 +88,7 @@ static void i8xx_fbc_enable(struct intel_crtc *crtc)
>
> /* Clear old tags */
> for (i = 0; i < (FBC_LL_SIZE / 32) + 1; i++)
> - I915_WRITE(FBC_TAG + (i * 4), 0);
> + I915_WRITE(FBC_TAG(i), 0);
>
> if (IS_GEN4(dev_priv)) {
> u32 fbc_ctl2;
> --
> 2.4.6
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Jani Nikula, Intel Open Source Technology Center