From: Jani Nikula <jani.nikula@linux.intel.com>
To: Vandana Kannan <vandana.kannan@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm/i915: Move PPS calls to edp_init
Date: Fri, 12 Dec 2014 12:35:51 +0200 [thread overview]
Message-ID: <87ppbp6tq0.fsf@intel.com> (raw)
In-Reply-To: <1415618923-24110-2-git-send-email-vandana.kannan@intel.com>
On Mon, 10 Nov 2014, Vandana Kannan <vandana.kannan@intel.com> wrote:
> Calls to setup eDP panel power sequencer were there in dp_init_connector()
> function. Moving these calls to edp_init_connector() to keep all PPS calls
> together and under edp init.
It's a bit tricky, but I think you need to setup the power sequencer
stuff on eDP before you do AUX communication.
BR,
Jani.
>
> Signed-off-by: Vandana Kannan <vandana.kannan@intel.com>
> ---
> drivers/gpu/drm/i915/intel_dp.c | 15 +++++----------
> 1 file changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index ceb528f..34d8105 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -5258,6 +5258,11 @@ static bool intel_edp_init_connector(struct intel_dp *intel_dp,
>
> /* We now know it's not a ghost, init power sequence regs. */
> pps_lock(intel_dp);
> + intel_dp_init_panel_power_timestamps(intel_dp);
> + if (IS_VALLEYVIEW(dev))
> + vlv_initial_power_sequencer_setup(intel_dp);
> + else
> + intel_dp_init_panel_power_sequencer(dev, intel_dp);
> intel_dp_init_panel_power_sequencer_registers(dev, intel_dp);
> pps_unlock(intel_dp);
>
> @@ -5402,16 +5407,6 @@ intel_dp_init_connector(struct intel_digital_port *intel_dig_port,
> BUG();
> }
>
> - if (is_edp(intel_dp)) {
> - pps_lock(intel_dp);
> - intel_dp_init_panel_power_timestamps(intel_dp);
> - if (IS_VALLEYVIEW(dev))
> - vlv_initial_power_sequencer_setup(intel_dp);
> - else
> - intel_dp_init_panel_power_sequencer(dev, intel_dp);
> - pps_unlock(intel_dp);
> - }
> -
> intel_dp_aux_init(intel_dp, intel_connector);
>
> /* init MST on ports that can support it */
> --
> 2.0.1
>
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-12-12 10:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-10 11:28 [PATCH 0/3] Rearranging eDP PPS code Vandana Kannan
2014-11-10 11:28 ` [PATCH 1/3] drm/i915: Move PPS calls to edp_init Vandana Kannan
2014-12-12 10:35 ` Jani Nikula [this message]
2014-11-10 11:28 ` [PATCH 2/3] drm/i915: Use vlv_power_sequencer_pipe() only to get pipe Vandana Kannan
2014-12-12 10:39 ` Jani Nikula
2014-11-10 11:28 ` [PATCH 3/3] drm/i915: Splitting PPS functions based on platform Vandana Kannan
2014-11-10 21:03 ` [PATCH 3/3] drm/i915: Splitting PPS functions based on shuang.he
2014-12-12 9:35 ` [PATCH 0/3] Rearranging eDP PPS code Kannan, Vandana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ppbp6tq0.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=vandana.kannan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox