From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 5/5] drm/i915: enable fastboot by default Date: Fri, 06 Jun 2014 14:12:44 +0300 Message-ID: <87ppimcmvn.fsf@intel.com> References: <1401992671-2548-1-git-send-email-jbarnes@virtuousgeek.org> <1401992671-2548-5-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1401992671-2548-5-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jesse Barnes , intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, 05 Jun 2014, Jesse Barnes wrote: > Let them eat mincemeat pie. > > Signed-off-by: Jesse Barnes > --- > drivers/gpu/drm/i915/i915_params.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c > index d05a2af..081ab2f 100644 > --- a/drivers/gpu/drm/i915/i915_params.c > +++ b/drivers/gpu/drm/i915/i915_params.c > @@ -41,7 +41,7 @@ struct i915_params i915 __read_mostly = { > .preliminary_hw_support = IS_ENABLED(CONFIG_DRM_I915_PRELIMINARY_HW_SUPPORT), > .disable_power_well = 1, > .enable_ips = 1, > - .fastboot = 0, > + .fastboot = 42, The answer to the ultimate question of life, the universe, and everything should simply be "true" here. Personally, I don't think it's a bad answer. > .prefault_disable = 0, > .reset = true, > .invert_brightness = 0, > @@ -132,7 +132,7 @@ MODULE_PARM_DESC(enable_ips, "Enable IPS (default: true)"); > > module_param_named(fastboot, i915.fastboot, bool, 0600); Side note, why do we allow the param to be changed after boot? BR, Jani. > MODULE_PARM_DESC(fastboot, > - "Try to skip unnecessary mode sets at boot time (default: false)"); > + "Try to skip unnecessary mode sets at boot time (default: true)"); > > module_param_named(prefault_disable, i915.prefault_disable, bool, 0600); > MODULE_PARM_DESC(prefault_disable, > -- > 1.8.3.2 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Jani Nikula, Intel Open Source Technology Center