Re: [PATCH] drm/i915: Don't WARN nor handle unexpected hpd interrupts on gmch platforms

[Jani Nikula <jani.nikula@linux.intel.com>]

On Thu, 24 Apr 2014, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> The status bits are unconditionally set, the control bits only enable
> the actual interrupt generation. Which means if we get some random
> other interrupts we'll bogusly complain about them.
>
> So restrict the WARN to platforms with a sane hotplug interrupt
> handling scheme. And even more important also don't attempt to process
> the hpd bit since we've detected a storm already. Instead just clear
> the bit silently.
>
> This WARN has been introduced in
>
> commit b8f102e8bf71cacf33326360fdf9dcfd1a63925b
> Author: Egbert Eich <eich@suse.de>
> Date:   Fri Jul 26 14:14:24 2013 +0200
>
>     drm/i915: Add messages useful for HPD storm detection debugging (v2)
>
> before that we silently handled the hpd event and so partially
> defeated the storm detection.
>
> v2: Pimp commit message (Jani)
>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Egbert Eich <eich@suse.de>
> Cc: bitlord <bitlord0xff@gmail.com>
> Reported-by: bitlord <bitlord0xff@gmail.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Pushed to -fixes, thanks for the patch.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Technology Center