From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: Don't WARN nor handle unexpected hpd interrupts on gmch platforms Date: Thu, 24 Apr 2014 13:43:51 +0300 Message-ID: <87ppk7vwgo.fsf@intel.com> References: <87y4yvw3if.fsf@intel.com> <1398333797-28199-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 0D50D6E03F for ; Thu, 24 Apr 2014 03:44:08 -0700 (PDT) In-Reply-To: <1398333797-28199-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Intel Graphics Development Cc: Egbert Eich , Daniel Vetter , stable@vger.kernel.org, bitlord List-Id: intel-gfx@lists.freedesktop.org On Thu, 24 Apr 2014, Daniel Vetter wrote: > The status bits are unconditionally set, the control bits only enable > the actual interrupt generation. Which means if we get some random > other interrupts we'll bogusly complain about them. > > So restrict the WARN to platforms with a sane hotplug interrupt > handling scheme. And even more important also don't attempt to process > the hpd bit since we've detected a storm already. Instead just clear > the bit silently. > > This WARN has been introduced in > > commit b8f102e8bf71cacf33326360fdf9dcfd1a63925b > Author: Egbert Eich > Date: Fri Jul 26 14:14:24 2013 +0200 > > drm/i915: Add messages useful for HPD storm detection debugging (v2) > > before that we silently handled the hpd event and so partially > defeated the storm detection. > > v2: Pimp commit message (Jani) > > Cc: Jani Nikula > Cc: Egbert Eich > Cc: bitlord > Reported-by: bitlord > Cc: stable@vger.kernel.org > Signed-off-by: Daniel Vetter Pushed to -fixes, thanks for the patch. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center