From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD03EC07E98 for ; Mon, 5 Jul 2021 07:45:23 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B74461363 for ; Mon, 5 Jul 2021 07:45:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B74461363 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1DB0D899F2; Mon, 5 Jul 2021 07:45:23 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id EBC7F899F2 for ; Mon, 5 Jul 2021 07:45:21 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10035"; a="196104242" X-IronPort-AV: E=Sophos;i="5.83,325,1616482800"; d="scan'208";a="196104242" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jul 2021 00:45:17 -0700 X-IronPort-AV: E=Sophos;i="5.83,325,1616482800"; d="scan'208";a="485414081" Received: from elang-mobl.ger.corp.intel.com (HELO localhost) ([10.252.59.138]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jul 2021 00:45:15 -0700 From: Jani Nikula To: Lucas De Marchi In-Reply-To: <20210704053202.dncjlbkingckz4gg@ldmartin-desk2> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20210630230624.25407-1-anusha.srivatsa@intel.com> <20210701000114.smjdtszhfx24gkkj@ldmartin-desk2> <87eechqhou.fsf@intel.com> <20210704053202.dncjlbkingckz4gg@ldmartin-desk2> Date: Mon, 05 Jul 2021 10:45:11 +0300 Message-ID: <87r1gd9pbs.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH] drm/i915/dmc: Use RUNTIME_INFO->stp for DMC X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Sat, 03 Jul 2021, Lucas De Marchi wrote: > On Fri, Jul 02, 2021 at 10:49:05AM +0300, Jani Nikula wrote: >>Frankly, I think all of this should be incorporated to intel_step.[ch] >>instead of having a semi-overlapping handling here. Just look at the >>amount of duplication already. > > I guess you missed I gave the same suggestion below and that there is > already a new version of this patch? Question here was about going a > step further to avoid the conversion STEP_* to 2 chars. Sorry for the noise. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx