From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 172CEC3F2D2 for ; Mon, 2 Mar 2020 14:05:43 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E88812166E for ; Mon, 2 Mar 2020 14:05:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E88812166E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 87B1A6E2B1; Mon, 2 Mar 2020 14:05:42 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 50FBC6E2B1 for ; Mon, 2 Mar 2020 14:05:41 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Mar 2020 06:05:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,507,1574150400"; d="scan'208";a="286627611" Received: from gaia.fi.intel.com ([10.237.72.192]) by FMSMGA003.fm.intel.com with ESMTP; 02 Mar 2020 06:05:38 -0800 Received: by gaia.fi.intel.com (Postfix, from userid 1000) id 9E0805C1DA2; Mon, 2 Mar 2020 16:04:23 +0200 (EET) From: Mika Kuoppala To: Chris Wilson , intel-gfx@lists.freedesktop.org In-Reply-To: <20200302085812.4172450-12-chris@chris-wilson.co.uk> References: <20200302085812.4172450-1-chris@chris-wilson.co.uk> <20200302085812.4172450-12-chris@chris-wilson.co.uk> Date: Mon, 02 Mar 2020 16:04:23 +0200 Message-ID: <87r1ya7t08.fsf@gaia.fi.intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 12/22] drm/i915/execlists: Check the sentinel is alone in the ELSP X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Chris Wilson writes: > We only use sentinel requests for "preempt-to-idle" passes, so assert > that they are the only request in a new submission. > > Signed-off-by: Chris Wilson >From other thread, Reviewed-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/gt/intel_lrc.c | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c > index 15d56cd3937e..b9b3f78f1324 100644 > --- a/drivers/gpu/drm/i915/gt/intel_lrc.c > +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c > @@ -1448,6 +1448,7 @@ assert_pending_valid(const struct intel_engine_execlists *execlists, > { > struct i915_request * const *port, *rq; > struct intel_context *ce = NULL; > + bool sentinel = false; > > trace_ports(execlists, msg, execlists->pending); > > @@ -1481,6 +1482,26 @@ assert_pending_valid(const struct intel_engine_execlists *execlists, > } > ce = rq->context; > > + /* > + * Sentinels are supposed to be lonely so they flush the > + * current exection off the HW. Check that they are the > + * only request in the pending submission. > + */ > + if (sentinel) { > + GEM_TRACE_ERR("context:%llx after sentinel in pending[%zd]\n", > + ce->timeline->fence_context, > + port - execlists->pending); > + return false; > + } > + > + sentinel = i915_request_has_sentinel(rq); > + if (sentinel && port != execlists->pending) { > + GEM_TRACE_ERR("sentinel context:%llx not in prime position[%zd]\n", > + ce->timeline->fence_context, > + port - execlists->pending); > + return false; > + } > + > /* Hold tightly onto the lock to prevent concurrent retires! */ > if (!spin_trylock_irqsave(&rq->lock, flags)) > continue; > -- > 2.25.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx