From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [RFC PATCH] drm/i915: Restore full symmetry in i915_driver_modeset_probe/remove Date: Mon, 21 Oct 2019 15:23:10 +0300 Message-ID: <87r236fftd.fsf@intel.com> References: <6250061.7lZMOAyebC@jkrzyszt-desk.ger.corp.intel.com> <87zhhufgf9.fsf@intel.com> <87v9siffxi.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id E034C89EAE for ; Mon, 21 Oct 2019 12:23:16 +0000 (UTC) In-Reply-To: <87v9siffxi.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Janusz Krzysztofik , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAyMSBPY3QgMjAxOSwgSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4g d3JvdGU6Cj4gT24gTW9uLCAyMSBPY3QgMjAxOSwgSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGlu dGVsLmNvbT4gd3JvdGU6Cj4+IE9uIEZyaSwgMTggT2N0IDIwMTksIEphbnVzeiBLcnp5c3p0b2Zp ayA8amFudXN6LmtyenlzenRvZmlrQGxpbnV4LmludGVsLmNvbT4gd3JvdGU6Cj4+PiBDb21taXQg MmQ2ZjZmMzU5ZmQ4ICgiZHJtL2k5MTU6IGFkZCBpOTE1X2RyaXZlcl9tb2Rlc2V0X3JlbW92ZSgp IikKPj4KPj4gUGxlYXNlIGxvb2sgYXQgdGhhdCBjb21taXQgYW5kIGV4cGxhaW4gdG8gbWUgaG93 IGl0IGltcGFjdHMgYW55dGhpbmcKPj4gYWJvdXQgaW50ZWxfaXJxX3VuaW5zdGFsbCgpLgo+Cj4g U2VyaW91c2x5LCB3aHkgd2FzIHRoaXMgbWVyZ2VkIGFscmVhZHk/IEl0IGRvZXMgbm90IGZpeCAq YW55dGhpbmcqLiBJdAo+IGNpdGVzIGEgY29tbWl0IHRoYXQgZG9lcyBub3QgYnJlYWsgYW55dGhp bmcuCgpBbmQgZm9yIGNyeWluZyBvdXQgbG91ZCwgbWVyZ2VkIHdpdGhvdXQgcGFzc2luZyBDSSBy ZXN1bHRzLgoKCj4KPiBZb3UncmUgY2FsbGluZyBpbnRlbF9pcnFfdW5pbnN0YWxsKCkgKnR3aWNl KiBmb3Igbm8gZ29vZCByZWFzb24uCj4KPiBUaGUgd2hvbGUgcHJvYmUvcmVtb3ZlIGNhbGxjaGFp bnMgYXJlIGEgbWVzcywgYW5kIEknbSBpbiB0aGUgcHJvY2VzcyBvZgo+IGNsZWFuaW5nIGl0IHVw IHByb3Blcmx5LiBXaGF0IGdvb2QgZG9lcyB0aGlzIHBhdGNoIGJyaW5nIGZvciB0aGUgb3ZlcmFs bAo+IGVmZm9ydCwgb3RoZXIgdGhhbiBhbm90aGVyIHVzZWxlc3MgcXVpcmsgaW4gdGhlIGNhbGwg Y2hhaW4gdG8gdGFrZSBpbnRvCj4gYWNjb3VudD8gSW5kZWVkLCB0aGUgb25seSBhY3R1YWwgZnVu Y3Rpb25hbCBjaGFuZ2UgaXQgbWFrZXMgaW4gdGhlCj4gcmVtb3ZlIHBhdGggaXMgbm90IG1lbnRp b25lZCBpbiB0aGUgY29tbWl0IG1lc3NhZ2UgYXQgYWxsIQo+Cj4KPiBCUiwKPiBKYW5pLgo+Cj4K Pj4KPj4gQlIsCj4+IEphbmkuCj4+Cj4+Cj4+PiBjbGFpbWVkIHJlbW92YWwgb2YgYXN5bW1ldHJ5 IGluIHByb2JlKCkgYW5kIHJlbW92ZSgpIGNhbGxzLCBob3dldmVyLCBpdAo+Pj4gZGlkbid0IHRh a2UgY2FyZSBvZiBjYWxsaW5nIGludGVsX2lycV91bmluc3RhbGwoKSBvbiBkcml2ZXIgcmVtb3Zl Lgo+Pj4gVGhhdCBkb2Vzbid0IGh1cnQgYXMgbG9uZyBhcyB3ZSBzdGlsbCBjYWxsIGl0IGZyb20K Pj4+IGludGVsX21vZGVzZXRfZHJpdmVyX3JlbW92ZSgpIGJ1dCBpbiBvcmRlciB0byBoYXZlIGZ1 bGwgc3ltbWV0cnkgd2UKPj4+IHNob3VsZCBjYWxsIGl0IGFnYWluIGZyb20gaTkxNV9kcml2ZXJf bW9kZXNldF9yZW1vdmUoKS4KPj4+Cj4+PiBOb3RlIHRoYXQgaXQncyBzYWZlIHRvIGNhbGwgaW50 ZWxfaXJxX3VuaW5zdGFsbCgpIHR3aWNlIHRoYW5rcyB0bwo+Pj4gY29tbWl0IGIzMThiODI0NTVi ZCAoImRybS9pOTE1OiBOdWtlIGRybV9kcml2ZXIgaXJxIHZmdW5jcyIpLiAgV2UgbWF5Cj4+PiBv bmx5IHdhbnQgdG8gbWVudGlvbiB0aGUgY2FzZSB3ZSBhcmUgYWRkaW5nIGluIGEgcmVsYXRlZCBG SVhNRSBjb21tZW50Cj4+PiBwcm92aWRlZCBieSB0aGF0IGNvbW1pdC4gIFdoaWxlIGJlaW5nIGF0 IGl0LCB1cGRhdGUgdGhlIG5hbWUgb2YKPj4+IGZ1bmN0aW9uIG1lbnRpb25lZCBhcyBjYWxsaW5n IGl0IG91dCBvZiBzZXF1ZW5jZSBhcyB0aGF0IG5hbWUgaGFzIGJlZW4KPj4+IGNoYW5nZWQgbWVh bndoaWxlIGJ5IGNvbW1pdCA3OGRhZTFhYzM1ZGQgKCJkcm0vaTkxNTogUHJvcGFnYXRlCj4+PiAi X3JlbW92ZSIgZnVuY3Rpb24gbmFtZSBzdWZmaXggZG93biIpLgo+Pj4KPj4+IFN1Z2dlc3RlZC1i eTogTWljaGFsIFdhamRlY3prbyA8bWljaGFsLndhamRlY3prb0BpbnRlbC5jb20+Cj4+PiBTaWdu ZWQtb2ZmLWJ5OiBKYW51c3ogS3J6eXN6dG9maWsgPGphbnVzei5rcnp5c3p0b2Zpa0BsaW51eC5p bnRlbC5jb20+Cj4+PiBDYzogTWljaGFsIFdhamRlY3prbyA8bWljaGFsLndhamRlY3prb0BpbnRl bC5jb20+Cj4+PiAtLS0KPj4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jIHwgMiAr Kwo+Pj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMgfCA4ICsrKystLS0tCj4+PiAg MiBmaWxlcyBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4+Pgo+Pj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2Rydi5jCj4+PiBpbmRleCBkZDk2MTNlNDU3MjMuLjRhZTliZmE5NjI5 MCAxMDA2NDQKPj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMKPj4+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMKPj4+IEBAIC00NTIsNiArNDUyLDgg QEAgc3RhdGljIHZvaWQgaTkxNV9kcml2ZXJfbW9kZXNldF9yZW1vdmUoc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmk5MTUpCj4+PiAgCj4+PiAgCWludGVsX21vZGVzZXRfZHJpdmVyX3JlbW92ZShp OTE1KTsKPj4+ICAKPj4+ICsJaW50ZWxfaXJxX3VuaW5zdGFsbChpOTE1KTsKPj4+ICsKPj4+ICAJ aW50ZWxfYmlvc19kcml2ZXJfcmVtb3ZlKGk5MTUpOwo+Pj4gIAo+Pj4gIAl2Z2Ffc3dpdGNoZXJv b191bnJlZ2lzdGVyX2NsaWVudChwZGV2KTsKPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2lycS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYwo+Pj4g aW5kZXggYmM4M2YwOTQwNjVhLi4wMTYwMjgzODYwYTYgMTAwNjQ0Cj4+PiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2lycS5jCj4+PiBAQCAtNDUxNSwxMCArNDUxNSwxMCBAQCB2b2lkIGludGVsX2lycV91bmlu c3RhbGwoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+Pj4gIAlpbnQgaXJxID0g ZGV2X3ByaXYtPmRybS5wZGV2LT5pcnE7Cj4+PiAgCj4+PiAgCS8qCj4+PiAtCSAqIEZJWE1FIHdl IGNhbiBnZXQgY2FsbGVkIHR3aWNlIGR1cmluZyBkcml2ZXIgbG9hZAo+Pj4gLQkgKiBlcnJvciBo YW5kbGluZyBkdWUgdG8gaW50ZWxfbW9kZXNldF9jbGVhbnVwKCkKPj4+IC0JICogY2FsbGluZyB1 cyBvdXQgb2Ygc2VxdWVuY2UuIFdvdWxkIGJlIG5pY2UgaWYKPj4+IC0JICogaXQgZGlkbid0IGRv IHRoYXQuLi4KPj4+ICsJICogRklYTUUgd2UgY2FuIGdldCBjYWxsZWQgdHdpY2UgZHVyaW5nIGRy aXZlciBwcm9iZQo+Pj4gKwkgKiBlcnJvciBoYW5kbGluZyBhcyB3ZWxsIGFzIGR1cmluZyBkcml2 ZXIgcmVtb3ZlIGR1ZSB0bwo+Pj4gKwkgKiBpbnRlbF9tb2Rlc2V0X2RyaXZlcl9yZW1vdmUoKSBj YWxsaW5nIHVzIG91dCBvZiBzZXF1ZW5jZS4KPj4+ICsJICogV291bGQgYmUgbmljZSBpZiBpdCBk aWRuJ3QgZG8gdGhhdC4uLgo+Pj4gIAkgKi8KPj4+ICAJaWYgKCFkZXZfcHJpdi0+ZHJtLmlycV9l bmFibGVkKQo+Pj4gIAkJcmV0dXJuOwoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJj ZSBHcmFwaGljcyBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4