From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [RFC 4/8] drm/i915: Group gen 10 display. Date: Fri, 19 Oct 2018 11:03:53 +0300 Message-ID: <87r2gmgy6u.fsf@intel.com> References: <20181018233447.5187-1-rodrigo.vivi@intel.com> <20181018233447.5187-5-rodrigo.vivi@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id D9417899B7 for ; Fri, 19 Oct 2018 08:04:15 +0000 (UTC) In-Reply-To: <20181018233447.5187-5-rodrigo.vivi@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org Cc: lucas.demarchi@intel.com, Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAxOCBPY3QgMjAxOCwgUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29t PiB3cm90ZToKPiBDb250aW51aW5nIHdpdGggdGhlIGdvYWwgb2YgdXNlIGxlc3MgcGxhdGZvcm0g Y29kZW5hbWVzOgo+IGxldCdzIGdyb3VwIHBsYXRmb3JtcyB3aG8gaGFzIGdlbjEwIGRpc3BsYXku CgpBaGFoLCBzbyB0aGlzIGFuc3dlcnMgbXkgcXVlc3Rpb24gaW4gdGhlIHByZXZpb3VzIHBhdGNo LiA7KQoKU28gd2UgYWxyZWFkeSBoYXZlIEhBU19HTUNIX0RJU1BMQVkoKS4KCklmIHdlJ3JlIGdv aW5nIHRvIG1ha2UgZ2VuMTAgZGlzcGxheSBhIHRoaW5nLCBzaG91bGQgd2Ugbm90IGdlbmVyYWxp emUKdGhpcyB0byBoYXZlIGFuIGFjdHVhbCBkaXNwbGF5IGdlbiBpbiBkZXZpY2UgaW5mbz8gT2Yg Y291cnNlIGZvciBtb3N0CnBsYXRmb3JtcyBpdCdzIGdvaW5nIHRvIGJlIGlkZW50aWNhbCB0byB0 aGUgZ2VtIGdlbi4KClRoZSBxdWVzdGlvbiBiZWNvbWVzLCBpcyBkaXNwbGF5IGdlbiBhY2N1cmF0 ZSBlbm91Z2g/IEl0J3Mgbm90IGVub3VnaCB0bwpjb3ZlciBhbGwgb2YgR2VtaW5pbGFrZSBJIGJl bGlldmUuIFdoaWNoIG1ha2VzIG1lIHRoaW5rLCBzaG91bGQgd2UganVzdAphZGQgdG9ucyBtb3Jl IGRldmljZSBpbmZvIGZsYWdzIHRvIGNvdmVyIGZlYXR1cmVzIGF0IGEgZGV0YWlsZWQgbGV2ZWw/ IEkKdGhpbmsgdGhhdCdzIHdoYXQgSm9vbmFzIGFkdm9jYXRlcy4gUGVyaGFwcyBpdCBibG9hdHMg dGhlIGRldmljZSBpbmZvLAphbmQgY2F1c2VzIGluY3JlYXNlIGluIHRoZSBudW1iZXIgb2YgZGV2 aWNlIGluZm8gYmxvY2tzLiBCdXQgbXkgZ3V0CmZlZWxpbmcgc2F5cyB0b2dldGhlciB3aXRoIHRy dWx5IGltbXV0YWJsZSBkZXZpY2UgaW5mbywgdGhlcmUgYXJlCmNvbXBpbGVyIG9wdGltaXphdGlv biBiZW5lZml0cyB0byBiZSBoYWQuCgpBbHNvLCBjdXJyZW50bHkgd2UgImluaGVyaXQiIGRldmlj ZSBpbmZvIHVzaW5nIHRydWx5IG9ibm94aW91cyBtYWNybwpsYXllcmluZyB3aGVyZSB5b3UgaGF2 ZSB0byB3b3JrIGhhcmQgdG8gdHJhY2UgdGhlIG1hY3JvcyB0byBmaW5kIG91dAp3aGF0IGlzIHNl dCBmb3IgYSBnaXZlbiBwbGF0Zm9ybS4gSXQgZG9lc24ndCBoYXZlIHRvIGJlIHRoYXQgd2F5LiBX ZQpjb3VsZCBtb3ZlIHBhcnRzIG9mIGl0IHRvIHNlcGFyYXRlIGJ1dCBzaGFyZWQgZmVhdHVyZXMg c3RydWN0cywgYW5kIGFkZApwb2ludGVycyB0byB0aGVtLgoKQW55d2F5LCB0aGFua3MgZm9yIHJv bGxpbmcgdGhpcyBzZXJpZXMgYXMgYSBzdGFydGluZyBwb2ludCBmb3IKZGlzY3Vzc2lvbi4gRXZl biBpZiBJJ20gbm90IGJ1eWluZyB0aGUgY2hhbmdlcyBhcy1pcy4gOykKCgpCUiwKSmFuaS4KCj4K PiBTaWduZWQtb2ZmLWJ5OiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+Cj4g LS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggICAgICB8IDIgKysKPiAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY2RjbGsuYyAgIHwgMiArLQo+ICBkcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9jb2xvci5jICAgfCAyICstCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Rpc3BsYXkuYyB8IDQgKystLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJp dGUuYyAgfCAyICstCj4gIDUgZmlsZXMgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCA1IGRlbGV0 aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2Lmgg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gaW5kZXggZDE5YjM4ZWYxNDViLi42 NDM2ZmVkZmU1NjEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYu aAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiBAQCAtMjYzNyw2ICsy NjM3LDggQEAgaW50ZWxfaW5mbyhjb25zdCBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYpCj4gICNkZWZpbmUgU1VQUE9SVFNfVFYoZGV2X3ByaXYpCQkoKGRldl9wcml2KS0+aW5mby5z dXBwb3J0c190dikKPiAgI2RlZmluZSBJOTE1X0hBU19IT1RQTFVHKGRldl9wcml2KQkoKGRldl9w cml2KS0+aW5mby5oYXNfaG90cGx1ZykKPiAgCj4gKyNkZWZpbmUgSEFTX0RJU1BMQVlfMTAoZGV2 X3ByaXYpIChJU19HRU4xMChkZXZfcHJpdikgfHwgSVNfR0VNSU5JTEFLRShkZXZfcHJpdikpCj4g Kwo+ICAjZGVmaW5lIEhBU19GV19CTEMoZGV2X3ByaXYpIAkoSU5URUxfR0VOKGRldl9wcml2KSA+ IDIpCj4gICNkZWZpbmUgSEFTX0ZCQyhkZXZfcHJpdikJKChkZXZfcHJpdiktPmluZm8uaGFzX2Zi YykKPiAgI2RlZmluZSBIQVNfQ1VSX0ZCQyhkZXZfcHJpdikJKCFIQVNfR01DSF9ESVNQTEFZKGRl dl9wcml2KSAmJiBJTlRFTF9HRU4oZGV2X3ByaXYpID49IDcpCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2NkY2xrLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9jZGNsay5jCj4gaW5kZXggNGFhNjUwMDYwNGNjLi5iMzE1YjcwZmQ0OWMgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY2RjbGsuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2NkY2xrLmMKPiBAQCAtMjE4MSw3ICsyMTgxLDcgQEAgaW50IGludGVs X2NydGNfY29tcHV0ZV9taW5fY2RjbGsoY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNy dGNfc3RhdGUpCj4gIAkgICAgY3J0Y19zdGF0ZS0+aGFzX2F1ZGlvICYmCj4gIAkgICAgY3J0Y19z dGF0ZS0+cG9ydF9jbG9jayA+PSA1NDAwMDAgJiYKPiAgCSAgICBjcnRjX3N0YXRlLT5sYW5lX2Nv dW50ID09IDQpIHsKPiAtCQlpZiAoSVNfQ0FOTk9OTEFLRShkZXZfcHJpdikgfHwgSVNfR0VNSU5J TEFLRShkZXZfcHJpdikpIHsKPiArCQlpZiAoSEFTX0RJU1BMQVlfMTAoZGV2X3ByaXYpKSB7Cj4g IAkJCS8qIERpc3BsYXkgV0EgIzExNDU6IGdsayxjbmwgKi8KPiAgCQkJbWluX2NkY2xrID0gbWF4 KDMxNjgwMCwgbWluX2NkY2xrKTsKPiAgCQl9IGVsc2UgaWYgKElTX0dFTjkoZGV2X3ByaXYpIHx8 IElTX0JST0FEV0VMTChkZXZfcHJpdikpIHsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfY29sb3IuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NvbG9yLmMK PiBpbmRleCA1MTI3ZGEyODZhMmIuLmQ1ZjY3YjljOTY5OCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9jb2xvci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfY29sb3IuYwo+IEBAIC02NTksNyArNjU5LDcgQEAgdm9pZCBpbnRlbF9jb2xvcl9pbml0 KHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPiAgCQkgICBJU19CUk9YVE9OKGRldl9wcml2KSkgewo+ ICAJCWRldl9wcml2LT5kaXNwbGF5LmxvYWRfY3NjX21hdHJpeCA9IGlsa19sb2FkX2NzY19tYXRy aXg7Cj4gIAkJZGV2X3ByaXYtPmRpc3BsYXkubG9hZF9sdXRzID0gYnJvYWR3ZWxsX2xvYWRfbHV0 czsKPiAtCX0gZWxzZSBpZiAoSVNfR0VNSU5JTEFLRShkZXZfcHJpdikgfHwgSVNfQ0FOTk9OTEFL RShkZXZfcHJpdikpIHsKPiArCX0gZWxzZSBpZiAoSEFTX0RJU1BMQVlfMTAoZGV2X3ByaXYpKSB7 Cj4gIAkJZGV2X3ByaXYtPmRpc3BsYXkubG9hZF9jc2NfbWF0cml4ID0gaWxrX2xvYWRfY3NjX21h dHJpeDsKPiAgCQlkZXZfcHJpdi0+ZGlzcGxheS5sb2FkX2x1dHMgPSBnbGtfbG9hZF9sdXRzOwo+ ICAJfSBlbHNlIHsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5kZXggN2Iw NGI4NDM2YjZkLi4xYWJmNzlhNGVlOTEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5jCj4gQEAgLTU3MzAsNyArNTczMCw3IEBAIHN0YXRpYyB2b2lkIGhhc3dlbGxfY3J0Y19l bmFibGUoc3RydWN0IGludGVsX2NydGNfc3RhdGUgKnBpcGVfY29uZmlnLAo+ICAJaW50ZWxfY3J0 Yy0+YWN0aXZlID0gdHJ1ZTsKPiAgCj4gIAkvKiBEaXNwbGF5IFdBICMxMTgwOiBXYURpc2FibGVT Y2FsYXJDbG9ja0dhdGluZzogZ2xrLCBjbmwgKi8KPiAtCXBzbF9jbGtnYXRlX3dhID0gKElTX0dF TUlOSUxBS0UoZGV2X3ByaXYpIHx8IElTX0NBTk5PTkxBS0UoZGV2X3ByaXYpKSAmJgo+ICsJcHNs X2Nsa2dhdGVfd2EgPSAoSEFTX0RJU1BMQVlfMTAoZGV2X3ByaXYpKSAmJgo+ICAJCQkgcGlwZV9j b25maWctPnBjaF9wZml0LmVuYWJsZWQ7Cj4gIAlpZiAocHNsX2Nsa2dhdGVfd2EpCj4gIAkJZ2xr X3BpcGVfc2NhbGVyX2Nsb2NrX2dhdGluZ193YShkZXZfcHJpdiwgcGlwZSwgdHJ1ZSk7Cj4gQEAg LTE1NTY1LDcgKzE1NTY1LDcgQEAgZ2V0X2VuY29kZXJfcG93ZXJfZG9tYWlucyhzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIHN0YXRpYyB2b2lkIGludGVsX2Vhcmx5X2Rpc3Bs YXlfd2FzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgewo+ICAJLyogRGlz cGxheSBXQSAjMTE4NSBXYURpc2FibGVEQVJCRkNsa0dhdGluZzpjbmwsZ2xrICovCj4gLQlpZiAo SVNfQ0FOTk9OTEFLRShkZXZfcHJpdikgfHwgSVNfR0VNSU5JTEFLRShkZXZfcHJpdikpCj4gKwlp ZiAoSEFTX0RJU1BMQVlfMTAoZGV2X3ByaXYpKQo+ICAJCUk5MTVfV1JJVEUoR0VOOV9DTEtHQVRF X0RJU18wLCBJOTE1X1JFQUQoR0VOOV9DTEtHQVRFX0RJU18wKSB8Cj4gIAkJCSAgIERBUkJGX0dB VElOR19ESVMpOwo+ICAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf c3ByaXRlLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYwo+IGluZGV4IDdj ZDU5ZWVlNWNhZC4uOTEyYWI3YjlkODlhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3Nwcml0ZS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3By aXRlLmMKPiBAQCAtMTMzMCw3ICsxMzMwLDcgQEAgc3RhdGljIGludCBza2xfcGxhbmVfY2hlY2tf ZHN0X2Nvb3JkaW5hdGVzKGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3MKPiAg CSAqIHRoYW4gdGhlIGN1cnNvciBlbmRpbmcgbGVzcyB0aGFuIDQgcGl4ZWxzIGZyb20gdGhlIGxl ZnQgZWRnZSBvZiB0aGUKPiAgCSAqIHNjcmVlbiBtYXkgY2F1c2UgRklGTyB1bmRlcmZsb3cgYW5k IGRpc3BsYXkgY29ycnVwdGlvbi4KPiAgCSAqLwo+IC0JaWYgKChJU19HRU1JTklMQUtFKGRldl9w cml2KSB8fCBJU19DQU5OT05MQUtFKGRldl9wcml2KSkgJiYKPiArCWlmIChIQVNfRElTUExBWV8x MChkZXZfcHJpdikgJiYKPiAgCSAgICAoY3J0Y194ICsgY3J0Y193IDwgNCB8fCBjcnRjX3ggPiBw aXBlX3NyY193IC0gNCkpIHsKPiAgCQlEUk1fREVCVUdfS01TKCJyZXF1ZXN0ZWQgcGxhbmUgWCAl cyBwb3NpdGlvbiAlZCBpbnZhbGlkICh2YWxpZCByYW5nZSAlZC0lZClcbiIsCj4gIAkJCSAgICAg IGNydGNfeCArIGNydGNfdyA8IDQgPyAiZW5kIiA6ICJzdGFydCIsCgotLSAKSmFuaSBOaWt1bGEs IEludGVsIE9wZW4gU291cmNlIEdyYXBoaWNzIENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngK