From: Jani Nikula <jani.nikula@intel.com>
To: Nick Desaulniers <ndesaulniers@google.com>, swboyd@chromium.org
Cc: intel-gfx@lists.freedesktop.org,
Nathan Chancellor <natechancellor@gmail.com>
Subject: Re: [PATCH 2/2] drm/i915: Ensure intel_engine_init_execlist() builds with Clang
Date: Wed, 17 Oct 2018 10:24:45 +0300 [thread overview]
Message-ID: <87r2gpjarm.fsf@intel.com> (raw)
In-Reply-To: <CAKwvOdm_DHiaP849MFMiE6EdbzpFEEYSYN8Cq72msmTSF0-fyA@mail.gmail.com>
On Tue, 16 Oct 2018, Nick Desaulniers <ndesaulniers@google.com> wrote:
> On Tue, Oct 16, 2018 at 8:35 AM Stephen Boyd <swboyd@chromium.org> wrote:
>>
>> Quoting Jani Nikula (2018-10-16 05:29:38)
>> > Clang build with UBSAN enabled leads to the following build error:
>
> I'm overjoyed that you're testing this configuration! If you find more
> bugs, we're happy to help triage if you let us know about them here:
> https://github.com/ClangBuiltLinux/linux/issues.
Everyone, thanks for the patches/reports, reviews, and testing! These
two have now been pushed to drm-intel-next-queued; due to timing they're
expected to land upstream in the merge window for v4.21 i.e. not the
imminent one. (So much for the quick turnaround! ;)
Also glad to connect you all here. :)
So I don't mind making small concessions to Clang build such as these in
the interest of gaining better static analysis. Our (i915) own pre-merge
build testing uses primarily gcc and sparse, with a bunch of extra flags
(see the top of drivers/gpu/drm/i915/Makefile), but I'm not sure about
adding Clang to the mix anytime soon. Without a tight and constant
feedback loop new issues will pop up though. Maybe we'll spot inline
function use in constant expressions in review, maybe we don't. I'm sure
there are other Clang specific issues.
Do you have any plans for setting up something like the 0day? Without
the feedback loop I think you'll take one step back for every two steps
you progress...
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-10-17 7:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 12:29 [PATCH 1/2] drm/i915: Ensure _print_param() builds with Clang Jani Nikula
2018-10-16 12:29 ` [PATCH 2/2] drm/i915: Ensure intel_engine_init_execlist() " Jani Nikula
2018-10-16 15:11 ` Nathan Chancellor
2018-10-16 15:18 ` Chris Wilson
2018-10-16 15:35 ` Stephen Boyd
2018-10-16 18:33 ` Nick Desaulniers
2018-10-17 7:24 ` Jani Nikula [this message]
2018-10-22 21:10 ` Nick Desaulniers
2018-10-22 21:19 ` Nick Desaulniers
2018-10-16 12:35 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: Ensure _print_param() " Patchwork
2018-10-16 13:00 ` ✓ Fi.CI.BAT: success " Patchwork
2018-10-16 14:14 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-10-16 15:10 ` [PATCH 1/2] " Nathan Chancellor
2018-10-16 15:16 ` Chris Wilson
2018-10-16 18:38 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2gpjarm.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).